Issue #5632Opened January 20, 2024by Harshsne260 reactions

BUG: Add a change to the undomanager

Question

GrapesJS version

  • I confirm to use the latest version of GrapesJS

What browser are you using?

Chrome v91

Reproducible demo link

https://codepen.io/dhanadsp1120/pen/ExrRvOB

Describe the bug

How to reproduce the bug? 1.Disable the undo manager by invoking um.stop(). 2.Make alterations to the content. 3.Re-enable the undo manager using um.start().

What is the expected behavior? When the undo manager resumes, any modifications made after its pause should be treated as a single change. This ensures that clicking "undo" will revert the entire set of alterations to the state prior to the undo manager's interruption.

What is the current behavior? The changes made after undomanager stopped is not included as change after it is resumed.Upon selecting the undo option, the changes persist and are not rolled back as expected.

Also i have tried added the change to the undomanager : var components = editor.Components; editor.UndoManager.add(components.getComponents().models);

Code of Conduct

  • I agree to follow this project's Code of Conduct

Answers (1)

artfJanuary 20, 20240 reactions

When the undo manager resumes, any modifications made after its pause should be treated as a single change. This ensures that clicking "undo" will revert the entire set of alterations to the state prior to the undo manager's interruption.

Sorry, but this is not how UndoManager start/stop works. When you disable it, all the changes are simply skipped from the UndoStack. What you're mentioning is a programmatic grouping of changes, for sure an interesting thing but at the moment is not supported so I'm not considering this a bug. I'd suggest proposing this to the Roadmap, if more people need this, we can think about implementing it.

Related Questions and Answers

Continue research with similar issue discussions.

Paid Plugins That Match This Issue

Curated by issue keywords and label relevance to help you ship faster.

View all plugins

Loading paid plugin recommendations...

Browse Plugin Categories

Jump directly to plugin category pages on the marketplace.