BUG: React components componentWillUnmount is not called
Question
GrapesJS version
- I confirm to use the latest version of GrapesJS
What browser are you using?
Chrome 108.0.5359.125 (Windows)
Reproducible demo link
https://codesandbox.io/s/white-meadow-o56l2d?file=/src/Chart/Chart.js:135-254 This demo is not in the latest grapesjs version, but locally, using the latest version, I have the same bug
Describe the bug
How to reproduce the bug?
- Go to this link
- Open the Console
- Drag a "Chart" Block to Body
- Check that "chart created" is logged
- Delete the chart
- "chart removed" isn't logged.
What is the expected behavior? ReactComponent.componentWillUnmount() / componentWillUnmount for functional components should be called when a component is deleted
What is the current behavior? ReactComponent.componentWillUnmount is not called, but mount is.
Code of Conduct
- I agree to follow this project's Code of Conduct
Answers (1)
I've noticed that in my component definition I was doing
reactRoot.render(<>{reactEl} </>)
in onRender() then, I was missing to add
root.unmount()
n remove() method
Related Questions and Answers
Continue research with similar issue discussions.
Issue #4851
BUG: this.on('change:attributes:type', this.handleTypeChange) do not support array type
GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? Chrome 108.0.5359.125Reproducible demo link...
Issue #4906
BUG: Grapesjs fails to recognize component types when setting innerHTML through script.
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? chrome v108.0.5359.98 Reproducible demo li...
Issue #4612
BUG: Cannot Drop MJML Components onto Blank Canvas after version 0.19.4
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? 105.0.5195.125 (Official Build) (x86_64) R...
Issue #3986
BUG: Cannot read properties of undefined (reading 'uploadFile')
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome v96.0.4664.45 Reproducible demo lin...
Paid Plugins That Match This Issue
Curated by issue keywords and label relevance to help you ship faster.
Loading paid plugin recommendations...
Browse Plugin Categories
Jump directly to plugin category pages on the marketplace.