Version: 0.16.22 Are you able to reproduce the bug from the demo? [ x] Yes Steps:Click Import HTMLInsert <img src="anyimagesource.gif" onload="alert(1)"/>The JS will be executed Having proper "sandbox" attribute on iframe could probably mitigate the problem.
artf
Well if you use GrapesJS and allow the possibility to insert custom HTML, yes, Self-XSS is possible. Unfortunately, there are few issues that do not allow me to fix this properlyI need to access the iframe's DOM in order to add/update inne...
rukavina
You are right, we thought sandbox="allow-same-origin" will do the job, but allow-scripts is also needed, and then it's like not using sandbox at all. But, what could be helpful anyway is to provide a way for grapejs users to somehow contro...
blinkybill
if you use content security policy http header you can get around a lot of XSS issues like this. but there is one issue with GrapesJS atm which is that it uses underscore.js, which includes a function with use of "eval" so you can't make t...
Hi, I try to add custom class using the button on the panel control but it is not working. Check the quick video to see what I'm talking about : https://www.loom.com/share/c50fdc3741094c0f9fea65b05eb78d3a Thx.
artf
Sorry, but for such a case I can't do much without a reproducible demo, the official demo with the latest version works fine, so I guess it might be something wrong only on your side.
no-response[bot]
This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take ac...
Hi. I updated GrapesJS to its current version 0.16.22 and I get an error on the callback function: editor.on("component:add", (model) => { editor.select(model); }); The error stack: Unhandled Rejection (TypeError): i.classList is undefined Stack: ./nodemodules/grapesjs/dist/grapes.min.js/</</w.toggleClass/</< nodemodu...
hellocaio
Never mind, problem solved by: editor.on("load", () => { editor.on("component:add", (model) => { editor.select(model); }); });
hellocaio
Ok, never mind the previous never mind. It worked a few times now I'm getting the same error. Sorry about that.
Hello, so first thanks to have create GrapesJs this very usefull. I have an issue i add an header on my page and that's the code i add for the header: <header style="padding: 100px 0px;position: absolute;top:0; width:100%"></header> The problem is : When i add first a text area or an other element and then i add the h...
artf
Are you able to provide a live example?
lebonsavane
How can i contact you ?
artf
@lebonsavane just provide an example on JSFiddle or similar
Version: 0.15.9 How to modify/remove few CSS properties for existing blocks like(text, image) in style manager I have checked the following link also https://github.com/artf/grapesjs/issues/1428 Could u please provide a solution
dharmatv
I tried with the above solution(#1428) but didn't get output, please check the following code and view screenshots, so, please help on this https://snipboard.io/Om0BXG.jpg https://snipboard.io/tcJVY0.jpg
artf
Please explain better what are you trying to achieve
no-response[bot]
This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take ac...
Version: 0.16.22Are you able to reproduce the bug from the demo? [x] Yes [ ] NoWhat is the expected behavior? no errors in the console.Describe the bug detailed File involved is: https://github.com/artf/grapesjs/blob/6296bf8c970f700aa69e44728b7db80833452f69/src/dom_components/view/ComponentTextView.js#L61
artf
Weird (the view component can't exist without the model), are you able to provide exact steps to reproduce the issue?
no-response[bot]
This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take ac...
Version: 0.16.22 Are you able to reproduce the bug from the demo? [x] Yes [ ] No What is the expected behavior? To import grapejs css and module Describe the bug detailed SyntaxError: Invalid or unexpected token at Object.Module.extensions..js (internal/modules/cjs/loader.js:1157:10) AND /project/nodemodules/grapesjs/...
artf
sorry, are you able to provide a live example?
no-response[bot]
This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take ac...
WARNING READ and FOLLOW next 3 steps, then REMOVE them before posting the issueFollow CONTRIBUTING Guidelines https://github.com/artf/grapesjs/blob/master/CONTRIBUTING.mdDo a quick SEARCH first, to see if someone else didn't open the same issueAll relative statements/questions have to be filled/answered, otherwise, th...
artf
There is already an option for upload URL https://github.com/artf/grapesjs/blob/8822aa6c6e8ced09ad50f2c8392f1754d3a6ec8b/src/asset_manager/config/config.js#L18-L21
no-response[bot]
This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take ac...
This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take ac...
Currently the changesCount is only increased regardless of undo and redo. I wonder if there is an application where the actual value is used or if this is just a boolean indicator for changes. If it is just used as boolean, it would be possible to instead add a flag to the undo state and mark the saved position. This...
mcottret
Hi @neon12345 ! As far as I know, the changesCount is also used in conjunction with stepsBeforeSave to trigger storing when autosave is enabled. (cf: https://grapesjs.com/docs/modules/Storage.html#store-and-load-templateshttps://github.com...
neon12345
Ok. But that means undo and redo will always trigger autosave, which is not optimal.
artf
getDirtyCount returns the number of changes, so it's not used as a boolean. If you have a better solution to handle undo/redo changes the PR is welcome