FEAT: Combine getDirtyCount with undo/redo

Question

Currently the changesCount is only increased regardless of undo and redo. I wonder if there is an application where the actual value is used or if this is just a boolean indicator for changes. If it is just used as boolean, it would be possible to instead add a flag to the undo state and mark the saved position. This way it is possible to signal changes only when the undo stack does not point to the saved position on undo and redo. Something like this seems to work: var um = editor.UndoManager;...

mcottret · Accepted Answer

Hi @neon12345 ! As far as I know, the changesCount is also used in conjunction with stepsBeforeSave to trigger storing when autosave is enabled. (cf: https://grapesjs.com/docs/modules/Storage.html#store-and-load-templateshttps://github.com/artf/grapesjs/blob/dev/src/editor/model/Editor.js#L170 ) Cheers !

neon12345 · Answer

Ok. But that means undo and redo will always trigger autosave, which is not optimal.

artf · Answer

getDirtyCount returns the number of changes, so it's not used as a boolean. If you have a better solution to handle undo/redo changes the PR is welcome

Combine getDirtyCount with undo/redo

Question

Answers (3)

Related Questions and Answers

[Question] Add custom html inside canvas

[BUG] Model not able to change after changing value in custom Select dropdown menu.

StyleManager events fire multiple times per change

[Question]The canvas turns dark and unmodifiable on adding a large piece of custom html.

Paid Plugins That Match This Issue

Browse Plugin Categories