GrapesJS Issues

3,464 parsed GitHub issues β€” 370 solved Β· 90 open. Search, filter and explore battle-tested answers.

743 issues found

πŸ” bug
#3460May 17, 2021by Redix02 answers
0 reactions

TypeError: Cannot read property 'get' of undefined

Error: (node:206) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'get' of undefined (node:206) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled wi...

artf

Please follow the issue template

GJSBlock

Thanks for reporting this, @Redix0. Security and dependency issues are important. The GrapesJS team actively works on keeping dependencies up-to-date. For you right now: Run npm audit fix to see available patches Check for a newer GrapesJS...

#3459May 16, 2021by anlumo2 answers
1 reactions

DomComponents' Config Incorrect

Version: 0.17.3 What is the expected behavior? The documentation says that I can configure the wrapper element via the configuration: https://github.com/artf/grapesjs/blob/0027dcd1194715eeaf4b24db878dd7ebac069cc4/src/dom_components/config/config.js#L6-L24 Describe the bug detailed I don't think that this configuration...

artf

Yeah, actually the name, by default, is managed via i18n configuration. From 0.17.* version even the wrapper option is not necessary anymore as now you should extend the wrapper component as all others (in previous versions the wrapper was...

GJSBlock

Thanks for reporting this, @anlumo. The issue with DomComponents' Config Incorrect appears to be a race condition or state management timing problem. This typically happens when component lifecycle events and DOM modifications overlap, cre...

#3457May 13, 2021by RaresVlaiduc4 answers
3 reactions

Custom trait input not working

Hi @artf ! Version: 0.17.3 Are you able to reproduce the bug from the demo?[ ] Yes[x] No What is the expected behavior? The input is created correctly Describe the bug detailed I am trying to create a custom input (checkbox) and it doesn't work. What is the current behavior? See attach. Are you able to attach screensh...

artf

@RaresVlaiduc mmm I'd expect it to work also with an HTML string... I have to check it

ahmedderkaoui

Then, in createInput() you should return an Element. So instead of returning a simple string, do this:

ahmedderkaoui

If you want to have a simple checkbox with label, no need to create custom trait, you can just use directly:

#3455May 12, 2021by harsh2013 answers
2 reactions

Style gets wiped out when inserting components in multiple page using Page Manager

Version: 0.17.3 What is the expected behavior? Style should be retained across multiple pages Describe the bug detailed We have use case where we save and reload the content of GrapesJS. We want to leverage Page Manager to reduce the content rendered and manage it in smaller chunks. The issue pops up when we try to lo...

artf

Hi @harsh201 styles are available across all pages, so you shouldn't use editor.setStyle (which replaces all styles with a new set) but instead something like editor.getStyle().add('...')

harsh201

Hi @artf, any help here?

GJSBlock

Thanks for reporting this, @harsh201. The issue with Style gets wiped out when inserting components in multiple page using Page Manager appears to be a race condition or state management timing problem. This typically happens when componen...

#3454May 12, 2021by TheDude703 answers
0 reactions

RTE insert link does not update DOM

Version: "0.17.3" Are you able to reproduce the bug from the demo?[X] Yes[ ] No What is the expected behavior? After inserting link using default RTE that it is immediately available to be further edited in settings, i.e. setting the HREF and Target Describe the bug detailed After selecting text with the default RTE a...

artf

Yeah, this is how it works right now (content is parsed and transformed in components only once the editing is finished). Probably we can use an approach like this as the default behaviour for links.

artf

Updated the link creation from this release https://github.com/artf/grapesjs/releases/tag/v0.18.3

GJSBlock

Thanks for reporting this, @TheDude70. The issue with RTE insert link does not update DOM appears to be a race condition or state management timing problem. This typically happens when component lifecycle events and DOM modifications overl...

#3446May 9, 2021by Spectrevuln-sketch4 answers
0 reactions

Cannot Store Data Unexpected token '-'

Please Help Me, I Want To Store gjs data to mysql but i cannot get any data from front end to back end here my code: const editor = grapesjs.init({ container: "#editor", storageManager: { type: 'remote', params: {}, // For custom values on requests // your SERVER endpoints urlStore: 'http://example.com/store-webpage',...

Ju99ernaut

Variable names can't contain '-', so this syntax is invalid:

Spectrevuln-sketch

please help i want to store my the template to mysql how i to do it?

Ju99ernaut

Unfortunately this may be beyond the scope of grapesjs but some things to note Also since it looks like you're removing the gjs- prefix during storage, you must also add it back during loading. A similar approach is used here https://githu...

#3444May 8, 2021by mahfuzdiu4 answers
0 reactions

RemoveButton() causing error

Hi, I'm trying to remove a button from panel using this code editor.Panels.removeButton('options', 'fullscreen') . It removes the button but gives me this error. How to solve it?

mahfuzdiu

I hid it with custom css editor.Panels.getButton('options', 'fullscreen').attributes.className = 'hidepanelbtn' btw a proper solution would be nice.

artf

Hi @mahfuzdiu by doing so on the official demo, it works with no errors, are you able to create a reproducible demo?

no-response[bot]

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take ac...

#3443May 7, 2021by chilled-capybara4 answers
0 reactions

Backbone-undo/underscore security advisory

Version: v0.17.3 Are you able to reproduce the bug from the demo?[x] Yes[ ] No What is the expected behavior? See below What is the current behavior? There is a known security vulnerability in one of the versions of underscore used by a nested dependency. The current version of grapejs utilises backbone-undo ^0.2.5 ht...

emyasnikov

I'm also wondering if backbone-undo is needed or can be replaced by something similar. The package hasn't been updated for 6 years

artf

The package hasn't been updated for 6 years Well, except updating its dependencies (like in this case, for security reason) it's a feature-complete library, there is no need to add/update anything else. Anyway, this PR seems to fix the sec...

chilled-capybara

Thanks for your replyAnyway, this PR seems to fix the security vulnerability at the .lock level but I'm not sure if are kept on a fresh install. I think that might fix the version in the main grapejs repo, but I'm not sure it restricts the...

#3442May 7, 2021by zgeist4 answers
4 reactions

Error after call `editor.destroy()`

Create editor instance Try destroy Got error

artf

Thanks for the report, I'll try to fix it in the next release @ershadul1 nope, there is a FrameWrapView (stuff around the iframe, like wrappers, tools for selection etc.), and inside there is a FrameView (the iframe itself), but probably f...

ershadul1

https://github.com/artf/grapesjs/blob/0027dcd1194715eeaf4b24db878dd7ebac069cc4/src/canvas/view/FrameWrapView.js#L73 I'm seeing that the remove is used inside the remove itself. I don't understand. Was this a mistake? If I set this.frame =...

PRTTMPRPHT

+1

#3441May 7, 2021by emilsedgh4 answers
1 reactions

Parser breaks `mj-style` as of 16.30

Version: All Grapesjs version from 16.30 to now have this issues. Are you able to reproduce the bug from the demo?[x] Yes[ ] No What is the expected behavior? The following is valid MJML code. It should work fine on grapesjs-mjml. Describe the bug detailed Right now, if you use grapesjs-mjml with the code above it wil...

emilsedgh

Hi Artur. Thank you for the great job done on grapesjs. It really is fantastic. The interim solution works just fine. Feel free to close out if necessary, but providing a way of manipulating the behavior would definitely be pretty nice.

artf

Hi @emilsedgh I apologize for being so late on this issue, but anyway, we can think about how to skip escape in cases like that but probably the fastest way is to simply extend mj-style toHTML method

artf

Thanks Emil, for now, I'll close this one, in case another similar issue will arise, we'll think about adding a new prop for skipping the escape.

Browse all topics