GrapesJS Issues

artf

You can use Discussions if you have questions, Issues are only for reproducible bugs

GJSBlock

Thanks for reporting this, @joukhar. Great question about prevent event using custom plugin. The recommended approach with GrapesJS is to use the event-driven API. Start here: Check the GrapesJS documentation for your specific module Look...

artf

RTE relies on the DOM content during the editing so if you remove it deliberately with something like inner components will be removed once the editing is finished.

benryanwilliams

Ok thanks @artf, that makes sense. However, those lines of code, along with are required to render the correct selected state inside the canvas as follows (both upon the component initially being rendered and when the user selects a differ...

benryanwilliams

I need to do some more testing but it looks like I've got around this behaviour by saving the inner components inside the component itself when first creating it / editing it, then using the rte:disable hook as follows: It seems a bit hack...

Singwai

Feel free to update the type definition, here is an example commit. https://github.com/artf/grapesjs/commit/49deeeeab74aff3e46f22d0bb06e7f7608955afd

Aventrue

My workaround: let assetConfig: grapesjs.AssetManagerConfig = {}; assetConfig["custom"] = { open: (props) => { this.openGalleryDialog(props); }, close: (props) => { this.dialog.closeAll(); }, };

GJSBlock

Thanks for reporting this, @Aventrue. The issue with Custom is missing in the AssetManagerConfig appears to be a race condition or state management timing problem. This typically happens when component lifecycle events and DOM modification...

Singwai

This is behaving as expected. There are two similar keys that can alter the style of the component. (styles and style) styles takes a CSS string and is attached to the final payload once. I usually define the default CSS or default CSS wit...

artf

I guess parseStyle is not a function refers to this one already fixed: https://github.com/artf/grapesjs/pull/4520

GJSBlock

Thanks for reporting this, @ahmafi. Great question about parseStyle is not a function. The recommended approach with StyleManager is to use the event-driven API. Start here: Check the GrapesJS documentation for your specific module Look fo...

artf

Update the page How do you update the page? Worth nothing, page:* events are only triggered for page models, not the content of the page, eg.

stljeff1

any update, dragging a block, changing text color. changing text content. In the JS Fiddle, I drag a Text block, change content, and change color. I do not see an event triggering when i make these updates, so I am questioning my expectati...

artf

Ok so page:update event is not what you need as it doesn't trigger on content change (so I'm closing the issue as the event is working as expected). Can you explain what kind of custom Storage manager you're trying to build? The Storage ma...

artf

Thanks for the report @rahul-singh-bv The bug was actually already reported and fixed https://github.com/artf/grapesjs/issues/4480 but unfortunately the fix is not yet released 😞

GJSBlock

Thanks for reporting this, @rahul-singh-bv. Security and dependency issues are important. The GrapesJS team actively works on keeping dependencies up-to-date. For you right now: Run npm audit fix to see available patches Check for a newer...

artf

This happening due to these styles. Remove them and it will work properly.

artf

@FaisalShaikhHA are you able to provide a reproducible demo as I'm not able to reproduce it from the official demo?

FaisalShaikhHA

@artf here is the demo: https://codepen.io/faisal-praella/pen/rNvOwgR Select a component, double click, and ctrl+a to select the text and click backspace. Notice component disappears, and is not selectable or editable. Link component disap...

GJSBlock

Thanks for reporting this, @akhalid-dev. Great question about Layer Manager can have names removed and unable to select again. The recommended approach with GrapesJS is to use the event-driven API. Start here: Check the GrapesJS documentat...

artf

Hi @salemkode based on how custom components are handled by having that isComponent, which returns true with no conditions, generates the maximum call stack issue. It keeps creating new components as you have also the components property b...

GJSBlock

Thanks for reporting this, @salemkode. Great question about RangeError Maximum call stack size exceeded. The recommended approach with Canvas is to use the event-driven API. Start here: Check the GrapesJS documentation for your specific mo...

DevMetwaly

https://grapesjs.com/docs/modules/Components.html#components-cssComponent-first styling By default, when you select a component in the canvas and apply styles on it, changes will be applied on its existent classes. This will result on chan...

FaisalShaikhHA

Thanks, @DevMetwaly it worked, my bad I missed this.

FaisalShaikhHA

Hi @artf, first of all, amazing framework, and thanks for making it open source. As described in the above comment I am facing this weird issue, please let me know if I am doing something wrong or a way to fix this thanks.