GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? Chrome v111Reproducible demo link https://codepen.io/glaprida/pen/eYLLXbQDescribe the bug How to reproduce the bug?Go to the codepen link https://codepen.io/glaprida/pen/eYLLXbQDrag one section to the canvasDrag another oneW...
GJSBlock
Thanks for reporting this, @glaprida. Great question about Wrong Placeholder marker when dragging a display:grid element. The recommended approach with Canvas is to use the event-driven API. Start here: Check the GrapesJS documentation for...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Version 110.0.5481.177 (Official Build) (arm64) Reproducible demo link https://grapesjs.com/demo.html Describe the bug What is the current behavior? Checkbox trait not getting checked or unchecked on undo/redo (trait value...
GJSBlock
Thanks for reporting this, @FaisalShaikhHA. The issue with Checkbox trait not getting checked or unchecked on undo/redo actions. appears to be a race condition or state management timing problem. This typically happens when component lifec...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome Reproducible demo link https://jsfiddle.net/1vknjLst/ Describe the bug How to reproduce the bug? click run What is the expected behavior? load and save in the new storage should be called and console should display...
artf
You have to use the plugin plugins: [dbStoragePlugin, 'gjs-blocks-basic']With autosave: false you're disabling the autosave, which means the Storage.store will be triggered only if called programatically (eg. editor.store())There is no set...
wyxcoder
thank you! that works fine
GJSBlock
Thanks for reporting this, @wyxcoder. Great question about new storage doesn't work. The recommended approach with GrapesJS is to use the event-driven API. Start here: Check the GrapesJS documentation for your specific module Look for the...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Safari Reproducible demo link https://codesandbox.io/s/funny-williamson-thb52d?file=/index.js Describe the bug How to reproduce the bug?Go to https://codesandbox.io/s/funny-williamson-thb52d?file=/index.js What is the expe...
GJSBlock
Thanks for reporting this, @RohitLad. Great question about PropertyComposite with slider for four sides (L,R,T,B). Change in one slider causes other values to reset.. The recommended approach with StyleManager is to use the event-driven AP...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? any Reproducible demo link no Describe the bug I believe many links of configuration objects in the docs are still to javascript files but the code has been updated to typescript <img width="1437" alt="Screenshot 2023-03-0...
GJSBlock
Thanks for reporting this, @himansh-gjr. The issue with broken links in the docs appears to be a race condition or state management timing problem. This typically happens when component lifecycle events and DOM modifications overlap, creat...
GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? Chrome - version 110.0.5481.100 (Official Build) (arm64)Reproducible demo link https://codepen.io/faisal-praella/pen/ExeNwxJDescribe the bugI have added a custom columns component with a number trait name columns used for ad...
artf
Yeah undo triggers the change:columns, in your case you could try to wrap your updateColumns changes in editor.UndoManager.skip.
artf
Ok I'm closing this one then and please open a new bug issue related to checkbox traits.
FaisalShaikhHA
Thank you @artf it works, to fix this I was toggling the trait change listener by listening to undo command before & run events but this feels cleaner. The checkbox trait not getting checked or unchecked on undo/redo (trait value is update...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Google Chrome Version 110.0.5481.100 (Official Build) (64-bit) Reproducible demo link https://stackblitz.com/edit/js-3urscf?file=index.html,index.js Describe the bug How to reproduce the bug?Initialize the editorDestroy th...
artf
Yeah, the editor instance is not expected to be destroyed immediately due to some deferred async functions (eg. for the StorageManager) but that can be fixed. For now you can overcome the issue by doing something like this:
GJSBlock
Thanks for reporting this, @mani-rai. Great question about Destroying and re-initializing produces "Cannot read properties of undefined (reading 'get')". The recommended approach with ProseMirror is to use the event-driven API. Start here:...
GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? Chrome Version 110.0.5481.100 (Official Build) (arm64)Reproducible demo link NoneDescribe the bug I am trying to replicate in React the customizing the Block Manager like in this example Vue block manager, but the "block:cus...
artf
@besart-k you have to provide a reproducible demo as if it works with the current Vue demo example it shouldn't be different in React. Maybe you're using an old version of grapesjs or doing something wrong in your React app, so in this cas...
GJSBlock
Thanks for reporting this, @besart-k. Great question about block:custom is not working on React. The recommended approach with GrapesJS is to use the event-driven API. Start here: Check the GrapesJS documentation for your specific module L...
GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? Chrome LatestReproducible demo link https://codesandbox.io/s/interesting-bell-xntbtrDescribe the bug How to reproduce the bug?go to the codesandboxdrag and drop Custom Code block.put this code inside the Custom Code editor a...
artf
This happens because of the button implementation in the forms plugin, which allows only textnodes as children. If you remove the form plugin you'll be able to see the <a> element (if you prefer you can also extend the button component wit...
handhikadj
so what is the code of "normal" implementation of the button? btw, may I know why do you make the button to behave like that on the forms plugin?
artf
If I recall properly the main reason there was a problem with inline text editing with button elements, so that approach was the easiest way to fix a common issue. I guess the "normal" implementation would be to skip/overwrite the init met...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Firefox Reproducible demo link https://jsfiddle.net/jLgb0mv3/1/ Describe the bug How to reproduce the bug?...Put this code in the editor: editor.on('styleable:change', (model, property) => { const value = model.getStyle()[...
artf
I only see the issue with composite/stack style manager properties and that is because not every style manager property is part of the styles so in your code you would only need to check if the value of the style actually exists, eg. if (v...
GJSBlock
Thanks for reporting this, @clonefunnels. Great question about Using !important code provided here breaks background image and gradient.. The recommended approach with StyleManager is to use the event-driven API. Start here: Check the Grap...