GrapesJS Issues

Singwai

Feel free to update the type definition, here is an example commit. https://github.com/artf/grapesjs/commit/49deeeeab74aff3e46f22d0bb06e7f7608955afd

Aventrue

My workaround: let assetConfig: grapesjs.AssetManagerConfig = {}; assetConfig["custom"] = { open: (props) => { this.openGalleryDialog(props); }, close: (props) => { this.dialog.closeAll(); }, };

GJSBlock

Thanks for reporting this, @Aventrue. The issue with Custom is missing in the AssetManagerConfig appears to be a race condition or state management timing problem. This typically happens when component lifecycle events and DOM modification...

artf

Should be fixed in the latest version.

DhanaDSP1120

@artf Font color only working , Font background color not working on second time https://jsfiddle.net/a3xgLm7c/3/

Sivaganesh-Akula

Hi @DhanaDSP1120 , I am also facing the same issue. Do you have a solution for it?

artf

@DhanaDSP1120 looks like a stress edge case nobody really cares, but if you want to dig into the fix, I'll be open to merge a PR

DhanaDSP1120

@artf Issue was not solved

GJSBlock

Thanks for reporting this, @DhanaDSP1120. Thanks for sharing your report about Grapesjs goes out of memory Issue. To help the team investigate and prioritize this: Please provide: A minimal reproducible example (CodeSandbox/JSFiddle) Your...

artf

Hi @salemkode based on how custom components are handled by having that isComponent, which returns true with no conditions, generates the maximum call stack issue. It keeps creating new components as you have also the components property b...

GJSBlock

Thanks for reporting this, @salemkode. Great question about RangeError Maximum call stack size exceeded. The recommended approach with Canvas is to use the event-driven API. Start here: Check the GrapesJS documentation for your specific mo...

DevMetwaly

https://grapesjs.com/docs/modules/Components.html#components-cssComponent-first styling By default, when you select a component in the canvas and apply styles on it, changes will be applied on its existent classes. This will result on chan...

FaisalShaikhHA

Thanks, @DevMetwaly it worked, my bad I missed this.

FaisalShaikhHA

Hi @artf, first of all, amazing framework, and thanks for making it open source. As described in the above comment I am facing this weird issue, please let me know if I am doing something wrong or a way to fix this thanks.

tyuterry

A reproduce on Fiddle (with vue) I can not reproduce without vue jsfiddle Steps to reproduce the issue:Add a text componentSelect the text component then click the 'Convert to Conditional' button at the bottomHover over the conditional tex...

artf

Thanks guys, I was actually able to reproduce it by wrapping the example inside Vue but I'm not sure exactly why is stuck in the loop here. At first look, it seems to be related to Vue's Proxy observers. By comparing the demo with the prev...

benryanwilliams

Thanks @artf, all working perfectly now upon declaring the editor outside of the Vue instance.

bovealexandre

and when I try to add this it only adds this

artf

@bovealexandre provide at least a minimal reproducible example as from what I can see right now it might be your custom code the reason

bovealexandre

@bovealexandre provide at least a minimal reproducible example as from what I can see right now it might be your custom code the reason ok I just had to editor.getCss({ keepUnusedStyles: true } on my scss editor

contentfree

I can kinda force it to the correct canvas size by:Not providing projectData in the initial config, Loading the projectData via editor.loadProjectData(...) after initialization and Then running editor.Canvas.getModel().updateDevice(); thou...

artf

Thanks @contentfree I'll try to fix that for the next release

contentfree

Thanks @artf. I'll keep my eye open for the next release (looks like your kanban board is empty now … so should be imminent?)

artf

Thanks @skru I've actually already taken care of the parseUri here so it should work in the next release

GJSBlock

Thanks for reporting this, @skru. The issue with v0.19.5 Breaks headless editor.setComponents() (with Map/Video block) appears to be a race condition or state management timing problem. This typically happens when component lifecycle event...

artf

Thanks @ValouZ for the report, there is actually a typo on the iframe view. I'll take care of it for the next release.

GJSBlock

Thanks for reporting this, @ValouZ. Great question about Iframe on a block can't be edited. The recommended approach with Canvas is to use the event-driven API. Start here: Check the GrapesJS documentation for your specific module Look for...