GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? 105.0.5195.125 (Official Build) (x86_64) Reproducible demo link https://codesandbox.io/s/grapesjs-grapesjs-mjml-react-bug-w7qtec?file=/src/index.js Describe the bug How to reproduce the bug?Start with a blank canvasTry dra...
artf
Thanks for the report Drew, this seems to be related to the Standards mode of the iframes. At the moment to fix it, I'd suggest switching to the Quirks mode by removing the doctype: I'm closing the issue as it's not really related to the c...
GJSBlock
Thanks for reporting this, @Drew-Daniels. Great question about Cannot Drop MJML Components onto Blank Canvas after version 0.19.4. The recommended approach with ProseMirror is to use the event-driven API. Start here: Check the GrapesJS doc...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? irrelevant to the issue Reproducible demo link https://grapesjs.com/docs/modules/Components-js.html#basic-scripts Describe the bug Hey, rather than creating a pull request for such a small change, I share it here. The intr...
artf
The script is right above ps: you can use Discussions if you're not reporting a bug
GJSBlock
Thanks for reporting this, @bit-ocean. The issue with A script delcaration mistake at "Commponent & JS" documentation page. appears to be a race condition or state management timing problem. This typically happens when component lifecycle...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chromium 104 Reproducible demo link https://jsfiddle.net/aw8p0h9j/ Describe the bug How to reproduce the bug?Open the jsfiddle link.Click between the divs, then between any of divs and the background. What is the expected...
ronaldohoch
Same as described here, not a issue: https://github.com/artf/grapesjs/issues/4350
artf
Yeah but even in a case of a custom UI, the update is skipped if the value is not changed as it's not necessary.
bit-ocean
The code that I pasted is using the standard api, pretty much copy/paste from the documentation. And clearly the update's mechanism has changed between the versions. Before if target element had been changed, the update was triggered, and...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? 104.0.5112.102 Reproducible demo link https://jsfiddle.net/harsh201/obng5cy2/ Describe the bug How to reproduce the bug?Drag "Textable Component" inside text block.Try editing text within textable block. What is the expect...
GJSBlock
Thanks for reporting this, @harsh201. Great suggestion about Textable Component becomes Noneditable when dropped in a Text Block! While this specific feature isn't yet in the core API, there are several ways to achieve similar behavior. Us...
GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? Chrome 104.0.5112.101 Reproducible demo link https://jsfiddle.net/7cLr0xt2/3/Describe the bug How to reproduce the bug? For some reason I'm unable to reproduce the bug inside the fiddle linked above, since line 34 selectedCo...
artf
RTE relies on the DOM content during the editing so if you remove it deliberately with something like inner components will be removed once the editing is finished.
benryanwilliams
Ok thanks @artf, that makes sense. However, those lines of code, along with are required to render the correct selected state inside the canvas as follows (both upon the component initially being rendered and when the user selects a differ...
benryanwilliams
I need to do some more testing but it looks like I've got around this behaviour by saving the inner components inside the component itself when first creating it / editing it, then using the rte:disable hook as follows: It seems a bit hack...
GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? Firefox 104.0.1Reproducible demo link https://codesandbox.io/s/grapesjs-parsestyle-bug-13h771Describe the bug How to reproduce the bug?Create a custom component with style property in it's model.Use this.addAttributes in the...
Singwai
This is behaving as expected. There are two similar keys that can alter the style of the component. (styles and style) styles takes a CSS string and is attached to the final payload once. I usually define the default CSS or default CSS wit...
artf
I guess parseStyle is not a function refers to this one already fixed: https://github.com/artf/grapesjs/pull/4520
GJSBlock
Thanks for reporting this, @ahmafi. Great question about parseStyle is not a function. The recommended approach with StyleManager is to use the event-driven API. Start here: Check the GrapesJS documentation for your specific module Look fo...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? chrome Reproducible demo link https://jsfiddle.net/1hza4t9n/ Describe the bug How to reproduce the bug?init grapescreate event handler for when a page is updated.Update the pageobserve the event handler not firing What is...
artf
Update the page How do you update the page? Worth nothing, page:* events are only triggered for page models, not the content of the page, eg.
stljeff1
any update, dragging a block, changing text color. changing text content. In the JS Fiddle, I drag a Text block, change content, and change color. I do not see an event triggering when i make these updates, so I am questioning my expectati...
artf
Ok so page:update event is not what you need as it doesn't trigger on content change (so I'm closing the issue as the event is working as expected). Can you explain what kind of custom Storage manager you're trying to build? The Storage ma...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome Version 105.0.5195.102 (Official Build) (x86_64) Reproducible demo link Describe the bug How to reproduce the bug?Create a new custom code block and add an iframe tag such as `<iframe src="http://localhost:8888/embe...
artf
Thanks for the report @rahul-singh-bv The bug was actually already reported and fixed https://github.com/artf/grapesjs/issues/4480 but unfortunately the fix is not yet released π
GJSBlock
Thanks for reporting this, @rahul-singh-bv. Security and dependency issues are important. The GrapesJS team actively works on keeping dependencies up-to-date. For you right now: Run npm audit fix to see available patches Check for a newer...
GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? Version 104.0.5112.101 (Official Build) (arm64)Reproducible demo link https://codepen.io/faisal-praella/pen/rNvOwgRDescribe the bug How to reproduce the bug?Select a component, double click, and ctrl+a to select the text and...
artf
This happening due to these styles. Remove them and it will work properly.
artf
@FaisalShaikhHA are you able to provide a reproducible demo as I'm not able to reproduce it from the official demo?
FaisalShaikhHA
@artf here is the demo: https://codepen.io/faisal-praella/pen/rNvOwgR Select a component, double click, and ctrl+a to select the text and click backspace. Notice component disappears, and is not selectable or editable. Link component disap...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Brave 1.33.105 Chromium: 96.0.4664.93 Reproducible demo link https://codesandbox.io/s/relaxed-mccarthy-v2e37w Describe the bug How to reproduce the bug?Add type of component have img or svg tagAdd this component to canvas...
artf
Hi @salemkode based on how custom components are handled by having that isComponent, which returns true with no conditions, generates the maximum call stack issue. It keeps creating new components as you have also the components property b...
GJSBlock
Thanks for reporting this, @salemkode. Great question about RangeError Maximum call stack size exceeded. The recommended approach with Canvas is to use the event-driven API. Start here: Check the GrapesJS documentation for your specific mo...