An error when I use component:clone in a component
@hr1201 onRender could be triggered many times, you should never attach listeners there if you don't clean up the properly. Your logic is also purely model related so it shouldn't even be in the view, just move your code in the model.init method
Read full answer below βQuestion
GrapesJS version
- I confirm to use the latest version of GrapesJS
What browser are you using?
Microsoft Edge 130.0.2849.46
Reproducible demo link
https://jsfiddle.net/uwybfd98/
Describe the bug
How to reproduce the bug?
- select the carousel component
- click the space in the upper right or lower left corner of the image and select div;
- clone twice
What is the expected behavior? a clone is triggered only once
What is the current behavior? it recurses, and it causes a jam
If is necessary to execute some code in order to reproduce the bug, paste it here below:
onRender({ el, model }) {
model.getChildAt(0).forEachChild(child => {
child.on('component:clone', function (originalModel, cloneModel) {
console.log('clone')
if (model.getChildAt(0).get('components').length == 6) return;
model.trigger("change:script");
})
child.on('component:remove:before', function (model1, removeFn, options) {
console.log('remove')
if (model.getChildAt(0).get('components').length == 2) {
options.abort = true;
return;
}
model.trigger("change:script");
})
})
},
Code of Conduct
- I agree to follow this project's Code of Conduct
Answers (2)
@hr1201 onRender could be triggered many times, you should never attach listeners there if you don't clean up the properly.
Your logic is also purely model related so it shouldn't even be in the view, just move your code in the model.init method
Thanks for reporting this, @hr1201.
Great question about an error when I use component:clone in a component. The recommended approach with Components is to use the event-driven API.
Start here:
- Check the GrapesJS documentation for your specific module
- Look for the
on()event listener method - Most operations can be achieved by listening to editor and component events
Common patterns:
// Listen for changes
editor.on('change', () => console.log('something changed'));
// Component lifecycle
editor.on('component:mount', (c) => console.log('component ready', c));
editor.on('component:update', (c) => console.log('component updated', c));
If you're still stuck:
- Share a minimal CodeSandbox reproduction
- Include what you've already tried
- Mention your GrapesJS version
- The community is here to help!
Related Questions and Answers
Continue research with similar issue discussions.
Issue #4897
component:styleUpdate / component:styleUpdate:propertyName not fired
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Edge 109.0.1518.70 Reproducible demo link...
Issue #5633
Cannot select component in ``component:remove`` handler
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome Version 120.0.6099.225 Reproducible...
Issue #5487
Style Manager doesn't display multiple rules for the same class
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Firefox Reproducible demo link https://jsf...
Issue #4466
Change in traits does not update html
GrapesJS version [x] I confirm to use the latest version of GrapesJS What browser are you using? Chrome Reproducible demo link https://jsfi...
Paid Plugins That Match This Issue
Curated by issue keywords and label relevance to help you ship faster.
Loading paid plugin recommendations...
Check the open-source GrapesJS plugins on GitHub or run a quick search in our free catalog.
Browse free plugins βPremium plugins ship with support, regular updates, and production-ready features β save days of integration work.
Browse premium plugins βRelated tutorials
In-depth guides on the same topic.
Tutorial
How to Build a Production GrapesJS Editor: The Complete Walkthrough of Brief, Preset, Plugins, and Services
A complete walkthrough of building a production GrapesJS editor: how to choose a preset, pick plugins, and scope setup services without burning a sprint.
Tutorial
Big Updates: TinyMCE 8 and Placeholder 2.0 for GrapesJS
In May we shipped major updates to two of our most popular GrapesJS plugins β TinyMCE Inline Text Editor and Placeholder.
Tutorial
Find the Right GrapesJS Plugin in Seconds: Smarter Discovery Is Live
We're shipping a set of discovery upgrades. New label filters, a proper compatibility switch for GrapesJS vs Studio, one-click and a smarter sort bar.
Browse Plugin Categories
Jump directly to plugin category pages on the marketplace.