Issue #542Opened November 18, 2017by duskhacker1 reactions

Calling render() on PanelManager breaks style manager

Question

In lieu of #540, I'm trying to manually remove a button from the options panel, with this:

let pnm = editor.Panels;
pnm.getPanel('options').get('buttons').remove(pnm.getButton('options', 'gjs-open-import-template'));
pnm.render()

This works ok, the button goes away, but the pnm.render() seems to break the style manager, in that it becomes unresponsive. Non of the other stuff seems to break, just the styling. Is this a problem I'm introducing or a bug?

Thanks!

Answers (3)

duskhackerNovember 20, 20171 reactions

It occurs to me that I can just hide the button with some CSS, which is what I've done. I'm still curious about the render though.

sbarfurthFebruary 28, 20180 reactions

This should be high priority, makes modifying panels after the first render impossible.

artfNovember 9, 20180 reactions

I'm closing this as we've removed render method from the public Panel API, it should be executed only on init by the editor. In addition, now you can remove buttons easily by doing this panelManager.removeButton('panelId', 'buttonId')

Related Questions and Answers

Continue research with similar issue discussions.

Paid Plugins That Match This Issue

Curated by issue keywords and label relevance to help you ship faster.

View all plugins

Loading paid plugin recommendations...

Browse Plugin Categories

Jump directly to plugin category pages on the marketplace.