Issue #5236Opened July 11, 2023by joukhar0 reactions

BUG: textnode with content "null" is rendered as "null" not whitespace

Question

GrapesJS version

  • I confirm to use the latest version of GrapesJS

What browser are you using?

Chrome Version 114.0.5735.199 (Official Build) (64-bit)

Reproducible demo link

N/A

Describe the bug

I'm sorry for opening the issue again, but your commits doesn't work i installed dev version using npm install GrapesJS/grapesjs#dev

and the issue is still there.

can u check please the following:

/grapesjs/src/dom_components/view/ComponentTextNodeView.ts

  render() {
    const { model, el } = this;
    if (model.opt.temporary) return this;
    el.textContent = model.content;
    return this;
  }

grapesjs/src/dom_components/view/ComponentCommentView.ts

  _createElement() {
    return document.createComment(this.model.content) as Text;
  }

I will use editor.getHtml() to store and load components instead of components or pages object till u fix it edit: i forgot editor.getHtml() will break components type and turn them into default, components object is important

and thanks for your hard work have a good day

Code of Conduct

  • I agree to follow this project's Code of Conduct

Answers (1)

artfJuly 17, 20230 reactions

@joukhar npm install GrapesJS/grapesjs#dev is not enough, I didn't create the build in the dev branch yet, so if you want the fix locally you have to build it yourself first. Anyway, there is no need to create new issue even if the related one is closed, you can still add your updates there, the issue is not locked.

Related Questions and Answers

Continue research with similar issue discussions.

Paid Plugins That Match This Issue

Curated by issue keywords and label relevance to help you ship faster.

View all plugins

Loading paid plugin recommendations...

Browse Plugin Categories

Jump directly to plugin category pages on the marketplace.