Issue #5175Opened June 10, 2023by krishnaeverestengineering0 reactions

BUG: Move method is not working as expected

Question

GrapesJS version

  • I confirm to use the latest version of GrapesJS

What browser are you using?

Chrome

Reproducible demo link

https://codesandbox.io/s/adoring-margulis-873kdv

Describe the bug

Context

Move component method doesn't work as expected.

if (component) {
      const { at } = opts;
      const index = this.index();
      const sameParent = component === this.parent();
      const sameIndex = index === at || index === at! - 1;

      if (!sameParent || !sameIndex) {
        if (sameParent && at && at > index) {
          opts.at = at - 1;
        }
        this.remove({ temporary: 1 });
        component.append(this, opts);
        this.emitUpdate();
      }
    }
    return this;

This piece of code doesn't work as expected.


if (component) {
      const { at } = opts;
      const index = this.index();
      const sameParent = component === this.parent();
      const sameIndex = index === at;

      if (!sameParent || !sameIndex) {
        this.remove({ temporary: 1 });
        component.append(this, opts);
        this.emitUpdate();
      }
    }
    return this;

this piece of code should work. When sameParent is false and target index is 1, then it won't move to 0 to 1 position for example

Code of Conduct

  • I agree to follow this project's Code of Conduct

Answers (3)

artfJune 15, 20230 reactions

Thanks @krishnaeverestengineering but this is actually the expected behaviour for moving the component inside the same parent. This is because the at should account also for the index of the component itself.

- index: 0
{ Component 1 }
- index: 1
{ Component 2 }
- index: 2

So, if you try to move "Component 1" at index 0 or 1, nothing will happen. If you need to move it below "Component 2" you have to indicate index 2

krishnaeverestengineeringJune 15, 20230 reactions

Thanks @krishnaeverestengineering but this is actually the expected behaviour for moving the component inside the same parent. This is because the at should account also for the index of the component itself.

- index: 0
{ Component 1 }
- index: 1
{ Component 2 }
- index: 2

So, if you try to move "Component 1" at index 0 or 1, nothing will happen. If you need to move it below "Component 2" you have to indicate index 2

But I don't understand the use case there. Usually at should account for index in the last versions. How to move a component from 0 to index 1 then?

Related Questions and Answers

Continue research with similar issue discussions.

Paid Plugins That Match This Issue

Curated by issue keywords and label relevance to help you ship faster.

View all plugins

Loading paid plugin recommendations...

Browse Plugin Categories

Jump directly to plugin category pages on the marketplace.