Issue #5135Opened May 22, 2023by duclet0 reactions

BUG: Incorrect type definition for StyleManager.addProperty

Question

GrapesJS version

  • I confirm to use the latest version of GrapesJS

What browser are you using?

All

Reproducible demo link

None

Describe the bug

How to reproduce the bug?

  1. Per the definition here: https://github.com/GrapesJS/grapesjs/blob/dev/src/style_manager/index.ts#L304, you should be providing the options as options for PropertyProps.
  2. However, PropertyProps as defined here: https://github.com/GrapesJS/grapesjs/blob/dev/src/style_manager/model/Property.ts#L9, does not have such a property. This is causing the TS compiler to complain.

What is the expected behavior? Definition should exists.

What is the current behavior? Definition is missing.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Answers (1)

SachinPuthiyoth• January 12, 20240 reactions

Seems like the type definition in StyleManagerConfig.sectors is unchanged : https://github.com/GrapesJS/grapesjs/blob/5c890449a52f526bc480d6dc649ff5e01ec59140/src/style_manager/config/config.ts#L8 Shouldn't we be updating this to use PropertyTypes as in : https://github.com/GrapesJS/grapesjs/blob/5c890449a52f526bc480d6dc649ff5e01ec59140/src/style_manager/index.ts#L86 Opened an issue here - https://github.com/GrapesJS/grapesjs/issues/5613 Shall I raise a PR for the same?

Related Questions and Answers

Continue research with similar issue discussions.

Issue #5613

BUG: Incorrect type definition for StyleManagerConfig.sectors.properties

GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome Reproducible demo link None Describ...

0 answersUpdated January 18, 2024

Issue #5144

BUG: Incorrect type definition for PanelManager.addPanel

GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? All Reproducible demo link None Describe t...

2 answersUpdated June 13, 2023

Issue #4735

BUG: resetId types mismatch

GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? n/a Reproducible demo link n/a Describe th...

2 answersUpdated November 18, 2022

Issue #5263

BUG: Deleting a component without deleting its corresponding style, will adding new components later cause style conflicts?

GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? latest version of Chrome Reproducible demo...

3 answersUpdated August 3, 2023

Paid Plugins That Match This Issue

Curated by issue keywords and label relevance to help you ship faster.

View all plugins

Loading paid plugin recommendations...

Browse Plugin Categories

Jump directly to plugin category pages on the marketplace.

PresetsPluginsComponentsBlocksAssetsCommandsI18nLayersStylesStoragesRTENewslettersWeb pagesSite builders