Issue #4922Opened February 11, 2023by clonefunnels0 reactions

BUG: Using !important code provided here breaks background image and gradient.

Question

GrapesJS version

  • I confirm to use the latest version of GrapesJS

What browser are you using?

Firefox

Reproducible demo link

https://jsfiddle.net/jLgb0mv3/1/

Describe the bug

How to reproduce the bug?

  1. ...Put this code in the editor:

editor.on('styleable:change', (model, property) => { const value = model.getStyle()[property]; if (value.indexOf('!important') === -1) { model.addStyle({ [property]: value + ' !important' }); } });

  1. Try to set a background image or gradient.

What is the expected behavior? It should let you set a background image or gradient.

What is the current behavior? It doesn't.

If is necessary to execute some code in order to reproduce the bug, paste it here below:

// your code here

const editor = grapesjs.init({ container: '#gjs', fromElement: 1, height: '100%', storageManager: { type: 0 }, plugins: ['gjs-blocks-basic'] }); editor.on('styleable:change', (model, property) => { const value = model.getStyle()[property]; if (value.indexOf('!important') === -1) { model.addStyle({ [property]: value + ' !important' }); } });

Code of Conduct

  • I agree to follow this project's Code of Conduct

Answers (1)

artfFebruary 22, 20230 reactions

I only see the issue with composite/stack style manager properties and that is because not every style manager property is part of the styles so in your code you would only need to check if the value of the style actually exists, eg. if (value && value.indexOf('!important') === -1) {...

Related Questions and Answers

Continue research with similar issue discussions.

Paid Plugins That Match This Issue

Curated by issue keywords and label relevance to help you ship faster.

View all plugins

Loading paid plugin recommendations...

Browse Plugin Categories

Jump directly to plugin category pages on the marketplace.