BUG: Using !important code provided here breaks background image and gradient.
Question
GrapesJS version
- I confirm to use the latest version of GrapesJS
What browser are you using?
Firefox
Reproducible demo link
https://jsfiddle.net/jLgb0mv3/1/
Describe the bug
How to reproduce the bug?
- ...Put this code in the editor:
editor.on('styleable:change', (model, property) => { const value = model.getStyle()[property]; if (value.indexOf('!important') === -1) { model.addStyle({ [property]: value + ' !important' }); } });
- Try to set a background image or gradient.
What is the expected behavior? It should let you set a background image or gradient.
What is the current behavior? It doesn't.
If is necessary to execute some code in order to reproduce the bug, paste it here below:
// your code here
const editor = grapesjs.init({ container: '#gjs', fromElement: 1, height: '100%', storageManager: { type: 0 }, plugins: ['gjs-blocks-basic'] }); editor.on('styleable:change', (model, property) => { const value = model.getStyle()[property]; if (value.indexOf('!important') === -1) { model.addStyle({ [property]: value + ' !important' }); } });
Code of Conduct
- I agree to follow this project's Code of Conduct
Answers (1)
I only see the issue with composite/stack style manager properties and that is because not every style manager property is part of the styles so in your code you would only need to check if the value of the style actually exists, eg. if (value && value.indexOf('!important') === -1) {...
Related Questions and Answers
Continue research with similar issue discussions.
Issue #4191
BUG: We are trying to store the data from grapesJS editor in Angular 10 application, getting CORS error, image attached below
GrapesJS version [x] I confirm to use the latest version of GrapesJS What browser are you using? Chrome 99.0.4844.5 Reproducible demo link...
Issue #4897
BUG: component:styleUpdate / component:styleUpdate:propertyName not fired
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Edge 109.0.1518.70 Reproducible demo link...
Issue #4861
BUG: <br/> is adding to single line text, after entering space for the first time in firefox
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Firefox Reproducible demo link https://jsf...
Issue #4350
BUG: Style Manager don't update background when component is selected
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Brave Browser V1.39.111 Reproducible demo...
Paid Plugins That Match This Issue
Curated by issue keywords and label relevance to help you ship faster.
Loading paid plugin recommendations...
Browse Plugin Categories
Jump directly to plugin category pages on the marketplace.