BUG: CanvasView.getPosition returns strange values in designer mode with a narrow device
Question
GrapesJS version
- I confirm to use the latest version of GrapesJS
What browser are you using?
Version 102.0.5005.61
Reproducible demo link
https://jsfiddle.net/tLvwfhu3/
Describe the bug
Starting at the demo fiddle, drop a text block into the narrow canvas. An alert pops up with the result of CanvasView.getPosition() containing the strange values. It seems that either the left value or the width value are wrong as left is the left edge of the visible canvas but width contains all the blank margin on either side of the canvas.
I believe this is causing some of the issues with initial component positioning in designer mode as editor.Canvas.getMouseRelativeCanvas adds the left value (and top value) to the clientX/Y values. Maybe it should subtract them instead?
Code of Conduct
- I agree to follow this project's Code of Conduct
Answers (1)
Yeah I'd say it's definitely confusing (width and height refer to the canvas, top and left to the frame) but any direct change to those functions breaks some functionality in other points as those were built around this confusing logic 😞 (eg. the sorter of blocks in the standard mode). So I guess before doing any kind of change here we should probably refactor the logic in other points. I'll probably close this issue as the method itself is not really public/documented.
Related Questions and Answers
Continue research with similar issue discussions.
Issue #4449
BUG: Lists not working with default RTE
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome Version 102.0.5005.115 (Official Bu...
Issue #4440
BUG: Extending text component breaks textable blocks
GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? Version 102.0.5005.115 (Official Build) (64-...
Issue #4015
BUG: Drag and drop not working well in case of RTL
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome v96 Reproducible demo link https://...
Issue #6324
BUG: sorter.setDragHelper is not a function on block drag
GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? 131.0.6778.86Reproducible demo link https://...
Paid Plugins That Match This Issue
Curated by issue keywords and label relevance to help you ship faster.
Loading paid plugin recommendations...
Browse Plugin Categories
Jump directly to plugin category pages on the marketplace.