BUG: Duplicated video block when re-attaching GrapesJs editor to document
Question
GrapesJS version
- I confirm to use the latest version of GrapesJS
What browser are you using?
Chrome v94
Reproducible demo link
https://jsfiddle.net/3mrzaqtx/
Describe the bug
How to reproduce the bug?
- Add a video block to the canvas
- Remove the GrapesJs editor element from the document (Optional)
- Re-attach the GrapesJs editor element to the document
What is the expected behavior? GrapesJs canvas should be the same before and after the operation
What is the current behavior? The video is displayed multiple times
My investigation According to the ComponentVideoView, this is caused by the render() function. Unlike the updateProvider() function, render doesn't take care of clearing the container before appending the new iframe/video tag in the block.
We are integrating GrapesJs into another application, and we don't create a new GrapesJs editor when switching back and forth between views, thus the detach/attach behavior. I also don't know what events GrapesJs listens to trigger a re-render on attach.
Code of Conduct
- I agree to follow this project's Code of Conduct
Answers (2)
I've created a pull-request with what I would expect a fix to look like, given my understanding of the issue.
No, you should never rely on something like this, or you destroy and reinit, or you simply hide and show the editor.
Related Questions and Answers
Continue research with similar issue discussions.
Issue #4015
BUG: Drag and drop not working well in case of RTL
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome v96 Reproducible demo link https://...
Issue #4323
BUG: Performance issue while dragging component to canvas when you have 2k component on canvas
GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? Google Chrome Version 101.0.4951.41 (Officia...
Issue #6515
BUG: Resizing an element affects all elements with the same class
GrapesJS version [x] I confirm to use the latest version of GrapesJS What browser are you using? Chrome 136.0.7103.93 Reproducible demo lin...
Issue #6318
BUG: Unable to use transparent fill in Block media svg
GrapesJS version[X] I confirm to use the latest version of [email protected] when this issue was filedWhat browser are you using? Fir...
Paid Plugins That Match This Issue
Curated by issue keywords and label relevance to help you ship faster.
Loading paid plugin recommendations...
Browse Plugin Categories
Jump directly to plugin category pages on the marketplace.