Issue #3873Opened October 19, 2021by JGiard0 reactions

BUG: Duplicated video block when re-attaching GrapesJs editor to document

Question

GrapesJS version

  • I confirm to use the latest version of GrapesJS

What browser are you using?

Chrome v94

Reproducible demo link

https://jsfiddle.net/3mrzaqtx/

Describe the bug

How to reproduce the bug?

  1. Add a video block to the canvas
  2. Remove the GrapesJs editor element from the document (Optional)
  3. Re-attach the GrapesJs editor element to the document

What is the expected behavior? GrapesJs canvas should be the same before and after the operation

What is the current behavior? The video is displayed multiple times

My investigation According to the ComponentVideoView, this is caused by the render() function. Unlike the updateProvider() function, render doesn't take care of clearing the container before appending the new iframe/video tag in the block.

We are integrating GrapesJs into another application, and we don't create a new GrapesJs editor when switching back and forth between views, thus the detach/attach behavior. I also don't know what events GrapesJs listens to trigger a re-render on attach.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Answers (2)

JGiardOctober 19, 20210 reactions

I've created a pull-request with what I would expect a fix to look like, given my understanding of the issue.

artfOctober 20, 20210 reactions

No, you should never rely on something like this, or you destroy and reinit, or you simply hide and show the editor.

Related Questions and Answers

Continue research with similar issue discussions.

Paid Plugins That Match This Issue

Curated by issue keywords and label relevance to help you ship faster.

View all plugins

Loading paid plugin recommendations...

Browse Plugin Categories

Jump directly to plugin category pages on the marketplace.