BUG: update breaks some things with css
Question
WARNING
READ and FOLLOW next 3 steps, then REMOVE them before posting the issue
- Follow CONTRIBUTING Guidelines https://github.com/artf/grapesjs/blob/master/CONTRIBUTING.md
- Do a quick SEARCH first, to see if someone else didn't open the same issue
- All relative statements/questions have to be filled/answered, otherwise, the issue might be CLOSED
- JSFiddle Starter template https://jsfiddle.net/szLp8h4n
- CodeSandbox Starter template https://codesandbox.io/s/1r0w2pk1vl
Version: Most recent cloned right off github
You can get the version by typing grapesjs.version into the console
Are you able to reproduce the bug from the demo?
- Yes
- [x ] No, this is a custom version
What is the expected behavior? When calling for the selected component and updating it via editor.getSelected().components().reset('html string here') if there is <style></style> tag in the html string it used to be parsed and placed in the page in the gjs-css section in the iframe document.
Describe the bug detailed
What is the current behavior? That is no longer the case. The <style> tags get parsed but never added to the page like the previous version (before the page API update)
Describe the bug detailed
Are you able to attach screenshots, screencasts or a live demo?
- [x ] Yes (attach)
- No
Am on mobile atm but will update with screenshots and possibly more info when I get my laptop
Answers (2)
Well, actually the proper API would be .components('html string here') which seems to work as expected, but I'll investigate the reset thing because I'd expect to work the same way
Ok seems like the backbone's reset method injects the silent option which prevents the CSS collection to render the added style, so for now, I'd prefer to avoid putting hacky conditions to remove that option and would recommend sticking with the proper API
Related Questions and Answers
Continue research with similar issue discussions.
Issue #3463
BUG: inspector overflow broken
WARNING READ and FOLLOW next 3 steps, then REMOVE them before posting the issueFollow CONTRIBUTING Guidelines https://github.com/artf/grape...
Issue #3703
BUG: custom ids have a \3 injected into the css and a space after the following letter after the \3 when added to the canvas
WARNING READ and FOLLOW next 3 steps, then REMOVE them before posting the issueFollow CONTRIBUTING Guidelines https://github.com/artf/grape...
Issue #3668
BUG: Cant Reset Canvas after Moving/scaling it
WARNING READ and FOLLOW next 3 steps, then REMOVE them before posting the issueFollow CONTRIBUTING Guidelines https://github.com/artf/grape...
Issue #3700
BUG: setting draggable: 'wrapper' does not drop in wrapper
WARNING READ and FOLLOW next 3 steps, then REMOVE them before posting the issueFollow CONTRIBUTING Guidelines https://github.com/artf/grape...
Paid Plugins That Match This Issue
Curated by issue keywords and label relevance to help you ship faster.
Loading paid plugin recommendations...
Browse Plugin Categories
Jump directly to plugin category pages on the marketplace.