BUG: Panels "visible" attribute doesn't prevent panel rendering
Question
Version:
v0.17.3
Are you able to reproduce the bug from the demo?
- Yes
- No
What is the expected behavior?
editor.Panels.addPanel({id: 'test', visible: false}) renders panel despite of visible attribute set to false.
It perfectly works after editor has been rendered, so panel.set('visibility', !panel.get('visibility') toggles visibility correctly.
Workaround 1 to set gjs-hidden class with visible: false together didn't work too. This way visibility would be checked later and gjs-hidden class would be removed. At least is this the behavior I see.
There was same issue already: #1602.
Workaround 2 to call toggleVisibility function just after panel has been created didn't work too. I think it's because render() function in the PanelView overrides classes. Even to set class manually like it's done in the toggleVisible function didn't work.
What is the current behavior?
Visible attribute is set correctly to false in the panel when I get it using editor.Panels.getPanel('test') but panel itself is still visible until panel.set('visible', false) call after editor has been rendered.
Are you able to attach screenshots, screencasts or a live demo?
- Yes (attach)
- No
Answers (1)
Yeah, I think it's just a matter of adding this.toggleVisible() in PanelView.render. If you want to push a PR, I'd be glad to merge it :)
Related Questions and Answers
Continue research with similar issue discussions.
Issue #3547
BUG: Dragging multiple blocks reverses the order
Version: 0.17.4 Are you able to reproduce the bug from the demo? YES What is the expected behavior? When dragging the blocks, the order sho...
Issue #3291
BUG (v0.16.41): the duplicate icon from the icon toolbar is modifying the original element too
Version: v0.16.41 Are you able to reproduce the bug from the demo? [ ] Yes What is the expected behavior? The elements duplicated not shoul...
Issue #3134
BUG: Canvas scroll to top of the page when I try to drag an element from the last sections
Version: 0.16.27 Are you able to reproduce the bug from the demo? [ X] Yes [ ] No What is the expected behavior? When a try to drag a compo...
Issue #3009
BUG: Restricting Drop on Wrapper Component
Version: 0.16.22 Are you able to reproduce the bug from the demo? [ ] Yes [ X] No - requires editing js. What is the expected behavior? wra...
Paid Plugins That Match This Issue
Curated by issue keywords and label relevance to help you ship faster.
Loading paid plugin recommendations...
Browse Plugin Categories
Jump directly to plugin category pages on the marketplace.