BUG: TextNodes interfere when changing content on element

Hi Juan, thanks for the report, are you able to show me how your text trait works? I'd expect it to work correctly if you update your component in this way component.components(e.target.value)

This was my trait

tm.addType('content', {
   events: {
     'change': 'onValueChange'
   },
   getInputEl: function() {
     this.inputEl = document.createElement('input');
     this.inputEl.value = this.getModelValue();
     return this.inputEl;
   },
   getModelValue: function() {
     const { model, target } = this;
     var value = target.get('content') || target.getEl().textContent;
     return value;
   },
   onValueChange: function() {
     const { model, target } = this;
     var value = this.inputEl.value;
     target.set('content', value);
     target.getEl().textContent = value;
   },
   onUpdate: function() {
     var value = this.getModelValue();
     this.target.getEl().textContent = value;
   }
 });

I have changed it to

tm.addType('content', {
   events: {
     'change': 'onValueChange'
   },
   getInputEl: function() {
     this.inputEl = document.createElement('input');
     this.inputEl.value = this.getModelValue();
     return this.inputEl;
   },
   getModelValue: function() {
     const { model, target } = this;
     var value = target.get('content') || target.getEl().textContent;
     return value;
   },
   onValueChange: function() {
     const { model, target } = this;
     var value = this.inputEl.value;
     target.set('content', value);
     target.components(value);
   },
   onUpdate: function() {
     var value = this.getModelValue();
     this.target.getEl().textContent = value;
   }
 });

And now it works without overriding update content or render children, thanks! I would have never arrived to the conclusion of using the components method. Now i don't like text nodes 😅

I think we can close this issue unless there's some other point you want to add to improve.

Thanks!

I don't think you need this one target.set('content', value);. For the rest all good 👍