GrapesJS Issues

artf

@RaresVlaiduc mmm I'd expect it to work also with an HTML string... I have to check it

ahmedderkaoui

Then, in createInput() you should return an Element. So instead of returning a simple string, do this:

ahmedderkaoui

If you want to have a simple checkbox with label, no need to create custom trait, you can just use directly:

artf

Hi @harsh201 styles are available across all pages, so you shouldn't use editor.setStyle (which replaces all styles with a new set) but instead something like editor.getStyle().add('...')

harsh201

Hi @artf, any help here?

GJSBlock

Thanks for reporting this, @harsh201. The issue with Style gets wiped out when inserting components in multiple page using Page Manager appears to be a race condition or state management timing problem. This typically happens when componen...

artf

Yeah, this is how it works right now (content is parsed and transformed in components only once the editing is finished). Probably we can use an approach like this as the default behaviour for links.

artf

Updated the link creation from this release https://github.com/artf/grapesjs/releases/tag/v0.18.3

GJSBlock

Thanks for reporting this, @TheDude70. The issue with RTE insert link does not update DOM appears to be a race condition or state management timing problem. This typically happens when component lifecycle events and DOM modifications overl...

alemenciones

this work:

GJSBlock

Thanks for reporting this, @alemenciones. Great question about FEAT: how to resize start/end in absolute mode?. The recommended approach with StyleManager is to use the event-driven API. Start here: Check the GrapesJS documentation for you...

Ju99ernaut

It's not recommended to use allowScripts: 1, anyways in your case why not just drag in the typed block, but if you have to include it in your from element use:

Ju99ernaut

You should setup your storage correctly https://grapesjs.com/docs/modules/Storage.html#basic-configuration

lbmir

@artf Can you help please?

mahfuzdiu

I hid it with custom css editor.Panels.getButton('options', 'fullscreen').attributes.className = 'hidepanelbtn' btw a proper solution would be nice.

artf

Hi @mahfuzdiu by doing so on the official demo, it works with no errors, are you able to create a reproducible demo?

no-response[bot]

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take ac...

emyasnikov

I'm also wondering if backbone-undo is needed or can be replaced by something similar. The package hasn't been updated for 6 years

artf

The package hasn't been updated for 6 years Well, except updating its dependencies (like in this case, for security reason) it's a feature-complete library, there is no need to add/update anything else. Anyway, this PR seems to fix the sec...

chilled-capybara

Thanks for your replyAnyway, this PR seems to fix the security vulnerability at the .lock level but I'm not sure if are kept on a fresh install. I think that might fix the version in the main grapejs repo, but I'm not sure it restricts the...

emilsedgh

Hi Artur. Thank you for the great job done on grapesjs. It really is fantastic. The interim solution works just fine. Feel free to close out if necessary, but providing a way of manipulating the behavior would definitely be pretty nice.

artf

Hi @emilsedgh I apologize for being so late on this issue, but anyway, we can think about how to skip escape in cases like that but probably the fastest way is to simply extend mj-style toHTML method

artf

Thanks Emil, for now, I'll close this one, in case another similar issue will arise, we'll think about adding a new prop for skipping the escape.

artf

Thanks @RaresVlaiduc I'll prevent tracking device changes in undo manager

GJSBlock

Thanks for reporting this, @RaresVlaiduc. Great question about UNDO/REDO ISSUE. The recommended approach with UndoManager is to use the event-driven API. Start here: Check the GrapesJS documentation for your specific module Look for the on...

GJSBlock

Thanks for reporting this, @anlumo. The issue with Scrollable onStart/onEnd/updateTarget not Overridable appears to be a race condition or state management timing problem. This typically happens when component lifecycle events and DOM modi...