GrapesJS Issues

artf

Yeah, actually the name, by default, is managed via i18n configuration. From 0.17.* version even the wrapper option is not necessary anymore as now you should extend the wrapper component as all others (in previous versions the wrapper was...

artf

@RaresVlaiduc mmm I'd expect it to work also with an HTML string... I have to check it

ahmedderkaoui

Then, in createInput() you should return an Element. So instead of returning a simple string, do this:

ahmedderkaoui

If you want to have a simple checkbox with label, no need to create custom trait, you can just use directly:

artf

Hi @harsh201 styles are available across all pages, so you shouldn't use editor.setStyle (which replaces all styles with a new set) but instead something like editor.getStyle().add('...')

harsh201

Hi @artf, any help here?

artf

Yeah, this is how it works right now (content is parsed and transformed in components only once the editing is finished). Probably we can use an approach like this as the default behaviour for links.

artf

Updated the link creation from this release https://github.com/artf/grapesjs/releases/tag/v0.18.3

chiragkataria22

@artf Can you please help?

artf

Unfortunately, switching pages creates a new iframe so, the behavior is correct. I preferred to remove previous iframes in order to keep the memory usage as low as possible. One solution might be to find a way to reuse previous iframes but...

Ju99ernaut

It's not recommended to use allowScripts: 1, anyways in your case why not just drag in the typed block, but if you have to include it in your from element use:

Ju99ernaut

You should setup your storage correctly https://grapesjs.com/docs/modules/Storage.html#basic-configuration

lbmir

@artf Can you help please?

emyasnikov

I'm also wondering if backbone-undo is needed or can be replaced by something similar. The package hasn't been updated for 6 years

artf

The package hasn't been updated for 6 years Well, except updating its dependencies (like in this case, for security reason) it's a feature-complete library, there is no need to add/update anything else. Anyway, this PR seems to fix the sec...

chilled-capybara

Thanks for your replyAnyway, this PR seems to fix the security vulnerability at the .lock level but I'm not sure if are kept on a fresh install. I think that might fix the version in the main grapejs repo, but I'm not sure it restricts the...

artf

Thanks for the report, I'll try to fix it in the next release @ershadul1 nope, there is a FrameWrapView (stuff around the iframe, like wrappers, tools for selection etc.), and inside there is a FrameView (the iframe itself), but probably f...

ershadul1

https://github.com/artf/grapesjs/blob/0027dcd1194715eeaf4b24db878dd7ebac069cc4/src/canvas/view/FrameWrapView.js#L73 I'm seeing that the remove is used inside the remove itself. I don't understand. Was this a mistake? If I set this.frame =...

PRTTMPRPHT

+1

emilsedgh

Hi Artur. Thank you for the great job done on grapesjs. It really is fantastic. The interim solution works just fine. Feel free to close out if necessary, but providing a way of manipulating the behavior would definitely be pretty nice.

artf

Hi @emilsedgh I apologize for being so late on this issue, but anyway, we can think about how to skip escape in cases like that but probably the fastest way is to simply extend mj-style toHTML method

artf

Thanks Emil, for now, I'll close this one, in case another similar issue will arise, we'll think about adding a new prop for skipping the escape.

artf

Thanks @RaresVlaiduc I'll prevent tracking device changes in undo manager