GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Version 104.0.5112.101 (Official Build) (arm64) Reproducible demo link Screenshot: https://d.pr/i/AyHJyL Describe the bug How to reproduce the bug?Upgrade to the latest grapesjs version. What is the expected behavior? Icon...
artf
Thanks @FaisalShaikhHA ok I'll fix that as that rule is quite common.
artf
Is it what you see also here https://grapesjs.com/demo.html? I see those icons properly π€
FaisalShaikhHA
No, on the demo page icons are visible properly. To update grapesjs I removed the old version by using npm remove grapesjs and then npm install grapesjs to get the latest version. I also tried deleting grapesjs folder from node_modules and...
GrapesJS version[x] I confirm to use the latest version of GrapesJSWhat browser are you using? Chrome v104Reproducible demo link https://grapesjs.com/demo.htmlDescribe the bug How to reproduce the bug?Select an elementHold down the CTRL key and select a child elementTry moving these elements What is the expected behav...
artf
I guess we should avoid selecting children of already selected components in the first place.
GJSBlock
Thanks for reporting this, @RomanGlazkov. Great suggestion about JS error when moving an element with its child! While this specific feature isn't yet in the core API, there are several ways to achieve similar behavior. Using the event sys...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? irrelevant to the issue Reproducible demo link https://grapesjs.com/docs/modules/Components-js.html#basic-scripts Describe the bug Hey, rather than creating a pull request for such a small change, I share it here. The intr...
artf
The script is right above ps: you can use Discussions if you're not reporting a bug
GJSBlock
Thanks for reporting this, @bit-ocean. The issue with A script delcaration mistake at "Commponent & JS" documentation page. appears to be a race condition or state management timing problem. This typically happens when component lifecycle...
GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? Firefox 105.0 (64-bit)Reproducible demo link https://grapesjs.com/demo.htmlDescribe the bug How to reproduce the bug?Opening up the demo Page (https://grapesjs.com/demo.html) in Firefox. What is the expected behaviour? That...
artf
Yeah thanks @Akira-Kuru fixed the issue here https://github.com/artf/grapesjs-preset-webpage/releases/tag/v1.0.2
GJSBlock
Thanks for reporting this, @Akira-Kuru. Great question about Webpage Demo displaying incorrectly on Firefox. The recommended approach with GrapesJS is to use the event-driven API. Start here: Check the GrapesJS documentation for your speci...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chromium 104 Reproducible demo link https://jsfiddle.net/aw8p0h9j/ Describe the bug How to reproduce the bug?Open the jsfiddle link.Click between the divs, then between any of divs and the background. What is the expected...
ronaldohoch
Same as described here, not a issue: https://github.com/artf/grapesjs/issues/4350
artf
Yeah but even in a case of a custom UI, the update is skipped if the value is not changed as it's not necessary.
bit-ocean
The code that I pasted is using the standard api, pretty much copy/paste from the documentation. And clearly the update's mechanism has changed between the versions. Before if target element had been changed, the update was triggered, and...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? chrome Reproducible demo link none Describe the bug image.js : Code of Conduct [X] I agree to follow this project's Code of Conduct
collins-lagat
The release says that there a breaking change. Try that and see if the problem goes away. I got the same error but haven't tried the fix yet. https://github.com/artf/grapesjs/releases/tag/v0.20.1
artf
Yes, as mentioned in the release note you have to switch from the old legacy API for custom component registration.
GJSBlock
Thanks for reporting this, @Aventrue. The issue with After Update to 0.20 from 0.19 the error Cannot assign to read only property 'defaults' of object '[object Object]' occurs appears to be a race condition or state management timing probl...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? 104.0.5112.102 Reproducible demo link https://jsfiddle.net/harsh201/obng5cy2/ Describe the bug How to reproduce the bug?Drag "Textable Component" inside text block.Try editing text within textable block. What is the expect...
GJSBlock
Thanks for reporting this, @harsh201. Great suggestion about Textable Component becomes Noneditable when dropped in a Text Block! While this specific feature isn't yet in the core API, there are several ways to achieve similar behavior. Us...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Safari Reproducible demo link https://grapesjs.com/docs/api/editor.html#editor Describe the bug How to reproduce the bug?Visit https://grapesjs.com/docs/api/editor.html#editorClick "Configuration Object" on line 2 and 33....
artf
Thanks @wunksert the link is already updated and will be fixed on the next release
GJSBlock
Thanks for reporting this, @wunksert. Great question about API Docs Configuration Object link broken. The recommended approach with GrapesJS is to use the event-driven API. Start here: Check the GrapesJS documentation for your specific mod...
GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? anyReproducible demo link anyDescribe the bug Start Pos should also use the MosePosFetcher method if the override is provided right?Start Pos https://github.com/artf/grapesjs/blob/dev/src/utils/Resizer.js#L278-L281Current Po...
artf
Yeah, you're right, I'll fix it, thanks for the report.
GJSBlock
Thanks for reporting this, @Singwai. The issue with Resizer cursor's starting position should also use the mousePosFetcher if provided. appears to be a race condition or state management timing problem. This typically happens when componen...
GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? AnyReproducible demo link See screenshot for codeDescribe the bug Is there anything preventing us from adding the resizer and el in the onEnd callback? Since we are reusing the resizer instance (unless forceNew). I would lik...
artf
Sure, I'll add it, thanks for the suggestion.
GJSBlock
Thanks for reporting this, @Singwai. The issue with Resizer onEnd callback should include the resizer and el object similar to onStart appears to be a race condition or state management timing problem. This typically happens when component...