GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? 103.0.5060.66 (Official Build) (64-bit) (cohort: Stable) Reproducible demo link https://codesandbox.io/s/cranky-morning-fh5diz?file=/index.js Describe the bug How to reproduce the bug?Drop the custom block "picture" into t...
artf
I'm not sure exactly what is happening but I'd suggest switching to styleable:change event and pass its options to setStyle, eg.
GJSBlock
Thanks for reporting this, @booellean. Great question about Undo Manager creates Duplicate CSS during custom command. The recommended approach with StyleManager is to use the event-driven API. Start here: Check the GrapesJS documentation f...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome / Firefox Reproducible demo link https://www.teamfunnels.net/login.php demo demo Describe the bug When I use this code to make all style important.... editor.on('styleable:change', (model, property) => { const value...
GJSBlock
Thanks for reporting this, @clonefunnels. The issue with * appears to be a race condition or state management timing problem. This typically happens when component lifecycle events and DOM modifications overlap, creating an inconsistent st...
Hello @artf ! I made this bug issue as suggested in my question on How to add the Selector Manager events/actions to the Undo Manager stack. I think what we want to have is for the Undo Manager to be able to keep track of the events/actions that are happening in the Selector Manager. Thanks!
GJSBlock
Thanks for reporting this, @mortimerz. Great question about Updates on the Selector Manager not being tracked by Undo Manager. The recommended approach with UndoManager is to use the event-driven API. Start here: Check the GrapesJS documen...
One thing i think would add great functionality is a more detailed history stack. U can get the undo stack and build a sort of history report from it of all the edits one has made but it is a little unclear as to what each edit was (at least to me so if I am missing something please let me know). Maybe like a formulai...
artf
Hi @anatoli-dp the ability to view the undo history would be actually super cool and I was already thinking about how to extend the UndoManager module in order to allow this kind of functionality via a plugin (eg. you can render the UI wit...
anatoli-dp
yeah im aware of how to access the stack i just dont know how to intepret it to give a more meaningful description to the end user
artf
i just dont know how to intepret it to give a more meaningful description to the end user Each UndoAction (each instance of the stack) tells you the action type (eg. add, remove, reset, change) and details about the updated model (eg. Comp...
I am trying to disable the undo button when there are no undo actions to do. To do so, I am listening to 'change:changesCount' event, and using editor?.attributes?.UndoManager?.hasUndo() to set the undo button disabled state. editor.on('change:changesCount', editor => setHasUndo(editor?.attributes?.UndoManager?.hasUnd...
artf
So there is an extra action added to the queue while it shouldn't, which is when I am dragging a block over the canvas. Not really, are you able to create a reproducible demo, as I'm not able to reproduce it?
no-response[bot]
This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take ac...
GJSBlock
Thanks for reporting this, @alimajed93. Great question about The UndoManager hasUndo() method returns true when it shouldnt. The recommended approach with Canvas is to use the event-driven API. Start here: Check the GrapesJS documentation...
@artf , it's pretty important if u ask me :) Version: v0.17.3 Are you able to reproduce the bug from the demo?[x] Yes[ ] No What is the expected behavior? If I change the device and then I press undo and redo I will get to the last device type. (e.g: Mobile -> Tablet, Undo, Redo) Describe the bug How to reproduce:Ente...
artf
Thanks @RaresVlaiduc I'll prevent tracking device changes in undo manager
GJSBlock
Thanks for reporting this, @RaresVlaiduc. Great question about UNDO/REDO ISSUE. The recommended approach with UndoManager is to use the event-driven API. Start here: Check the GrapesJS documentation for your specific module Look for the on...
how to add undo/redo event to UndoManager from custom rich text editor ckeditor?
Ju99ernaut
UndoManger usually tracks changes to component models, so if you can record the changes from the rte in the component in some way it could work. I'm not completely sure how this would work so I can't give a more in depth description. Anywa...
artf
Yeah, as already mentioned by @Ju99ernaut all major RTE editors implement their own undo manager. Indeed, when the RTE is enabled (built-in or a custom one) all shortcuts are disabled, in order not to mess with text editing (when you edit...
GJSBlock
Thanks for reporting this, @alext2793. Great question about UndoManager add. The recommended approach with ProseMirror is to use the event-driven API. Start here: Check the GrapesJS documentation for your specific module Look for the on()...
Version: v0.16.41 Are you able to reproduce the bug from the demo? [ ] No What is the expected behavior? The changesCount parameter should be reset to zero when we undo the images Describe the bug detailed Steps:add an imagedelete the imageundo the changes We should see the changesCount parameter should be reset to ze...
GayathriGuru
Hi! @marcepoblet can you please share the part of the code which you used to define the changesCount variable to get it incremented?
artf
Closing this as I don't see any substantial benefit for this functionality
GJSBlock
Thanks for reporting this, @marcepoblet. The issue with The changesCount parameter should be reset to zero when we undo the images appears to be a race condition or state management timing problem. This typically happens when component lif...
https://user-images.githubusercontent.com/64096863/104953457-35adf180-59a5-11eb-85bd-2f84ffa24d83.mp4 The styles of the text and button blocks are lost after deleting them from the template, and undo the changes and redo them several times. The issue is that the styles applied from the blocks, are lost after apply the...
artf
It should be fixed in the latest release, please follow the issue template properly and ensure to use the latest version before submitting a bug
GJSBlock
Thanks for reporting this, @marcepoblet. Thanks for sharing your report about UndoManager: combination between undo and redo is not working properly, lost some styles. To help the team investigate and prioritize this: Please provide: A min...
The collection of the selected component before Undo The collection of the selected component after Undo Code to replace the component with new component Uncaught TypeError: n.getEl is not a function and Uncaught TypeError: t.getSelectors is not function are the errors reported on save. Iβm unable to replace the selec...
artf
Sorry, but without a reproducible demo, this issue doesn't make sense to me
ssmanoj-grapes
Hi artf, Please find the demo video of the issue grapejs-issue.zip.
artf
Ok, as you're not able to create a reproducible demo, I have to close this...