Issue #3577💬 AnsweredOpened Jun 29, 2021by alimajed930 reactions

The UndoManager hasUndo() method returns true when it shouldnt

Quick answerby artf

So there is an extra action added to the queue while it shouldn't, which is when I am dragging a block over the canvas. Not really, are you able to create a reproducible demo, as I'm not able to reproduce it?

Read full answer below ↓

Question

I am trying to disable the undo button when there are no undo actions to do. To do so, I am listening to 'change:changesCount' event, and using editor?.attributes?.UndoManager?.hasUndo() to set the undo button disabled state. editor.on('change:changesCount', editor => setHasUndo(editor?.attributes?.UndoManager?.hasUndo())); It is doing the job for me except in the below scenario:I am creating a new template on a blank canvasI drag and drop a blockI undo The problem here is that even though the undo now should be disabled, it is not, because editor?.attributes?.UndoManager?.hasUndo() is return...

Answers (3)

artf• Jul 21, 2021

So there is an extra action added to the queue while it shouldn't, which is when I am dragging a block over the canvas.

Not really, are you able to create a reproducible demo, as I'm not able to reproduce it?

no-response[bot]• Jul 31, 2021

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we ne...

GJSBlock• May 17, 2026

Thanks for reporting this, @alimajed93. Great question about The UndoManager hasUndo() method returns true when it shouldnt. The recommended approach with Canvas is to use the event-driven API. Start here: Check the GrapesJS documentation for your specific module Look for the on() event listener me...

View full discussion on GitHub →