GrapesJS Issues

Search parsed GitHub issues, see highlighted answers, and open the original discussion when needed.

3464 issues found

#2011May 12, 2019by Amir28283 answers
0 reactions

Building gjs-components

Hello all, Im using grapesjs-webpage-preset plugin and I would like to combine my gjs-html with my gjs-css so that all of the styles are inlined. I managed to do that while using 'juice', now I would like to store the gjs-components based on my new combined gjs-html with inline css. Any suggestions ?

prosenjit-manna

Do you want to use it for a newsletter? See the repository https://github.com/artf/grapesjs-preset-newsletter

Amir2828

Actually I wanted to do it so I can use the preset-webpage with inline styles, But I already Managed to make it. It could be helpful if i could use 'juice' and a function that converts html to components. Unless no one know about a already...

lock[bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

#2010May 11, 2019by simplecommerce1 answer
1 reactions

[BUG] Droppable query selector [data-gjs-type="my-component-type"] no longer working

Hi, since the latest version, I noticed that when I use the droppable query selector using [data-gjs-type="my-component-type"] no longer seems to work. I have added two codesandbox demos to show you the issue. I am not able to figure out what changed. Hope it helps, thanks!You're submitting a BUGAre you using the late...

artf

Ok seems like the regression was introduced by this change: https://github.com/artf/grapesjs/commit/702ba828b13bae4b64bfd7bc79f23d8909d757f4#diff-6aa74cf54855daa6ca63a5d1e8b77c44R358 I'll fix it in the next release. Thanks for the report

#2009May 11, 2019by ahmedeldeeb25-zz3 answers
0 reactions

'Select' trait no updated in edit mode

Hi there, There is a problem with me, I don't know if it from my code or from grapejs itself, For LINK tool, it takes its links from my DB that contains for ex: link1,link2, then I put LINK tool in my page and save it in BD. I added link3 to DB then when I go to edit my previous created Page that contains LINK tool, I...

artf

I think you're in the same case of #2007

ahmedeldeeb25-zz

I did the same but it removed my custom trait 'Page' in edit mode like in these 2 pics. @artf

lock[bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

#2008May 11, 2019by amoslover3 answers
0 reactions

[Question]The canvas turns dark and unmodifiable on adding a large piece of custom html.

I used to add custom html with editor.addComponent(). It works well at most of the time, but when I try to insert a large piece of HTML which may contain a bunch of children elements the canvas turns black and cannot be modified. I can only reload the whole editor to make it works again.

artf

the canvas turns black weird thing. Are you able to create a reproducible demo? Upload here the template if you need

no-response[bot]

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take ac...

lock[bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

#2007May 10, 2019by kaoz703 answers
1 reactions

[QUESTION] Adding new traits to component and update current ones with these

I have some custom components created before modifying their traits (for example, I created a new trait for it), these components wont contain the new trait. If I drag a new component into the editor, it will have it. Steps to reproduce: 1) Create a custom component and compile the code 2) Drag this custom component i...

kaoz70

@Lakshit-Singhal In that case I think the best option would be to create a custom plugin, and before you initialize GrapesJS, call the API, get the values and pass them in the initialization function via the plugin's options, that way they...

artf

This happens because the editor stores also traits information in components. You can delete this information be extending the component and updating its toJSON method ps: I think I'll remove traits from JSON in the next release. Perhaps m...

ahmedeldeeb25-zz

@artf this removed custom traits !! as I mentioned in #2007

#2006May 9, 2019by pcg923 answers
0 reactions

Change colors of words

Could be nice change in the same text, the colors of differents words, like the bold, or italic, maybe adding a new field color.

artf

You can add new actions via Rich Text Editor API

lock[bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock[bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

#2005May 8, 2019by benvmatheson2 answers
0 reactions

Invalid class names allowed

When adding a class name, the editor allows you to create class names that are invalid in CSS, but valid in HTML (e.g. 123). As adding class names with this tool is primarily meant for styling, it may make sense to add a warning when the class name is invalid for CSS.

artf

You can add this kind of warning (and even apply your logic to fix the invalid name) by yourself by using selector:add event

benvmatheson

That's perfect. Thank you!

#2004May 8, 2019by Ericson19913 answers
0 reactions

[QUESTIONS] Add Component(from BlockManager) into Modal

i want to make a button that displays modal, then i can add some component / block into the modal.

artf

At first, you should create a Component for the Modal, probably with a trait to trigger the visibility, and then create a button to trigger that visibility

lock[bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock[bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

#2003May 8, 2019by Jogai3 answers
0 reactions

[Question] How to select a specific element nested inside a template

My test case: https://codepen.io/jogai/pen/QRjKyN?editors=1111 I want to select the middle column so I thought I can use selectorManager.get() but its not selecting what I'm expecting. I supply the class name (because id doesn't work anyway) and the element with that class name has 4 images. but if I look in the colle...

artf

SelectorManager is meant for managing Selector entities (eg adding, updating and removing classes) not for selecting components. In your case, you should do this:

Jogai

Thanks for clearing up my misunderstanding!

lock[bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

#2002May 8, 2019by benvmatheson3 answers
1 reactions

Images won't resize to full width

When an image is resized with the mouse, it won't stretch all the way to the edge of the canvas, leaving a white space on the right side. If adjusting Dimensions --> Width, you can bring it all the way to the edge of the canvas. If you drag enough elements onto the canvas for the scrollbar to appear, the scrollbar fil...

artf

Seems like I totally forget about this issue 😂 thanks to @benvmatheson for the ping. I apologize also to @giorgiosjames for totally ignoring his PR 😬 even because I have to close it as he is right, we can do it correctly and dynamically...

artf

Not sure but it might also be an issue in the resizer configuration https://github.com/artf/grapesjs/blob/3f053af969ef6a688d526d158b9df7e6aa076838/src/commands/view/SelectComponent.js#L353

giorgiosjames

This seems to be caused by the padding value here: https://github.com/artf/grapesjs/blob/3f053af969ef6a688d526d158b9df7e6aa076838/src/commands/view/SelectComponent.js#L449 Setting this value to 0 allows me to resize components right to the...