#1104May 12, 2018by atcq-me3 answers
After v0.14.9 color trait can't setup component property when user press "OK" on colorpicker form. Live:v0.14.9 https://jsfiddle.net/Lqm7ouze/ (testprop is undefined)v0.14.6 https://jsfiddle.net/Lqm7ouze/1/ (testprop contain hex colorcode) Screenshots:https://ctrlv.cz/en/M7lghttps://ctrlv.cz/en/ltPo This problem is al...
artf
Thanks for the report and details @Nuzsk This should be fixed for the next release
artf
@jdodsoncollins it's fixed in the dev branch but was not yet released
jdodsoncollins
@artf I'm seeing this behavior still if you could take a look, on latest release. Reverting to v 0.14.6 solves it.
#1092May 7, 2018by xr0master3 answers
Hey, maybe it's not bug, i'm not sure. I have traits with changeProp: true field. When I change the value of trait by UI, model is changed and all works fine, but the new changes aren't saved in Storage. So, after refresh the editor, I miss the values. If I append any component, when Storage is triggered and all have...
artf
Should be fixed by this https://github.com/artf/grapesjs/commit/32c1b2c1f4e1bef967f43b0013bfd481cddb81c7
xr0master
Nope. It doesn't fix it.
xr0master
Probably the #1104 close to fix it
#1084May 4, 2018by dsgh2 answers
I've marked as a bug just because I think this reflects a minor inconsistency; but it could also be understood as a feature request. The scenario is:I'm providing my own methods for uploadFile and handleAdd, which is something that's possible today.I can see that uploadFile has been bound to its parent object, allowin...
artf
Totally agree about the consistency 👍
lock[bot]
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
#1081May 3, 2018by mmeeeooowww3 answers
I'm trying to remove a panel. The function returns the panel the first time I run removePanel and then returns undefined if I run it again. It's worth noting that the panel is no longer returned when getting all panels, however it is still visible and functional. In my case I'm trying to remove the device selection bu...
FrciSmrci
Hey @mmeeeooowww , the panels should be removed as discussed in this issue. Have a great day.
mmeeeooowww
Hi, @FrciSmrci I am using css to hide stuff at the moment. Am I misunderstanding the purpose of removePanel or am I using it incorrectly? Thanks!
artf
I'll add a listener on this too
#1072April 25, 2018by andsnake2 answers
HI, i'm using the latest build and i have the issue as described in the title. I am editing html and css separately. I have noticed that when editing the css, if i try to add a new class, not used by any of the elements in the canvas yet, after saving, that css class is removed, if instead i go and create a dummy div,...
artf
Yes, it's a normal behavior, the editor optimizes the exported code, but in the next release you'll find a new keepUnusedStyles option, which allows you to skip this optimization
lock[bot]
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
#1067April 25, 2018by phucphanJaneto3 answers
Hi @artf I initialized grapesjs without allow script. I imported html string from the attachment (template.zip) and Grapesjs can show it correctly But when I allow script by allowScripts: 1 in init code and imported the above html string. Grapesjs doesn't show any and I can't use any grapesjs. template.zip
artf
Can you provide a live demo on jsfiddle?
no-response[bot]
This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take ac...
phucphanJaneto
Hi, @artf Sorry for late reply. Here you are: https://jsfiddle.net/oq58jk1p/6/ Currently, I comment the line "allowScript: 1" in the jsfiddle. When you test please open this again. Thanks.
#1058April 21, 2018by tommedema3 answers
Tested on latest dev branch commit 39be1e0. This problem occurred on one of my templates, so it's a real world issue. It took me about half a day to create this minified test case, so I hope it helps. If you have a template with the following CSS: A browser renders this correctly as such: <img width="609" alt="screen...
artf
when the browser itself already has a DOM tree and all styling information etc can be retrieved on-demand once a component is selected Probably this is something I've tried to build before grapesjs, and to be honest, after few weeks of wor...
tommedema
@artf it's surprising to me that this is slower because I thought the browser would be heavily optimized for this, but you definitely have more experience with this project so I'll trust in your judgement ;) I'm definitely in favor of an o...
artf
I'd really appreciate a PR. I think the check would be ok inside the add method
#1055April 19, 2018by anuradhaindika833 answers
Hi, I'm using the latest version (grapesjs - 0.14.9). I have loaded an external HTML code to the editor. Then I tried to edit text within a DIV. But it is not allowing me. Try importing the below code to the Newsletter demo. You'll see that you can't edit the text. If you remove the image tag and import it again, then...
tommedema
This is due to https://github.com/artf/grapesjs/issues/1013
artf
@indikaanu83 subscribe to #1013 if you want to be notified when the issue is solved
anuradhaindika83
Oky Will do. thanks Artur.
#1051April 16, 2018by maxtacco3 answers
Hi @artf, after the latest upgrade (0.14.9) some of my commands that rely on the results of other commands fail. This happens because of the changes in https://github.com/artf/grapesjs/commit/98896c0e833500f35f377a14bead0ea966437d6d It looks like Editor's runCommand and stopCommand expect a result but CommandAbstract'...
maxtacco
Created a pull request: https://github.com/artf/grapesjs/pull/1052
artf
Ops, my oversight 🙇 Hope to release soon with this fix
lock[bot]
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
#1049April 16, 2018by dsgh1 answer
I'm configuring grapesjs in a way to allow users to edit the html and css source (by calling setComponents and setStyle respectively). There is an issue regarding the storeManager where the html is stored correctly, but the css is not. Here is a fiddle showing this: https://jsfiddle.net/szLp8h4n/189/Steps to reproduce...
lock[bot]
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.