Issue #1051šŸ’¬ AnsweredOpened April 16, 2018by maxtacco0 reactions

CommandAbstract's callRun and callStop should return result for backward compatibility

Quick answerby maxtacco

Created a pull request: https://github.com/artf/grapesjs/pull/1052

Read full answer below ↓

Question

Hi @artf, after the latest upgrade (0.14.9) some of my commands that rely on the results of other commands fail. This happens because of the changes in https://github.com/artf/grapesjs/commit/98896c0e833500f35f377a14bead0ea966437d6d It looks like Editor's runCommand and stopCommand expect a result but CommandAbstract's callRun and callStop functions do not return it.

Answers (3)

artf• April 19, 2018

Ops, my oversight šŸ™‡ Hope to release soon with this fix

lock[bot]• September 17, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Related Questions and Answers

Continue research with similar issue discussions.

Paid Plugins That Match This Issue

Curated by issue keywords and label relevance to help you ship faster.

View all plugins

Loading paid plugin recommendations...

Free option

Check the open-source GrapesJS plugins on GitHub or run a quick search in our free catalog.

Browse free plugins →
Premium option

Premium plugins ship with support, regular updates, and production-ready features — save days of integration work.

Browse premium plugins →

Related tutorials

In-depth guides on the same topic.

All tutorials →

Browse Plugin Categories

Jump directly to plugin category pages on the marketplace.