[BUG] CommandAbstract's callRun and callStop should return result for backward compatibility
Question
Hi @artf, after the latest upgrade (0.14.9) some of my commands that rely on the results of other commands fail. This happens because of the changes in https://github.com/artf/grapesjs/commit/98896c0e833500f35f377a14bead0ea966437d6d It looks like Editor's runCommand and stopCommand expect a result but CommandAbstract's callRun and callStop functions do not return it.
Answers (3)
Created a pull request: https://github.com/artf/grapesjs/pull/1052
Ops, my oversight 🙇 Hope to release soon with this fix
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Related Questions and Answers
Continue research with similar issue discussions.
Issue #1501
[Bug] Issue with editor.destroy() and reinitialization
With GrapesJS 0.14.33 editor.destroy() was introduced (https://github.com/artf/grapesjs/commit/52f8bdf2e894de536d44c1699c1e18bbaf52488f), s...
Issue #980
[BUG] Related with task https://github.com/artf/grapesjs/issues/873
Hello, After restoring editor from db still have some part of bug present. It seems inside of script: function () traits will have old valu...
Issue #767
Generate a new grapes.min.js after make changes to grapes.js
Hi guys - happy new year, I'm currently doing some investigation of GrapesJs for our further project. The question is I fellow the https://...
Issue #774
Mimic customRTE behavior when parsing content
Hi @artf, I'd like to replicate this behavior when calling editor.setComponents("<div>This is a text component. <span style='font-size: 20p...
Paid Plugins That Match This Issue
Curated by issue keywords and label relevance to help you ship faster.
Loading paid plugin recommendations...
Browse Plugin Categories
Jump directly to plugin category pages on the marketplace.