CSS parser invalidly parses certain duplicate declarations

Question

Tested on latest dev branch commit 39be1e0. This problem occurred on one of my templates, so it's a real world issue. It took me about half a day to create this minified test case, so I hope it helps. If you have a template with the following CSS: A browser renders this correctly as such: <img width="609" alt="screen shot 2018-04-20 at 3 14 01 pm" src="https://user-images.githubusercontent.com/331833/39075971-8307bb60-44ad-11e8-89ed-355801ac3c33.png"> JSFiddle: https://jsfiddle.net/szLp8h4n/192...

artf · Accepted Answer

when the browser itself already has a DOM tree and all styling information etc can be retrieved on-demand once a component is selected Probably this is something I've tried to build before grapesjs, and to be honest, after few weeks of work I realized that the result was just a big, unmaintainable, unreliable, SLOW, piece of crap. Believe me Tom, keeping the state of such a big application inside the DOM, it's just not an option. And again, I'm using the browser's parser but the problem is just...

tommedema · Answer

@artf it's surprising to me that this is slower because I thought the browser would be heavily optimized for this, but you definitely have more experience with this project so I'll trust in your judgement ;) I'm definitely in favor of an option to just add all rules unconditionally. This makes sense to me because for me the browser is truth and there should be no need to do additional checking on top of what the browser tells you. Would you like to do this or should I create a PR? If the latter...

artf · Answer

I'd really appreciate a PR. I think the check would be ok inside the add method

CSS parser invalidly parses certain duplicate declarations

Question

Answers (3)

Related Questions and Answers

The documented way to parse @keyframes does not work

Old Component script is not deleted on Import. Resulting in duplicate scripts

Media query rules are overridden by class rules in canvas

CSS Parser's shape doesn't allow the CSS property to be defined more than once.

Paid Plugins That Match This Issue

Browse Plugin Categories