Issue #4579Opened September 13, 2022by Singwai0 reactions

BUG: Resizer onEnd callback should include the resizer and el object similar to onStart

Question

GrapesJS version

  • I confirm to use the latest version of GrapesJS

What browser are you using?

Any

Reproducible demo link

See screenshot for code

Describe the bug

Is there anything preventing us from adding the resizer and el in the onEnd callback? Since we are reusing the resizer instance (unless forceNew). I would like to have to clean up the resizer state at the end of resizing

onStart

https://github.com/artf/grapesjs/blob/dev/src/utils/Resizer.js#L295 image

onEnd

https://github.com/artf/grapesjs/blob/dev/src/utils/Resizer.js#L343 image

Happy to create a PR for this. Just want to verify this is an acceptable behavior beforehand

Code of Conduct

  • I agree to follow this project's Code of Conduct

Answers (1)

artfSeptember 13, 20220 reactions

Sure, I'll add it, thanks for the suggestion.

Related Questions and Answers

Continue research with similar issue discussions.

Paid Plugins That Match This Issue

Curated by issue keywords and label relevance to help you ship faster.

View all plugins

Loading paid plugin recommendations...

Browse Plugin Categories

Jump directly to plugin category pages on the marketplace.