BUG: The UndoManager hasUndo() method returns true when it shouldnt
Question
I am trying to disable the undo button when there are no undo actions to do.
To do so, I am listening to 'change:changesCount' event, and using editor?.attributes?.UndoManager?.hasUndo() to set the undo button disabled state.
editor.on('change:changesCount', editor => setHasUndo(editor?.attributes?.UndoManager?.hasUndo()));
It is doing the job for me except in the below scenario:
- I am creating a new template on a blank canvas
- I drag and drop a block
- I undo
The problem here is that even though the undo now should be disabled, it is not, because editor?.attributes?.UndoManager?.hasUndo() is returning true, same as editor?.UndoManager?.hasUndo(). After doing one extra useless undo, editor?.UndoManager?.hasUndo() starts returning false.
I think the problem is that when I hover a block over the canvas, even before dropping it, we have an action added to the queue, and therefore changesCount is equal to 1 already. After dropping the block changesCount is increased to 2, while it should be 1.
So there is an extra action added to the queue while it shouldn't, which is when I am dragging a block over the canvas.
To note that this doesn't happen with the second block or all the blocks after. It only happens with the first block dragged and dropped.
As a summary, when dragging and dropping the first block into the canvas, there are now 2 undo actions in the UndoManager queue, and not only 1 as expected.
Answers (2)
So there is an extra action added to the queue while it shouldn't, which is when I am dragging a block over the canvas.
Not really, are you able to create a reproducible demo, as I'm not able to reproduce it?
This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.
Related Questions and Answers
Continue research with similar issue discussions.
Issue #2114
Disable event.preventDefeault() for anchor onClick event
I want to open a modal on clicking to anchor in the provided html in grapesjs Editor. I have bind onClick event on anchor but on clicking t...
Issue #3193
FEAT: Change of current internal object store to allow for relation mappings instead of current indexable container implementation
What are you trying to add to GrapesJS? Currently newly instantiated editor instances are added to a indexable collection where the user mu...
Issue #3594
BUG: Hover on component when parent of editor scrolls, show wrong positioning
Version: 0.17.19 Are you able to reproduce the bug from the demo? No, because its full screen and there is no parent container scroll. What...
Issue #4919
BUG: calling destroy method breaks the editor ( React app )
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome 109.0.5414.119 Reproducible demo li...
Paid Plugins That Match This Issue
Curated by issue keywords and label relevance to help you ship faster.
Loading paid plugin recommendations...
Browse Plugin Categories
Jump directly to plugin category pages on the marketplace.