Issue #3577Opened June 29, 2021by alimajed930 reactions

BUG: The UndoManager hasUndo() method returns true when it shouldnt

Question

I am trying to disable the undo button when there are no undo actions to do.

To do so, I am listening to 'change:changesCount' event, and using editor?.attributes?.UndoManager?.hasUndo() to set the undo button disabled state.

editor.on('change:changesCount', editor => setHasUndo(editor?.attributes?.UndoManager?.hasUndo()));

It is doing the job for me except in the below scenario:

  • I am creating a new template on a blank canvas
  • I drag and drop a block
  • I undo

The problem here is that even though the undo now should be disabled, it is not, because editor?.attributes?.UndoManager?.hasUndo() is returning true, same as editor?.UndoManager?.hasUndo(). After doing one extra useless undo, editor?.UndoManager?.hasUndo() starts returning false.

I think the problem is that when I hover a block over the canvas, even before dropping it, we have an action added to the queue, and therefore changesCount is equal to 1 already. After dropping the block changesCount is increased to 2, while it should be 1. So there is an extra action added to the queue while it shouldn't, which is when I am dragging a block over the canvas.

To note that this doesn't happen with the second block or all the blocks after. It only happens with the first block dragged and dropped.

As a summary, when dragging and dropping the first block into the canvas, there are now 2 undo actions in the UndoManager queue, and not only 1 as expected.

Answers (2)

artfJuly 21, 20210 reactions

So there is an extra action added to the queue while it shouldn't, which is when I am dragging a block over the canvas.

Not really, are you able to create a reproducible demo, as I'm not able to reproduce it?

no-response[bot]July 31, 20210 reactions

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

Related Questions and Answers

Continue research with similar issue discussions.

Paid Plugins That Match This Issue

Curated by issue keywords and label relevance to help you ship faster.

View all plugins

Loading paid plugin recommendations...

Browse Plugin Categories

Jump directly to plugin category pages on the marketplace.