[Style manager] Unit don't change on Composite Type
Question
Hi,
I have an error on your demo :(
1- In the style, on the "Build your templates without coding" text, set TOP to 5px 2- In the same element, set Dimension > Margin > Top to 10px 3- In the "Hover me" button, set TOP to 1% and Margin > Top to 2% 4- Select "Build your templates ..."
The TOP value change top 5px -> OK The Margin > Top value change to 10% -> :(
Globaly, the unit change with the interger is out of a composite.
Answers (2)
For fix this issue, you must change PropertyView.targetUpdated() and change this line
let targetValue = this.getTargetValue({ ignoreDefault: 1 });
by this one
let targetValue = this.getTargetValue({ ignoreDefault: 1, ignoreCustomValue: 1 });
Other fix, in PropertySelectView, you need to add setValue. When the value is !important, the input.val is set to 'value !important' and the select is empty
/**
* Update the element input.
* Usually the value is a result of `model.getFullValue()`
* @param {String} value The value from the model
* */
setValue: function setValue(value) {
var model = this.model;
var val = (0, _underscore.isUndefined)(value) ? model.getDefaultValue() : value;
var input = this.getInputEl();
if (typeof val === 'string')
val = val.replace(' !important', '').trim();
input && (input.value = val);
},
Thanks @WebEtSolutions I'm not totally sure about the solution but the bug is confirmed
Related Questions and Answers
Continue research with similar issue discussions.
Issue #4310
BUG: Style Manager is inaccurate when using combined CSS selectors which contains "bout" and componentFirst = true
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome 100 Reproducible demo link https://...
Issue #532
Error when trying to hide some elements from the Layers Manager
Steps:Go to http://grapesjs.com/demo.htmlOpen Layer Manager.Click on the "Build your templates without coding" text element.Click on the "e...
Issue #4116
BUG: Flex Property not working in style manager
GrapesJS version [x] I confirm to use the latest version of GrapesJS What browser are you using? Version 1.34.81 Chromium: 97.0.4692.99 (Of...
Issue #4208
BUG: Style click state bug in every element
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Brave Last, tested on chrome last and Safa...
Paid Plugins That Match This Issue
Curated by issue keywords and label relevance to help you ship faster.
Loading paid plugin recommendations...
Browse Plugin Categories
Jump directly to plugin category pages on the marketplace.