GrapesJS Issues

Search parsed GitHub issues, see highlighted answers, and open the original discussion when needed.

1180 issues found

#2868July 1, 2020by BerkeAras2 answers
9 reactions

[Bug]: Cannot disable asset-manager

GrapesJS Version: 0.16.18 Client: Windows 10 1909; Brave Chromium (latest) Expected behavior: It should be possible to disable the asset-manager Current behavior: Asset manager is not disabled using this code: Full code: https://pastebin.berkearas.de/?44ff08e13bab068d#5AuNABBrvbkcYp8zh5r59jkmtqJQcsuTj5jSfykMVGxd Live...

artf

@mcottret is right but if you'd like also to disable the opening of the Asset Manager modal you can overwrite its command in this way:

mcottret

Hi @BerkeAras ! I don't think there's currently a way to completely disable the Asset Manager, you should however be able to disable adding images. Setting the upload option to false only disables uploading of images, but not base64 embedd...

#2863June 30, 2020by mcottret2 answers
2 reactions

[Bug]: Programmatic retrieval of layers' visibility always returns `true`

Hello again :) Our team might have found a bug while using the Layer Manager API: every call to component.viewLayer.isVisible() seems to always return true, regardless of their actual state. Steps to reproduce:Open the demoSwitch to the layers panelClick on the eye icon to hide the "Body" layerOpen the consoleExecutin...

artf

Yeah, you're totally right, the PR is welcome :)

mcottret

Great ! #2879 opened.

#2849June 21, 2020by meyerco3 answers
1 reactions

[BUG] Using image url for background-image is not working properly

DescriptionOn our project for images assets we use url instead of base64 code .Expected behavior When setting a background-image to a control , it has to update the css of this control .The css have to be reflected on the canvas and the style panel .What happens instead ? If the image have spaces or parentheses on its...

meyerco

Hi @artf , #2975 Here is a PR to fix the issue . Please update me if its good enough . Thanks

artf

Thanks for the report, I'd appreciate a PR for this issue

meyerco

Can you direct me to a file , where background-image is set ?

#2844June 20, 2020by akashdesale981 answer
0 reactions

[BUG] If we give "<input data-gjs-type="myInput" type="text" required/>" this html string to setComponents, it sets it like "<input data-gjs-type="myInput" type="text" required=""/>" in code manager

editor.setComponents("html stiring"), method which takes html string as an input and sets that code in the html section in the Code Manager if we pass ,<input data-gjs-type="myInput" type="text" required/>" to editor.setComponents, then its output will be "<input data-gjs-type="myInput" type="text" required=""/> If yo...

artf

For now, you can avoid it only by adding the Component Definition in this way but I'll update the HTML parser in the next release to handle this properly

#2843June 19, 2020by abozhinov3 answers
0 reactions

[BUG] Can't remove style property on selected device

Hi, have a problem with removing style property on selected device (clearProperties: true). You can reproduce the problem on https://grapesjs.com/demo.html. Steps:Clean everything.Drag custom code.Add this sample code.Switch devices to tablet or mobile and select the component.In the Typography style you can see that...

abozhinov

@artf do you have idea how can i fix it?

artf

To make the StyleManager read the proper style rule your media query should reflect the same width of the selected Device. Did you try it?

abozhinov

Yes I do it. deviceManager: { devices: [ { name: 'Desktop', width: '', priority: 3 }, { name: 'Tablet', width: '768px', widthMedia: '991px', priority: 2 }, { name: 'Mobile', width: '360px', height: '640px', widthMedia: '767px', priority: 1...

#2842June 19, 2020by BerkeAras3 answers
0 reactions

[Bug]: Text shadow disappears on doubleclick

Hello. I have a problem, that the text shadow on text element disappears when I doubleclick the element. What should I do? Here is my code: https://pastebin.berkearas.de/?e1c4c8db9a70894f#DCUHVHZzyhFTnAk2RoJ9faQxQPvAqWMoiBqXHMEzRH5G

BerkeAras

Edit: The Text Shadow does not disappear. The shadow color is set to the shadow blur, and shadow blur gets 0.

BerkeAras

artf

I can't reproduce it on the main demo so I'd need also a live demo of your case

#2841June 19, 2020by BerkeAras3 answers
1 reactions

[Bug]: Cannot use 'delete key' on keyboard when editing text.

Hello. I have a problem, that I can edit text, but I cant use the delete key on keyboard. Here is my code: https://pastebin.berkearas.de/?e1c4c8db9a70894f#DCUHVHZzyhFTnAk2RoJ9faQxQPvAqWMoiBqXHMEzRH5G

artf

Thanks for the report, I'll push a new release with the fix

aakos

I have the same problem. Version: 0.15.8 Tested: Chrome 83 Tracked it down to keymaster blocking. Running this would let edited text backspace delete: editor.Keymaps.keymaster.unbind('backspace')); Could be this #2758

BerkeAras

@aakos Thank you. `editor.Keymaps.keymaster.unbind('backspace');editor.Keymaps.keymaster.unbind('delete');` works. But there should be a fix for that problem.

#2839June 19, 2020by akashdesale981 answer
0 reactions

[Question] I added one component named template in the blocks but when i try to drag another components inside this template component ,it will be dragged but after saving it removes all the components inside it. How to avoid this?

This is code of template component: I debugged it, so i got that : setComponents method in the dom_components clearing it ...but not getting why it is removing? setComponents calls clear method which is responsible for removing elements inside it I commented this so it was working fine and persisted the components ins...

artf

<template> tag should be treated differently #244