GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? Chrome v131Reproducible demo link https://jsfiddle.net/cmq9end2/1/Describe the bug How to reproduce the bug?Add an img to the canvas with an invalid URL in the srcset Check the network tab in Chrome dev console - the asset r...
GJS Helper
The issue you've described, where an <img> tag with an invalid srcset attribute (and no src attribute) causes an infinite 404 request loop, is a known behavior in some browsers (like Chrome) rather than a direct bug within GrapesJS itself....
GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? 131.0.6778.86Reproducible demo link https://jsfiddle.net/badiuciprian/qe28obhr/1/Describe the bug How to reproduce the bug?try dragging any block to the canvas What is the expected behavior? The component is rendered to the...
mohamedsalem401
I managed to reproduce it. It's only happening on nativeDnD: false. Probably this makes the block view use the API of the old sorter. I will try to push a fix for this.
artf
@mohamedsalem401 can you check this one, please?
badiuciprian
Thanks for taking care of this. I will watch for the update.
GrapesJS version[X] I confirm to use the latest version of [email protected] when this issue was filedWhat browser are you using? Firefox 132, Chrome 131Reproducible demo link https://jsfiddle.net/x54f9v68/1/Describe the bug How to reproduce the bug?Add a custom block, with the media property set to an SVG with...
samex
I believe it depends on the specific SVG being used. If you check the other SVG icons, you'll notice they don't have a fill attribute (inline) on the main <svg> tag but rather on the child <path> tags. By setting the fill="none" attribute...
tonypapousek
@samex Specifying fill="none" did the trick, thanks! That'll deffo help get my custom stuff working more predictably. Past that, I think the main pain point would be trying to use third-party SVGs (e.g. "react-icons") or wysiwyg output tha...
artf
Yeah I'd close this one as it's not strictly related to the core itself but thanks for point this out
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? 130.0.6723.117 Reproducible demo link https://stackblitz.com/edit/grapesjs-react-custom-ui?file=src%2FApp.tsx Describe the bug How to reproduce the bug?open https://grapesjs-react-custom-ui.stackblitz.io/click this button...
danstarns
Hi @maxming2333, try clicking anywhere inside the highlighted area in the text box, for me it loads the code... https://github.com/user-attachments/assets/89f61dc6-466a-476a-b437-d0f8ae51c7ef
maxming2333
Hi @maxming2333, try clicking anywhere inside the highlighted area in the text box, for me it loads the code... Screen.Recording.2024-11-19.at.23.21.03.mov Yes, it can indeed be displayed after clicking on the pop-up window area, but it sh...
GJS Helper
The issue you're encountering stems from how GrapesJS's CodeViewer (which internally uses CodeMirror) interacts with React's rendering lifecycle, especially when embedded within a custom modal. React components manage their own DOM, and ex...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? 130.0.6723.117 Reproducible demo link https://grapesjs.com/demo-mjml Describe the bug How to reproduce the bug?Select a component at random, such as the second mj-section on the demo pageHover this component in the editor...
GJS Helper
The issue you're encountering where calling tagUpdated() on an MJML component breaks its hover functionality and throws an error is due to a mismatch in how tagUpdated() is designed to work versus the specific rendering lifecycle of MJML c...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Arc v1.61.1 Reproducible demo link https://codesandbox.io/s/grapesjs-react-components-n6sff Describe the bug @artf First of all thank you for this amazing library. I was trying to create custom react components within grap...
artf
Yeah, that's expected from the demo perspective. You can play around with the code and find your solution but I'm closing this as it's not a core bug.
GJS Helper
The behavior you're observing, where custom React components are wrapped inside an extra div with GrapesJS-specific attributes, is fundamental to how GrapesJS manages components in the DOM. This div is not an "extra" wrapper in the GrapesJ...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Firefix v132.0 Reproducible demo link https://jsfiddle.net/skdegqun/4/ Describe the bug How to reproduce the bug?Running the fiddle can be appreciated on the logs that the data sources passed on editor initialization were...
artf
You need to wait until the editor is ready.
GJS Helper
The issue you're encountering is a known behavior where the GrapesJS DataSources module does not automatically hydrate its state from the dataSources property within the projectData during editor initialization or when loading from storage...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? latest chrome, firefox, edge Reproducible demo link https://grapesjs.com/demo Describe the bug How to reproduce the bug?drag a acomponent in layer manager and try to put it between other items under bodynot allowed. nestin...
artf
Will be fixed in the next release. Thanks @sumasal for the report and @mohamedsalem401 for the fix ๐โโ๏ธ
sumasal
issue title is somehow clipped. what i meant is it seems to work on older versions such as 0.21.8 and below
GJS Helper
The GrapesJS Layer Manager is designed to allow both reordering components on the same level and nesting components within others. Based on the official GrapesJS demo (https://grapesjs.com/demo) and the latest version of GrapesJS, this fun...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Firefox 131.0 (64-bit) on Linux and Mac Reproducible demo link https://grapesjs.com/demo Describe the bug How to reproduce the bug?Start dragging the "Hover me" buttonTry to put it above the "All text blocks could be edite...
padcom
You guys are awesome! And not a moment too soon :) I have a presentation Today in the afternoon and now I'll be able to show it working on Firefox too!
padcom
I've tracked down the breaking change in Firefox to version 109.0. It's the first one that has the problem. Version 108.0.2 works fine. Hope that helps.
padcom
I have also tested 133.0a1 nightly from 2024-10-24-21-16-15-mozilla-central and the problem is also there.
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome Version 130.0.6723.59 (Official Build) (arm64) Reproducible demo link https://codepen.io/btmkt/pen/QWeOJRB?editors=1111 Describe the bug How to reproduce the bug?Open console.Drop multiple components inside the canv...
artf
@mohamedsalem401 this is probably happening due to the shallow editor. I think it would make sense to leverage the temporary option (which we already use to skip some actions) in canMove. wdyt?
mohamedsalem401
@artf Yes, I suspect it has to do with the shallow editor. Hopefully the temporary option will work and then I'll open a PR
bt-mkt
@mohamedsalem401 this is probably happening due to the shallow editor. I think it would make sense to leverage the temporary option (which we already use to skip some actions) in canMove. wdyt? Hello @artf, The change above, which I saw wa...