Hi, in grapesjs in Firefox 75.0 when "backspace key" (event.which === 8) is pressed the navigator is going back and grapesjs is lost. To reproduce it: Open Firefox browser Open URL: https://grapesjs.com/ Click on: "Newsletter Demo" buttom Delete a element from editor usign "backspace key" (NOT using supr key) The beha...
artf
Should be fixed in the next release
artf
@juice77 the issue was fixed in the latest release https://github.com/artf/grapesjs/compare/v0.16.17...v0.16.18
Hello! I'm trying to add custom component type: And also I'm adding new block: But when I drop this block on the canvas the <td> tag doesn't appear on canvas and DOM. If I remove isComponent function from component definition, it works as expected. Could I get help with this?
artf
@kuhelbeher your code is correct (except is extend: 'cell', and not extends: 'cell',), unfortunately, there is a bug (or a bad logic) applied on the row component, so, for now, I'd suggest adding this as a patch: and now it should work: ht...
noogen
@kuhelbeher because your component is a table per your content definition above and not a td as defined in your addType of tagName property?
kuhelbeher
@noogen I don't think the problem is with this. I tried to define component and block like this: But the problem remains - td tag (and all what is inside of it) doesn't appear on canvas, Maybe I'm doing something wrong? I am trying to crea...
version: latest: v-0.16.3. important: update from v-0.15.9 to v-0.16.3 while keep everything same, the error will show in console: This error show there is a errro in function getFrameOffset, near position: e.ownerDocument.defaultView.frameElement: Refer to This Code Line Checking the error stack will track to This Co...
emilsedgh
I agree that this needs to be reopened and fixed within the destroy function itself.
emilsedgh
Thank you @artf ! π
artf
Thanks for the report @wemod123 Are you able to create a reproducible live demo of the issue?
Hi, you can check this example: https://codepen.io/abozhinov/pen/XWbqjEJ Steps to reproduce the problem:If components existing delete them all.Drag a new carousel block. Select the first children's container.Click on the DUPLICATE icon to create a new component.After that try to select the newest component and then se...
abozhinov
When overwrite these two methods in 'select-comp' command everything works perfectly. The problem was that "el" doesn't exist in the DOM. ` onHovered(em, component) { let result = {}; if (component) { const { view } = component; const { el...
abozhinov
The same result you can get when trigger render instead of reset.
abozhinov
@artf if you try on the demo is the same. Just drag the carousel and click on the slide. <img width="1440" alt="Screenshot 2020-03-16 at 14 58 23" src="https://user-images.githubusercontent.com/1404839/76760669-b8b75780-6796-11ea-8e24-8946...
If I change the state of the visibility btn - gjs will remove display style and then when I click "show layer" - it won't restore display style. I think it's a bug. Gjs should save current display's options on layer visibility button click to restore it.
artf
I agree π
h3llomoto
OK guys I found a hotfix for this problem if you need:
artf
Thanks @h3llomoto the logic is totally correct, I'll make the same change but a bit more idiomatic
Hi @artf , If any component CSS has bottom or right values , not able to drag them. Values are generating as NaN. Attached the screenshot for your reference.
artf
Can you create a reproducible demo?
sdrebel
Can you create a reproducible demo? Hi @artf Demo link is here https://jsfiddle.net/fn43hpj1/2/ You can check the 'Popup' component. Since in Draggable mode style gets overridden, I'm getting the style and update onRender method.
artf
Since in Draggable mode style gets overridden, I'm getting the style and update onRender method. Yeah, that will be fixed in the next release, I'll check later with your example
This bug is also on the online demo : https://grapesjs.com/demo.htmlAdd a Text Block to the page, start typing and hiting enter to make several break lines.Unselect the block.Double click on the block to start editing again. Now if you click on the "view code" button, you will see that the HTML nodes inside the Text B...
artf
Ok I'll try to check this out
pouyamiralayi
@alexiswbr using the below snippet, the `div's will become br`'s as the expected behaviour:
obrazkow
I use such way to prevent transformation to component and keep original html. Just override component that you need, for example text or create new. Maybe it's not good solution, but it works :)
Expected behaviour: After checking certain HTML5 video attributes, they persist across reloads and checkboxes reflect current state. Actual behaviour: After reloading a video for which attributes have already been set, the checkboxes display default value set. Steps to reproduce:Select HTML5 video provider.Select vide...
artf
Found the issue, it will be fixed in the next release
Bug #2478 after release still exists. Repeat steps and you will get error Uncaught TypeError: Cannot read property 'indexEl' of undefined. It can be to reproduce in your demo
artf
Nope π€¦ββοΈ Will be fixed in the next release. thanks @bgrand-ch
artf
Ok seems like we have also to fix the endMove function
If try move cell from table on body then appears error Also error appears on grapesjs demo https://grapesjs.com/demo-newsletter-editor.html
obrazkow
Problem in Sorter. function dimsFromTarget return empty array, when target element not in draggable list see https://github.com/artf/grapesjs/blob/dev/src/utils/Sorter.js#L644(not found target) https://github.com/artf/grapesjs/blob/dev/src...
artf
Can you tell me exactly how to reproduce the error because I don't see any error by dragging off the cell
obrazkow
First error.Select cell wrapper(see on screenshot) and try drag itIn console will appear errors For more details i attach link on two video files. When i tried to reproduce, i found another bug. Try select first component for example text...