For example, I want to add a double click event handler on the default video component to open the assets manager. My basic idea was to get the view definition of the video component and add events + handler. At last, set it back to the video component. Unfortunately, this idea failed in the first step. v.View() gives...
Joshmamroud
@archerbj here's a demo of what you're looking for: https://codesandbox.io/s/sharp-easley-3hrdn?file=/index.js You want to attach the functionality to the component type itself rather than trying to find all instances of that component and...
archerbj
@archerbj here's a demo of what you're looking for: https://codesandbox.io/s/sharp-easley-3hrdn?file=/index.jsYou want to attach the functionality to the component type itself rather than trying to find all instances of that component and...
abulka
@Joshmamroud Thanks for that running example. Yours is the only example I can find of using the extend feature mentioned in the documentation. Your example is very simple and zen - however it merely shows adding a dblclick handler to the v...
Version: 0.16.27 Are you able to reproduce the bug from the demo? [ X] Yes [ ] No What is the expected behavior? When a try to drag a component the canvas should not scroll to the top of the page. Describe the bug detailed Whenever I try to drag a component that is in the last sections of the page, the canvas scroll t...
Hi @artf , You can check it out here https://recordit.co/vn1ZVN6J1N, is not with the sections, it happens with any element but only the first time I try to drag something.
artf
Ah ok, only the first time, I've got it now on my side too π
Version: 0.16.27 Are you able to reproduce the bug from the demo? [] Yes [X] No What is the expected behavior? Paste as plain text (text node) without Grapes JS wrapping pasted text in <font /> element. What is the current behavior? When I paste text as plain text into an empty Text element, the editor wraps it in a <...
Joshmamroud
@artf do you know if this is this happening in the component or the RTE or somewhere else? Could you please point me in the right direction? Any help on this would be greatly appreciated. Thanks!
artf
I can't reproduce it, but I see you're using a custom dm-text component, so that might be a reason?!
Joshmamroud
@artf I don't believe so. Here is the configuration of the dm-text component type Do you see anything here that might be causing it?
ComponentFusionView? That is for sure not from the main grapesjs core, we don't have that component... Probably you're using some kind of modified version, so that might be the reason behind that error
GJSBlock
Thanks for reporting this, @lebonsavane. The error Error: Requires Babel "^7.0.0-0", but was loaded with "6.26.3". If you are sure you have a compatible version of @babel/core, it is likely that something in your build process is loading t...
on click to upload button side preview works fine but when clicking on that video preview it throws error and rest of all images stop working, I need to show video in canvas body like images are shown this is what I am doing Here you see live
mohd7469
@artf can you tell me please how can I upload and preview video files rather then images?
ZeroCoolHacker
@awais786327 I am also struggling with uploading different assets. Maybe this can help. https://grapesjs.com/docs/modules/Assets.html#uploading-assets
ZeroCoolHacker
@awais786327 I have looked at the site and it looks like that you need to add autoplay="true" in your video tag to make it play
Version: 0.16.27 Are you able to reproduce the bug from the demo? [x] Yes [ ] No What is the expected behavior? When adding background-image via Style Manager it show as background-image: url(...);. What is the current behavior? Instead of background-image:url(https://grapesjs.com/docs/logo.png); you will get backgrou...
johnkeel-thork
Was about to report the same problem. Added Image as background: <img width="847" alt="Screenshot 2021-12-23 at 12 06 51" src="https://user-images.githubusercontent.com/26764290/147238562-8df3ea2a-aca7-4b08-9d64-73fd1495d699.png"> Its bein...
artf
Closing as from the same jsfiddle the issue seems to be solved
GJSBlock
Thanks for reporting this, @fq-selbach. The issue with linear-gradient CSS does weird things to background-image appears to be a race condition or state management timing problem. This typically happens when component lifecycle events and...
I'm going to say this is both a feature request as I get into some parts of it, but also a bit of an issue. I would say it looks bad to have a project newer than 2015 that's using px for nearly everything. People are using screensizes that are only 768 pixels on the narrowest plane, whether mobile or desktop, to 2160p...
GJSBlock
Thanks for reporting this, @sadtaco. The issue with FEAT/ISSUE: CSS standards appears to be a race condition or state management timing problem. This typically happens when component lifecycle events and DOM modifications overlap, creating...
Version: 0.16.22 What is the expected behavior? setTarget allows styling a CSS rule different from the selected component Describe the bug Upon calling setTarget method Style Manager still has a selected component as styling target What is the current behavior? setTarget doesn't update this.propTarget.model (updates t...
artf
Thanks @maryia-kabash found the issue, will be fixed in the next release!
maryia-kabash
Hello @artf ! I have a question regarding this fix - setTarget now updates classes in Class section correctly, but Style Manager doesn't reflect the actual styles. Please see - https://prnt.sc/vfzuvv Maybe these is an event that can be tri...
artf
Thanks for the report and the suggestion Maryia. The fix will be available in the next release (I hope to publish it tomorrow)
Hello, I am editing legacy HTML with version 0.16.3 + newsleter-plugin. The style is stored inline (since the tool is used for authoring emails) and I use the feature componentFirst: true . I am facing a problem when trying to edit Component Text that has other text elements inside. Once I edit the text from the paren...
artf
Hi @orosl, thanks for the report. I was able to find and fix the bug so, it'll be available in the next release.
orosl
Hi @artf, thank you very much for your prompt response and release. I upgraded with the latest version 0.16.27. However I still encounter the problem, but with a slightly different behavior. I am not sure if I should open a new issue since...
artf
Thanks @orosl actually the fix was working with inner components but not with nested ones. I'll fix it in the next release
Text imported directly to the wrapper is not removed from the canvas with the component. To verify one can import simple texts multiple times to the demo and watch how they combine instead of replacing the previous one. Adding this seems to help: editor.DomComponents.addType('textnode', { model: { removed() { var el =...
artf
I don't follow your example, can you illustrate exact steps to reproduce, please?
neon12345
Go to the newsletter demo at https://grapesjs.com/demo-newsletter-editor.html and use the "Import template" function with simple text like "hello" but no html (or combine it with html and text on the root level). Repeat this and the text o...
artf
Thanks @neon12345, I was able to find the issue and it should be fixed in the next release