GrapesJS Issues

Search parsed GitHub issues, see highlighted answers, and open the original discussion when needed.

1180 issues found

#3319March 5, 2021by anatoli-dp2 answers
0 reactions

BUG: layers text does not center after creating a new line

Version: current? You can get the version by typing grapesjs.version into the console Are you able to reproduce the bug from the demo? [ ] Yes [ x] No // to be fair never tried in the demo What is the expected behavior? when editing the layers text and adding a new line then backspacing i would expect the edited text...

artf

Ok, I'll push a fix for the editing of layers name, probably it doesn't make sense having new lines enabled there (I'll make stop the editing on Enter/Esc). For the second issue, If you're using something yours to resize the canvas, probab...

anatoli-dp

yeah I didn't realize editor.refresh() was a thing until after. otherwise thanks. awesome project

#3316March 5, 2021by am1rb3 answers
1 reactions

BUG: The editor does not remove the dead script blocks

Version: 0.16.34 Are you able to reproduce the bug from the demo? [ ] Yes [x ] No As I understand the code import dialog skips all the HTML scripts, so I can not reproduce the issue on the demo What is the expected behavior? The editor must remove dead script blocks before appending a new script block at the end of th...

Ju99ernaut

I'm unable to reproduce this, maybe you can provide more information on the custom component itself, anyway I suspect this is a storage related issue. Are you storing then loading pages from the generated html?

Andrew-Chen-Wang

Typically inline scripts go in the body at the bottom. Try putting it there maybe?

am1rb

I do not append anything by myself. The editor appends the scripts related to my components in a new script tag at the end of the generated HTML. Please take a look at this file: https://github.com/artf/grapesjs/blob/dev/src/editor/model/E...

#3310March 5, 2021by Andrew-Chen-Wang2 answers
3 reactions

BUG: Tablet and mobile view not resizing

Version: The one in the demo Are you able to reproduce the bug from the demo? [X] Yes [ ] No What is the expected behavior? Mobile and tablet view should resize the canvas when window resizes. Describe the bug detailed The desktop view properly resizes the canvas when resizing the window What is the current behavior?...

Ju99ernaut

The mobile and tablet devices are pixel pased, so they just resize the canvas to a certain number of pixels regardless of window size. I believe desktop just sets canvas to 100%.

artf

As mentioned by @Ju99ernaut this is how devices work. Honestly, I don't even see the reason behind such a case, why the user should resize the window? You might also start to see/update styles not related to the proper device and that woul...

#3309March 4, 2021by jcamejo3 answers
0 reactions

BUG: TextNodes interfere when changing content on element

Version: 0.16.44 Hi @artf I have a custom block with a custom button component, which its content is similar to this one. <a data-gjs-type="custom_button" class="btn btn-1" href="">Click here</a> Additionally, I've added a text trait to change the button content, in this particular case I do not want to use the editor...

artf

Hi Juan, thanks for the report, are you able to show me how your text trait works? I'd expect it to work correctly if you update your component in this way component.components(e.target.value)

jcamejo

This was my trait I have changed it to And now it works without overriding update content or render children, thanks! I would have never arrived to the conclusion of using the components method. Now i don't like text nodes 😅 I think we ca...

artf

I don't think you need this one target.set('content', value);. For the rest all good 👍

#3307March 3, 2021by neon123453 answers
3 reactions

FEAT: Provide a not minified version

Is there a single file version of grapesjs that is not minified? It would be nice to have one for bug fixing and quick testing of new features/improvements.

neon12345

It is disappointing that this is just closed. Sure I could change my workflow but why not make it as comfortable as possible for people to contribute?

stljeff1

Would somebody kindly explain how to use the sourcemap? I am having a very difficult time upgrading to the latest grapes version, and need any debugging help I can get. I am importing grapesjs into my Angular/Typescript app. I don't unders...

Ju99ernaut

That's already available, just reference grapesjs.js instead of grapesjs.min.js

#3305March 3, 2021by RaresVlaiduc2 answers
11 reactions

BUG: (v0.16.41) Button not set as active on click

Version: v0.16.41 Are you able to reproduce the bug from the demo? [ ] Yes [x] No What is the expected behavior? When I click on a button, the gjs-pn-active class should be added. Describe the bug detailed I have 3 buttons for 3 different devices (desktop, tablet and mobile). I have them on a top panel and when I clic...

Ju99ernaut

Grapesjs requires your commands to have the run and stop functions for them to toggle panel buttons automatically, so maybe that might be the issue:

kerryj89

@Ju99ernaut Thank you for that. Active state is now working for me when creating devices-c panel through grapesjs.init().

#3301March 2, 2021by mmotov1 answer
0 reactions

BUG: Change one copied element affects other copied elements

Version:0.16.41 Are you able to reproduce the bug from the demo? Yes What is the expected behavior? When I'm copying/pasting elements (e.g. text) and making any changes, it should change only the selected element. What is the current behavior? For now, changes applied on all copied elements Are you able to attach scre...

JamieBunyassi

How did you fix this?

#3295March 1, 2021by marcepoblet3 answers
0 reactions

BUG (v0.16.41): Button component with draggable property is not working properly

Version: v0.16.41 Are you able to reproduce the bug from the demo? [ ] Yes [ ] No What is the expected behavior? When we have a button with the property data-gjs-draggable in false, this button not should be dragged in the canvas. Describe the bug detailed StepsSet a button component with draggable property in falseDr...

artf

I guess you're doing something wrong, how do you create those components and their properties?? You shouldn't even see those attributes in the inspector.

marcepoblet

@artf In our codes we have not changed anything. The only difference is that we update the GrapesJs version. Before I had version v0.16.18 and it worked correctly, but now we update GrapesJs to v0.16.41 and it doesn't work for buttons.

marcepoblet

we set the properties with this: editor.getSelected().attributes.attributes["data-gjs-editable"] = 'false' editor.getSelected().attributes.attributes["data-gjs-copyable"] = 'false' editor.getSelected().attributes.attributes["data-gjs-dropp...

#3291February 25, 2021by marcepoblet3 answers
4 reactions

BUG (v0.16.41): the duplicate icon from the icon toolbar is modifying the original element too

Version: v0.16.41 Are you able to reproduce the bug from the demo? [ ] Yes What is the expected behavior? The elements duplicated not should be impact the changes in the original element. Describe the bug detailed steps: select an element (text, image, etc)click on the duplicate icon from the toolbarmodify the new ele...

artf

Thanks for the report guys, I'm aware of the bug and it's already fixed in dev. I've just totally forgot to release it 😬 I'll try to release it today

devtechk

@artf Thanks a lot! you saved me a lot of work _ I was trying to debug this issue all this entire afternoon... then for casuality I've realized, checking npm that the 0.16.44 version was out... You saved man. Thank a lot! Donation, you des...

aadilmehrajbhat

Regression issue since "grapesjs": "0.16.34"

#3290February 25, 2021by marcepoblet2 answers
0 reactions

BUG: The changesCount parameter should be reset to zero when we undo the images

Version: v0.16.41 Are you able to reproduce the bug from the demo? [ ] No What is the expected behavior? The changesCount parameter should be reset to zero when we undo the images Describe the bug detailed Steps:add an imagedelete the imageundo the changes We should see the changesCount parameter should be reset to ze...

GayathriGuru

Hi! @marcepoblet can you please share the part of the code which you used to define the changesCount variable to get it incremented?

artf

Closing this as I don't see any substantial benefit for this functionality