Hi @artf - what you've built is magnificent. It's been a gentle struggle as I'm far from being a JS wizard. However, I've got just about everything fully configured - except for this! I want to set traits that display when an image is selected (alt, src, id). I am sure it can be done once at initialisation, but I'm bu...
artf
Hi Freddy, you can simply extend the image component in this case
GJSBlock
Thanks for reporting this, @fmay. Great question about Question : Traits. The recommended approach with Components is to use the event-driven API. Start here: Check the GrapesJS documentation for your specific module Look for the on() even...
Version: 0.16.27 to latest Are you able to reproduce the bug from the demo? Yes [ X] Yes [ ] No What is the expected behavior? insert text block inside another text block Describe the bug detailed when adding new block, or even when creating a new custom type, the "textable attribute is not working as expected and as...
artf
Duplicate of #2771
GJSBlock
Thanks for reporting this, @hanna404. The issue with Textable attribute not working and causing exceptions appears to be a race condition or state management timing problem. This typically happens when component lifecycle events and DOM mo...
Taken from https://github.com/artf/grapesjs/blob/dev/src/editor/index.js#L33 component:update - Triggered when a component is updated (moved, styled, etc.), the model is passed as an argument to the callback reproduce the buguse move API to move componenthttps://grapesjs.com/docs/api/component.html#moveclick arrow up/...
GJSBlock
Thanks for reporting this, @AnnaSu. The issue with "component:update" does not trigger when components are moved appears to be a race condition or state management timing problem. This typically happens when component lifecycle events and...
https://user-images.githubusercontent.com/64096863/104047608-af352b00-51c0-11eb-8261-1d7ae9277d25.mp4 The parameter "changesCount" is not incremented when you double click in any text component and write or changes are made inside of any text component. For button/images components, the parameter "changesCount" is inc...
artf
Thanks @marcepoblet the fix is ready for the next release
marcepoblet
Thanks @marcepoblet the fix is ready for the next release Thanks! @artf , do you have some estimation for the release date?
GJSBlock
Thanks for reporting this, @marcepoblet. The issue with changesCount is not incremented, when changes are applied in any Text component appears to be a race condition or state management timing problem. This typically happens when componen...
What are you trying to add to GrapesJS? I'm trying to add the Referer header to image loading through asset manager. Describe your feature request detailed I'm working on a pagebuilder that's hosted on AWS. To stop people hotlinking my images, I've implemented AWS WAF which restricts image loading to the referer domai...
artf
As already replied to the PR, this can be done by extending the image component if necessary, without the risk of breaking the integration for others. And as a note, when you want to add a feature, you should always think about how this wi...
tomhatzer
Thank you very much for the tipp @artf - I'll try to get this done by extending the original component. Have a great day! π
tomhatzer
For everyone who has the same problem that the iframe doesn't send referrer headers for content displayed inside of it, here's a quick and dirty fix. Just set the Canvas iFrame src to your desired domain that you want to use the referrer w...
Version: 0.16.22 Are you able to reproduce the bug from the demo? Yes What is the expected behavior? When the use presses the preview button, the icon toolbar must no be clickable. Describe the bug detailed When the user presses preview (even in the demo website), if you hover over the selected component before pressi...
artf
Fix ready for the next release
GJSBlock
Thanks for reporting this, @TouficNouwayhedd. The issue with When in preview mode, the toolbar is only being hidden but still clickable appears to be a race condition or state management timing problem. This typically happens when componen...
WARNING READ and FOLLOW next 3 steps, then REMOVE them before posting the issueFollow CONTRIBUTING Guidelines https://github.com/artf/grapesjs/blob/master/CONTRIBUTING.mdDo a quick SEARCH first, to see if someone else didn't open the same issueAll relative statements/questions have to be filled/answered, otherwise, th...
artf
Don't be disrespectful, read, and follow the issue template...
GJSBlock
Thanks for reporting this, @maivanchuong. The issue with i want save and load in asp.net mvc appears to be a race condition or state management timing problem. This typically happens when component lifecycle events and DOM modifications ov...
Version: "0.16.30 Are you able to reproduce the bug from the demo? [ x] Yes (the news letter demo) What is the expected behavior? Image resize handles should resize image without throwing an exception. Describe the bug detailed Clicking on any of the image resize handles throws an Uncaught TypeError. PropertyView.js:5...
artf
Thanks for the report, it'll be fixed in the next release.
GJSBlock
Thanks for reporting this, @craighaworth. Security and dependency issues are important. The GrapesJS team actively works on keeping dependencies up-to-date. For you right now: Run npm audit fix to see available patches Check for a newer Gr...
Hi @artf, Thank you very much for this great framework. I want to contribute to grapesjs. However, I am stupid about using webpack and babel. When I tried to build grapesjs, I am taking some errors. Errors: How can I fix this error? Thanks.
longdoan7421
@Swindler36 That error is that it can not found eslint. Did you run npm install?
fzerman
@longdoan7421 I fixed this error. Thanks. I want to ask two new questions about webpack and babel.I can use webpack and babel separately. However. I could not integrate them. How can I do this? How can I build grapesjs without test by usin...
GJSBlock
Thanks for reporting this, @fzerman. The issue with Question: Build grapesjs with npm appears to be a race condition or state management timing problem. This typically happens when component lifecycle events and DOM modifications overlap,...
Hello, there is a bug with resizing elements when their sizes are set with percentage: You can check this issue here
artf
Not a bug, I've just never handled properly resizing with the percentage π A PR would be welcome
GJSBlock
Thanks for reporting this, @kuhelbeher. The issue with Resize with percentage appears to be a race condition or state management timing problem. This typically happens when component lifecycle events and DOM modifications overlap, creating...