GrapesJS version [x] I confirm to use the latest version of GrapesJS What browser are you using? Chrome 99 Reproducible demo link https://codesandbox.io/s/distracted-archimedes-fhmnpg Describe the bug How to reproduce the bug?open the demodouble click "I am text" component. What is the current behavior? Double clickin...
artf
Yeah, I see the problem. Double clicking text elements (span, i...) inside a switches focus to the parent a element instead of opening rte for the selected element With the new logic implemented for the text components view, this is intent...
GJSBlock
Thanks for reporting this, @lofcz. Great question about 0.18.3 text editing not triggering for link > text components. The recommended approach with ProseMirror is to use the event-driven API. Start here: Check the GrapesJS documentation f...
GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? Version 1.35.101 Chromium: 98.0.4758.87 (Official Build) (64-bit) Reproducible demo link https://codesandbox.io/s/strange-sun-qgdcq?file=/index.jsDescribe the bug How to reproduce the bug?drop the component in canvasselect t...
artf
Thanks for the report @yadavAtIrisdame but I'm not able to reproduce it from your demo or the official one. Can you describe the exact steps?
yadavAtIrisdame
@artf I'm unable to reproduce this bug. in most cases, The Style Manager works as expected. but, all of a sudden, they start acting like(shown in image). Particularly margin and padding properties.
artf
Sorry but unfortunately without the proper reproducible demo, I can't do much. I'll be happy to fix it if anybody is able to provide the reproducible steps.
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome Version 98.0.4758.80 (Official Build) (arm64) Reproducible demo link https://jsfiddle.net/Lsjhxczp/10/ Describe the bug How to reproduce the bug?Setup the component:mount hook to remove mounted componentAdd a new bl...
artf
Yeah, the problem here is the DOM node is created but not yet appended to the parent. You can defer the removal via setTimeout but that will still trigger the image activation. Probably I'll move that event once the node is appended.
GJSBlock
Thanks for reporting this, @m-jojo-s. Great question about component.remove() in 'component:mount' does not remove the rendered view. The recommended approach with Components is to use the event-driven API. Start here: Check the GrapesJS d...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome Version 97.0.4692.99 (Official Build) (x86_64) Reproducible demo link no Describe the bug How to reproduce the bug?...... What is the expected behavior? ... What is the current behavior? get errors when use the ifra...
GJSBlock
Thanks for reporting this, @jcsofts. Great question about *. The recommended approach with StyleManager is to use the event-driven API. Start here: Check the GrapesJS documentation for your specific module Look for the on() event listener...
GrapesJS version [x] I confirm to use the latest version of GrapesJS What browser are you using? Version 1.34.81 Chromium: 97.0.4692.99 (Official Build) (64-bit) Reproducible demo link https://codesandbox.io/s/strange-sun-qgdcq?file=/index.js Describe the bug How to reproduce the bug?create custom type componentdrop t...
Vac1911
I diagnosed the issue after finding the same problem independently. Looking at StyleManager.select() https://github.com/artf/grapesjs/blob/75cd582a8d1a91096276bc4dccc7475a269ad45c/src/style_manager/index.js#L339-L395 On line 369, every pro...
saudAtIrisdame
@Vac1911 @artf I got it, but what's the solution, how can I fix this problem? is this grapejs issue or mine?
Vac1911
@saudAtIrisdame It seems to be a grapejs issue. I fixed it for myself changing the source code, reordering the select method to check visibility last. Here is the dist file after running build:js https://gist.github.com/Vac1911/4c89f2a4880...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome Reproducible demo link NA Describe the bug AssetManager events are not fired. The file gets uploaded correctly but events are not notified: Code of Conduct [X] I agree to follow this project's Code of Conduct
timramseyjr
@cusmai Did you ever figure this one out? I am getting asset:open and asset:close, but I am not getting any of the events you listed either. I am using the following and the two events I mentioned are the only related asset events I am get...
ALTITUDE-DEV-FR
Same for me not working :(
GJSBlock
Thanks for reporting this, @cusmai. The issue with AssetManager events not working appears to be a race condition or state management timing problem. This typically happens when component lifecycle events and DOM modifications overlap, cre...
GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? Chrome v96Reproducible demo link https://jsfiddle.net/809enL2w/1/Describe the bug I use domComponents: { draggableComponents: false }, to avoid to drag components, only when you drag with the arrow in toolbar, but if do a fa...
artf
Yeah seems like the native HTML5 D&D still works with text selection, I'll try to fix it.
GJSBlock
Thanks for reporting this, @jloguercio. The issue with "Using draggableComponents: false" still drag (clone?) some elements if i try to edit text appears to be a race condition or state management timing problem. This typically happens whe...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Brave V1.34.81 Reproducible demo link https://jsfiddle.net/joshmamroud/vkrcxuzb/41/ Describe the bug How to reproduce the bug?Add a Grid block to the canvasResize a columnNotice the console logs aren't displaying for mouse...
artf
Hi @Joshmamroud CBs should be called when mousePosFetcher is called That is not happening because resizable options are not directly passed to the Resizer, but through the resize command. You can see mousePosFetcher there is handled by the...
Joshmamroud
Thanks @artf! That makes sense.
GJSBlock
Thanks for reporting this, @Joshmamroud. Great question about mousePosFetcher in resizer config & change:style listener not working. The recommended approach with StyleManager is to use the event-driven API. Start here: Check the GrapesJS...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Version 97.0.4692.71 (Official Build) (64-bit) Reproducible demo link https://grapesjs.com/demo.html Describe the bug How to reproduce the bug?Drag and drop the basic blocks in the editor What is the expected behavior?Drag...
artf
I see no issues on my side (latest Chrome version).
sridhar391
@artf We are using the Ubuntu OS with the latest version of chrome browser, please give us an example on how to debug for the drag and drop functionality and please tell us if there is any callback function called while drag and drop block
Vac1911
I am also using ubuntu + chrome and getting the same issue on the demo, the examples in the docs and a locally installed version. Here is a the error message I am getting: Note: no matter which block I drop in the error is the same https:/...
GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? Safari 15.0Reproducible demo link https://jsfiddle.net/adw6y12f/9/Describe the bug Hello, I'm trying to set root component for the editor as it was described here. Unfortunately, this is not working and I can edit all HTML c...
artf
Yeah, the LayerManager module itself has no documentation. Indeed it's on the waiting list for the refactoring and once it's done we can publish more about its usage and API documentation. Anyway, I've seen your previous message about how...
artf
Yeah, I see the issue with the root configuration in LayerManager. The temporary fix would be to trigger the root change on render of the layers panel: But anyway, the root of the LayerManager doesn't decide if your components are editable...
henzigo
Thank you for your answer. It would be nice to have some documentation of what is root element because only mentions are in PR/issues.