GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? Firefox 105.0 (64-bit)Reproducible demo link https://grapesjs.com/demo.htmlDescribe the bug How to reproduce the bug?Opening up the demo Page (https://grapesjs.com/demo.html) in Firefox. What is the expected behaviour? That...
artf
Yeah thanks @Akira-Kuru fixed the issue here https://github.com/artf/grapesjs-preset-webpage/releases/tag/v1.0.2
GJSBlock
Thanks for reporting this, @Akira-Kuru. Great question about Webpage Demo displaying incorrectly on Firefox. The recommended approach with GrapesJS is to use the event-driven API. Start here: Check the GrapesJS documentation for your speci...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chromium 104 Reproducible demo link https://jsfiddle.net/aw8p0h9j/ Describe the bug How to reproduce the bug?Open the jsfiddle link.Click between the divs, then between any of divs and the background. What is the expected...
ronaldohoch
Same as described here, not a issue: https://github.com/artf/grapesjs/issues/4350
artf
Yeah but even in a case of a custom UI, the update is skipped if the value is not changed as it's not necessary.
bit-ocean
The code that I pasted is using the standard api, pretty much copy/paste from the documentation. And clearly the update's mechanism has changed between the versions. Before if target element had been changed, the update was triggered, and...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? chrome Reproducible demo link none Describe the bug image.js : Code of Conduct [X] I agree to follow this project's Code of Conduct
collins-lagat
The release says that there a breaking change. Try that and see if the problem goes away. I got the same error but haven't tried the fix yet. https://github.com/artf/grapesjs/releases/tag/v0.20.1
artf
Yes, as mentioned in the release note you have to switch from the old legacy API for custom component registration.
GJSBlock
Thanks for reporting this, @Aventrue. The issue with After Update to 0.20 from 0.19 the error Cannot assign to read only property 'defaults' of object '[object Object]' occurs appears to be a race condition or state management timing probl...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? 104.0.5112.102 Reproducible demo link https://jsfiddle.net/harsh201/obng5cy2/ Describe the bug How to reproduce the bug?Drag "Textable Component" inside text block.Try editing text within textable block. What is the expect...
GJSBlock
Thanks for reporting this, @harsh201. Great suggestion about Textable Component becomes Noneditable when dropped in a Text Block! While this specific feature isn't yet in the core API, there are several ways to achieve similar behavior. Us...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Safari Reproducible demo link https://grapesjs.com/docs/api/editor.html#editor Describe the bug How to reproduce the bug?Visit https://grapesjs.com/docs/api/editor.html#editorClick "Configuration Object" on line 2 and 33....
artf
Thanks @wunksert the link is already updated and will be fixed on the next release
GJSBlock
Thanks for reporting this, @wunksert. Great question about API Docs Configuration Object link broken. The recommended approach with GrapesJS is to use the event-driven API. Start here: Check the GrapesJS documentation for your specific mod...
GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? anyReproducible demo link anyDescribe the bug Start Pos should also use the MosePosFetcher method if the override is provided right?Start Pos https://github.com/artf/grapesjs/blob/dev/src/utils/Resizer.js#L278-L281Current Po...
artf
Yeah, you're right, I'll fix it, thanks for the report.
GJSBlock
Thanks for reporting this, @Singwai. The issue with Resizer cursor's starting position should also use the mousePosFetcher if provided. appears to be a race condition or state management timing problem. This typically happens when componen...
GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? AnyReproducible demo link See screenshot for codeDescribe the bug Is there anything preventing us from adding the resizer and el in the onEnd callback? Since we are reusing the resizer instance (unless forceNew). I would lik...
artf
Sure, I'll add it, thanks for the suggestion.
GJSBlock
Thanks for reporting this, @Singwai. The issue with Resizer onEnd callback should include the resizer and el object similar to onStart appears to be a race condition or state management timing problem. This typically happens when component...
GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? chrome latestReproducible demo link there is not demoDescribe the bug I want to prevent event but i can't i tried this and how to prevent store event please help Code of Conduct[X] I agree to follow this project's Code of Co...
artf
You can use Discussions if you have questions, Issues are only for reproducible bugs
GJSBlock
Thanks for reporting this, @joukhar. Great question about prevent event using custom plugin. The recommended approach with GrapesJS is to use the event-driven API. Start here: Check the GrapesJS documentation for your specific module Look...
GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? Chrome 104.0.5112.101 Reproducible demo link https://jsfiddle.net/7cLr0xt2/3/Describe the bug How to reproduce the bug? For some reason I'm unable to reproduce the bug inside the fiddle linked above, since line 34 selectedCo...
artf
RTE relies on the DOM content during the editing so if you remove it deliberately with something like inner components will be removed once the editing is finished.
benryanwilliams
Ok thanks @artf, that makes sense. However, those lines of code, along with are required to render the correct selected state inside the canvas as follows (both upon the component initially being rendered and when the user selects a differ...
benryanwilliams
I need to do some more testing but it looks like I've got around this behaviour by saving the inner components inside the component itself when first creating it / editing it, then using the rte:disable hook as follows: It seems a bit hack...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome Reproducible demo link this is a compile error Describe the bug The property custom is missing in the AssetManagerConfig. It works if I use the untyped grapesjs but I want use it with types. Is there a workaround fo...
Singwai
Feel free to update the type definition, here is an example commit. https://github.com/artf/grapesjs/commit/49deeeeab74aff3e46f22d0bb06e7f7608955afd
Thanks for reporting this, @Aventrue. The issue with Custom is missing in the AssetManagerConfig appears to be a race condition or state management timing problem. This typically happens when component lifecycle events and DOM modification...