GrapesJS Issues

Search parsed GitHub issues, see highlighted answers, and open the original discussion when needed.

3464 issues found

#667December 21, 2017by tlatforlz2 answers
0 reactions

Question about Asset Manager

Hi @artf , I have two question about Asset Manager. How I can set a image by select, current logic after I upload image, I must select image in list Asset ? I want after I upload Image, I set it in the component.How I can reload Asset. I write api to save image in Get Image. Image auto save in Asset. I want reload Ass...

artf

Hi @tlatforlz first of all check out the docs page about Assets which could be helpfulHow I can set a image by select, current logic after I upload image, I must select image in list Asset ? I want after I upload Image, I set it in the com...

lock[bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

#665December 20, 2017by SwithFr3 answers
1 reactions

Custom component and save

Sorry, me again ! I'm trying to save my template with my new component "img-link" : But when I save my template using the gjs-get-inlined-html command (it's a newsletter template) it doesn't save the src of my image. Can you help me please ?

SeongwoonHong

The problem with src is here What I think you just should do is to create a custom view where you disable the pointer events on the inner img (eg. in render, in this way you'll always select the img-link model) and then on openModal pass t...

SwithFr

In fact it's seem that the problem comes from the isComponent. My component is detected with his className 'img-link' and the type 'img-link' is return and so re-rendered.

artf

My component is detected with his className 'img-link' and the type 'img-link' is return and so re-rendered. isComponent is used only when an HTML is parsed, so I'm not sure it's the case. What do you get with a simple getHtml? Are you abl...

#664December 20, 2017by SwithFr3 answers
0 reactions

[Solved] Component recognition

Hi. Hi, I created an "img-link" component that as its name indicates is a link that contains an image. When I insert my component into the editor everything works perfectly. But when I want to edit my template afterwards. It no longer recognizes my component as an "img-link" but as a simple image, and therefore no lon...

artf

Hi Jeremy, might this https://github.com/artf/grapesjs/wiki/Components#hints be the case?

SwithFr

Thank with a plugin it's works !

lock[bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

#662December 20, 2017by mingodad1 answer
0 reactions

Small performance issue on storage manager

Hello ! On storage manager "load(keys, clb)" there is an unnecessary Regular expression creation inside a loop that don't need to be there. Here is the fixed code. Cheers !

lock[bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

#661December 20, 2017by mingodad3 answers
0 reactions

Class attribute not removed

Hello ! I noticed a problem with style manager when we add/remove classes. When we remove all classes it doesn't remove then from the generated source. Steps to reproduce: 1- Select an element to style (preferable one without any class) 2- Add a new class 3- Look the generated source code (View code) the class should...

mingodad

Trying to find the problem I can see that the canvas has the class removed but not the model, I'm trying to find where in code it was supposed to be removed but I'm having a hard time finding it. Anyone has any idea ?

mingodad

After several attempts I found a place to clear the class from the model but I'm not sure that this is the best place or form to achieve it. In SectorsView.js:targetUpdated()

artf

Hi @mingodad and thanks for this catch, actually the real issue was updating attributes reference here https://github.com/artf/grapesjs/blob/dev/src/dom_components/model/Component.js#L285 I'll publish the fix in the next release

#660December 20, 2017by TWCM3 answers
1 reactions

Select Parent Function not working when parent element is not selectable

Hi @artf, I have a question about select parent function. Cannot select the parent when parent element is not selectable, suggest to skip the parent element then select parent's parent element until to the div#wrapper.

ryandeba

I could probably help out here - I'll try to make a pull request later today or tomorrow.

TWCM

Hi @ryandeba, Thanks for your effort.

TWCM

Hi @artf, more one question, can i have a enhancement for select command, when the cursor click or hover the element which is not selectable, then the selection jump to available element. Since the element not available to select, i want t...

#659December 20, 2017by tlatforlz2 answers
0 reactions

Custom button Save in Extensions GrapesJS Aviary

Hi, Does way to custom Save button in Extensions GrapesJS Aviary ? https://github.com/artf/grapesjs/wiki

artf

Hi @tranleanhthe it's up to Aviary changing its UI Check the docs https://www.adobe.io/apis/creativecloud/creativesdk/docs/websdk.html

lock[bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

#658December 19, 2017by Deepak8133 answers
0 reactions

Navbar changes

Please let us know what changes has been done in Navbar plugin in grapes.min.js file when mobile view is clicked as we are using older library but Navbar plugin is not working. Menu view is not clicked during mobile view due to what menus are not displayed.

artf

@Deepak813 why you don't update to the latest version?

Deepak813

Hi @artf, Thanks for the message. Actually, we have certain customisation in grapes.min.js file due to which we are not in that position to update to the latest version.so please kindly provide solution for changes done in Navbar plugin in...

artf

Currently, each new release ends the support of the previous one, so in your case, you have to figure it out by yourself what is changed. I highly recommend to update to the latest version and create always plugins for any customization.

#657December 19, 2017by michaellwatson3 answers
1 reactions

Setting values of hidden fields

I have an issue with hidden fields inside a form element, I want to select the form in the editor and then change the values of the hidden fields by clicking on select boxes. I've added the select boxes to a new panel. How do I find the hidden fields within the selected form component and then set their values? The hi...

michaellwatson

Great stuff, grapesjs is amazing btw

artf

Hi Michael, you might want to rely on Component's view for this purpose Probably I'll add find(query) into Component in the next release

michaellwatson

Thanks @artf this is what I ended up with This kind of repeats itself a bit, because each hidden field is picked up in the foreach, but the $el variable holds all of the hidden fields, which is why added the returns to break the loops. Wou...

#656December 18, 2017by michaellwatson3 answers
3 reactions

Add and remove classes programmatically

I want to add and remove classes to a selected element, adding classes is working well, but removing them is not I want to be able to do componentModel.removeClass('form-color'); But its throwing an error. I'd be grateful if someone could share the correct syntax

artf

I'll add removeClass in the next release

juanj

Looking at https://github.com/artf/grapesjs/blob/dev/src/dom_components/model/Component.js#L276 I would say removeClass is not implemented. If you know the other classes I think you can do setClass with an array that don't have the class y...

michaellwatson

That worked great, thanks for your help :)