GrapesJS Issues

3,464 parsed GitHub issues 370 solved · 90 open. Search, filter and explore battle-tested answers.

85 issues found

🔍 help wanted
#2559Feb 10, 2020by majidh12 answers
1 reactions

Bug in toggle className status

If try change checkbox from className in styleManager then appears error error message: Cannot read property 'parentNode' of null <img src="https://imgur.com/download/W78R17J">

adriangroch

@artf any suggestions on where I should start looking to help fix?

artf

Thanks @adriangroch This is from the selector view, event binded to this function

#2420Nov 20, 2019by prestonkscottNo answers
0 reactions

Cancelling block drag in IE breaks canvas functionality.

I'm seeing this issue locally and on the GrapesJS demo when using Internet Explorer. If you drag a block over the canvas and attempt to cancel the drag by either dragging the block back to the starting container, or by pressing escape, a new component is still added to the canvas and the canvas highlighting and toolba...

#2419Nov 20, 2019by MartinPutz3 answers
1 reactions

Absolute dragmode does not work on touch devices

Absolute dragmode (with grapesjs touch plugin) does not work on touch devices. GrapesJS version:0.15.8 Expected behavior: The user should be able to move components using drag and drop on touch screens as well. Current behavior: The user can drag and drop a block just fine. If the user wants to move the dropped compon...

wfcheng

This may or may not be related. I noticed with grapejs v0.16.34 on OSX Safari, the event argument inside onStart() function in src/commands/view/ComponentDrag.js is undefined when I drag a block onto the canvas, which can be reproduced wit...

pradeeshattlee

Hey @MartinPutz The asset manager doesn't pop up on the iPad, desktop on touch devices- chrome, firefox, and safari. And the editor canvas scroll doesn't work on the iPhone. What am I missing? Thanks in advance.

MartinPutz

Hey @pradeeshattlee This issue is not really related to the asset manager, but moving the components around, once they are rendered. I rarely use the asset manager, but as I recall it was working just fine on iPad as well. If I were you I...

#2403Nov 12, 2019by varadero3 answers
0 reactions

Editor.load possibly causes memory leak

How to reproduce:Naviagate to https://grapesjs.com/demo.htmlOpen browser console (Chrome) and type the following: setInterval(() => editor.load(), 1000) and press EnterGo to "Memory" tab (Chrome) and look at the memory usage What happens: The memory is constantly increasing. If you open Chrome's "Performance monitor"...

varadero

This is important. If not fixed, it makes GrapesJS dangerous to use especially in SPA applications.

artf

I'll check it out, but any help is welcome

diazemiliano

I'm having the same issue here. Even after destroy the editor, the issue remains.

#2366Nov 1, 2019by benvmatheson3 answers
1 reactions

Text-shadow removes rgb values when element selected

Example: https://jsfiddle.net/benvmatheson/g1ft06qh/8/ Import a style with a text property. text-shadow:rgb(51, 166, 58) 4px 4px 4px; This works correctly, and the item is displayed correctly. However, once the item is selected, the rgb value is dropped and replaced with 0. text-shadow:0 4px 4px 4px;

benvmatheson

It looks like targetUpdated is run twice when the element is clicked. Once with the correct value rgb(89, 89, 89) 5px 6px 7px and a second time with rgb cleared 0 5px 6px 7px. This would explain why it's confused whether the first or last...

artf

Yeah, I'm already aware of this issue. Unfortunately, the Style Manager parser is quite dumb and what it does is simply splitting the value by a separator, in this case ' ' (space), and distributing splits to relative properties by their o...

benvmatheson

This seems like it could turn into a big project due to cross browser dependencies. Would it be worth bringing in a 3rd party module instead of trying to solve this inside grapes?

#2364Oct 31, 2019by mario-digital3 answers
9 reactions

How to add toolbar functionality to the layers panel.

I am trying to add the toolbar to the layers panel and I am not sure how to go about this. Is there any way to accomplish this? toolbar Where I would like to place them: Thank you for your response guys!

artf

At the moment, there is no easy way to change/customize navigator items content. What we could add next is a new callback option in configs that would be executed inside ItemView template and would allow any HTML content (similar to custom...

mario-digital

@pouyamiralayi This is what i mean

artf

Actually, it should be possible now to use the layerManager.onRender callback option

#2355Oct 25, 2019by ned-kelly3 answers
2 reactions

Rulers support in designer mode?

I know there's an older thread with Rulers support as a suggested roadmap item (but it's been closed) - Just wondering if there's any chance of seeing this in GJS in the future? - Would be an awesome addition - I'm currently in the process of writing crop/bleed marks plugins also for responsive print design (aka one d...

ronaldohoch

Hello, may it help: https://github.com/Ju99ernaut/grapesjs-rulers

artf

Just wondering if there's any chance of seeing this in GJS in the future? Sure we might see it one day but for now, it's not my priority so if someone else would like to start this as a PR it would be great

artf

Thanks @ronaldohoch, I'll close this in favor of the plugin

#2340Oct 18, 2019by senchdenNo answers
0 reactions

Radio properties view crashes in IE11

Function getCheckedEl() in PropertyRadioView.js causes Syntax error in IE11. Observable in web page demo v0.15.8 as Steps to reproduce:Make an action that will call this method, like selecting any nested element in layers manager in a web page demo

#2338Oct 18, 2019by senchdenNo answers
0 reactions

Cannot upload an image in IE11

Steps to reproduce:Drop an image block onto the canvas.In the opened modal, click on the drop zone or drop an image Expected results: New image is added to the list and user is able to select it Actual results: Editor crashes with Reproducible in a web page demo v0.15.8

Browse all topics