GrapesJS Issues

Search parsed GitHub issues, see highlighted answers, and open the original discussion when needed.

3464 issues found

#1421September 12, 2018by Valodya3 answers
0 reactions

[Bug]: "disabled" instead of "active" class for Panel Button View

Hello I assume there is a bug with class when Panel Button is disabled https://github.com/artf/grapesjs/blob/dev/src/panels/view/ButtonView.js#L22

artf

Yeap, the fix is ready for the next release. Thanks

Valodya

thanks @artf for the answer, do you have any estimate when it will be released?

artf

Probably during next week

#1420September 12, 2018by sureshDurai1233 answers
0 reactions

Customizing Block(section block) While Dragging it

Hi I have seen that there was two separate blocks to add 'sections' and 'columns'.We have a flow like when we drag a section into canvas need to show a popup on that we manually able select the section to be one column section/two column section,how do we achieve this. And also we have seen the method editor.on('compo...

nojacko

If your sections always require 1 or 2 columns, why not remove the section and column blocks, instead, add new blocks for "section with 1 column" and "section with 2 columns" and save the popup?

sureshDurai123

Yeah it is possible only .But we have the requirement that we need to show single section to customer and based their pick in popup only we need to split it.

nojacko

Ok. In that case, it's the canvas:drop event. Hook into that, check it's a section and open your modal. I'm not sure on how you insert the columns but hope this helps.

#1419September 11, 2018by Cosmograph3 answers
0 reactions

Your webpage has a glitch

The glitch is quite ironic. It's in "https://grapesjs.com/". It's in the section "Responsive design"; almost half of the image - is beyond my screen's border to the right. I tried on Pale-Moon and the newest FireFox. There isn't even a slider to see the whole image.

nojacko

I don't think that's a glitch. It's quite a common thing for that style of "text next to image" designs. On small screens you still get to see the editor with a mobile sized canvas and on big screens you get to see more. Importantly, nothi...

Cosmograph

I'm not talking about the editor (in which also - part of the text is not visible); rather about your index page (see the link I posted). P.S. - it's true also for some other wide images on that page.

nojacko

Yeah, index page looks fine to me but it would probably help if you provide a screenshot so any issue could be seen and then fixed. (I'm not the creator or a member of the project... just a user.)

#1418September 11, 2018by ageir3 answers
0 reactions

[BUG?] Asset manager not deleting files on server unless upload triggered.

Running latest version (0.14.29) on local server. Using the example webpage preset. Ubuntu 18.04, Chromium 68. Assetmanager init: And extend image type: The all_files variable is load from php, and it has the right data and format, all images stored on the server. The problem is that the onRemove is not triggering as...

artf

Hi Göranbut reappearing when reloading the page you're initializing the asset manager with assets: allfiles so if you don't change allfiles you always get the same set of imagesAlso when dragging an image to the canvas, the image is not sh...

ageir

@artf I don't think you understood me. They are reappearing because they didn't get deleted on the server. all_files are generated via php on page reload, and showing the correct files on the server. The problem is that onRemove isn't trig...

artf

Ah ok probably because your assets are already rendered. Try to apply those changes but inside a plugin

#1416September 11, 2018by dsgh3 answers
0 reactions

[Bug]: Don't mess with onbeforeunload unless user wants to

I have my own window.onbeforeunload handler, and I'm not passing in a noticeOnUnload config to grapesjs, so I wouldn't expect grapesjs to mess with it. PR for this incoming.

artf

Thanks Duarte, fix applied and will be available in the next releaseI'm not passing in a noticeOnUnload config to grapesjs, so I wouldn't expect grapesjs to mess with it. Just a note, noticeOnUnload is true by default 😬

dsgh

Oops, I meant I'm passing a noticeOnUnload as false 😁 Thanks!

lock[bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

#1414September 10, 2018by gabrigcl3 answers
0 reactions

[QUESTION] Component "first render" event

Hi. I'm developing a plugin for charts using chart.js. I need to persist the model of the chart inside the generated component to render the chart on back canvas loads. In order to achieve this, I decided to persist the model of the chart in an HTML atribute of the component. This is the generated HTML of the componen...

artf

You can use onRender

gabrigcl

Thanks, this method works! However, I have to store the model of the chart inside the html of the component, in order to make possible that the generated template render the chart outside the grapesjs editor. I can't persist anything insid...

artf

@gabrigcl I don't understand which is the problem now... I can't persist anything inside a custom html attribute of the component, the way I want But it's exactly what you've showed in your previous post, try elaborate better what you need...

#1413September 10, 2018by aj00222 answers
0 reactions

How To Change the styles of traits

Hi Artf, Thank you for your work, I would like to change the styles of the traits. And when user select video or input's make trait icon active. When we make like that user will understand where they can change video id and also for maps. How can I achieve these work please help me, sir. And also for image alt tags al...

artf

https://github.com/artf/grapesjs/issues/1412#issuecomment-420089769

lock[bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

#1412September 10, 2018by aj00222 answers
0 reactions

Regarding open model for traits

Hi artf, Thanks for your support, I asked you for helping of open modal for traits. please help me to resolve this issue.

artf

@aj0022 I can't help you in this way, start from reading the documentation like everybody else do https://grapesjs.com/docs/getting-started.html

lock[bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

#1411September 10, 2018by zurp2 answers
0 reactions

Manual triggering of the asset manager rendering is required after opening the AM pop-up

Questions Q: Are you using the latest release (older versions are NOT supported)? A: Yes Q. Are you facing the bug with your local copy of GrapesJS or with the current demo? A: Local copy, latest chrome on Linux 64bitThe issue When opening the asset manager via editor.runCommand('open-assets') it should render the lis...

artf

The issue is that currently open-assets doesn't handle correctly the default types option (which I think, in this case, it should return all assets, even not images). I'll fix this in the next release, but for now, what I think it should b...

lock[bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

#1410September 8, 2018by YashPrince3 answers
1 reactions

Drag placeholder Highlighter Postion

@artf When we set some margin from top to the container and want to drag some element inside it then Drag placeholder Highlighter position is not seems right as it included margin also and it's showing top of the element from where margin given. How can I show Drag placeholder Highlighter inside the container only not...

YashPrince

You can check in your demo page. https://grapesjs.com/demo.html https://vimeo.com/289217284

artf

Create a live demo, please

artf

Closing the issue as it seems already to be solved.