Hello! Found a bug with background-color. It cannot be set to #000000 via color-picker in styles. Here's a demo but you can check it yourself in the grapesjs demo: https://user-images.githubusercontent.com/37115006/125304571-62303e00-e336-11eb-9e5d-a5e9d3b1c7e2.mp4 Other colors work fine.
GJSBlock
Thanks for reporting this, @kuhelbeher. The issue with Background color can't be set to #000000 appears to be a race condition or state management timing problem. This typically happens when component lifecycle events and DOM modifications...
Version: 0.17.19 Are you able to reproduce the bug from the demo?[X] Yes[ ] No Reproducible here. What is the expected behavior? Selecting images in the asset manager interface by clicking on them. Describe the bug detailed What is the current behavior? When you change the asset associated with an image component, it'...
artf
Sounds legit, will be updated in the next release
GJSBlock
Thanks for reporting this, @anlumo. The issue with Inconsistent Image Selection appears to be a race condition or state management timing problem. This typically happens when component lifecycle events and DOM modifications overlap, creati...
Version 0.17.19(grapesjs) Version 0.1.5(grapesjs-lory-slider) Version 1.0.6(grapesjs-tabs) Are you able to reproduce the bug from the demo? No What is the expected behavior? I should be able to traverse through different slides and tabs when clicked on previous or next buttons and tab names respectively. Describe the...
artf
Are you able to provide a reproducible demo, please?
TRIGGEREDcoder
Sorry @artf , I was facing this because of the script tag in the generated html which is of no use in angular component html. How can I use the html generated in angular files if the html contains script tag functions.
artf
@TRIGGEREDcoder if the main issue is solved I'm closing this one. Please open a new Discussion if you have questions
Hello @artf , There a generic issue when try to create a layout using float form alignment. The issue is float not clear automatically. how do I add new class in row when user set flow value float left /right <div data-gjs-type="default" draggable="true" data-highlightable="1" class="row" id="iroj"><div data-gjs-type=...
artf
Please follow the issue template
GJSBlock
Thanks for reporting this, @Palash-Mandal. Great question about if I use float from alignment float not clear that's why design issue occur.. The recommended approach with StyleManager is to use the event-driven API. Start here: Check the...
So I'm trying to fetch the selected component and make a block out of it, however, I'm struggling with adding the css of the same. my approach looks like this currently: editor.BlockManager.add(widgetname, { label: widget name, content: editor.getSelectedAll(), category: panelname, attributes: { title: widgetname, cla...
GJSBlock
Thanks for reporting this, @aryanchopra. Thanks for sharing your report about Adding selected component style to a block. To help the team investigate and prioritize this: Please provide: A minimal reproducible example (CodeSandbox/JSFiddl...
I would like to listen to the eye icon in the layer manager from the editor, based on which, I need to write the custom styles. Is there any way we can do that? I got the code, from another issue, I would like to extend the toggleVisibility method from here. Is it possible? if so, how can we do that? Secondly, I would...
GJSBlock
Thanks for reporting this, @sathyanarayananaCES. Great question about [Question]: Event listener to visibility(eye) icon in the Layer Manager. The recommended approach with StyleManager is to use the event-driven API. Start here: Check the...
Hi @artf, I have added the let cc = editor.CssComposer; cc.setRule('.fadetop-animate', { opacity: 0, 'animation-name': 'fadeTop' }, { atRuleType: 'keyframes', atRuleParams: 'fadeTop', selector: 'to', style:{ opacity: 1 } }); as per the Document [](https://grapesjs.com/docs/api/css_composer.html#setrule) however rule f...
artf
Use this one
GJSBlock
Thanks for reporting this, @niranjank151. Great question about @keyframes not adding even after i pass the the keyframes object. The recommended approach with StyleManager is to use the event-driven API. Start here: Check the GrapesJS docu...
GrapesJS code is open to XSS issues because values are inserted into DOM without escaping, e.g. https://github.com/artf/grapesjs/blob/dev/src/assetmanager/view/AssetImageView.js#L30 If model.getFilename() returns <img src=x onerror=alert(document.cookie)>.jpg, this can result in an account takeover. Instead the code s...
aimeos
@artf What are your plans because the vulnerability of GrapesJS to XSS is a pretty big security problem
artf
Yeah thanks for the report @aimeos I'll fix it in the next version for sure
aimeos
@artf The documentation also uses ${var} to insert variables into templates often. This should also be changed to avoid that developers introduce security issues too without knowing that.
Hello @artf , It's a generic issue the width, height property value set to auto while change view to mobile or tablet view. But the auto property not reflects in in CSS that's why desktop value is in there and issue is arise. If I change the value of width to auto and press tab / enter the value still not reflects in...
GJSBlock
Thanks for reporting this, @Palash-Mandal. Great question about *. The recommended approach with StyleManager is to use the event-driven API. Start here: Check the GrapesJS documentation for your specific module Look for the on() event lis...
Hi! I created a DOM component and I was thinking whether it is possible to delete the div wrapper when I delete the child text component. I tried to do it with the removed hook but couldn't came up with the correct solution. Thanks!
GJSBlock
Thanks for reporting this, @sktlmarat. Thanks for sharing your report about Remove the wrapper when the child component is deleted. To help the team investigate and prioritize this: Please provide: A minimal reproducible example (CodeSandb...