Are you using the latest release (older versions are NOT supported)? Yes Are you facing the bug with your local copy of GrapesJS or with the current demo? LocalOS: ArchlinuxBrowser: Firefox 74.0 and Firefox developer edition 75.0b11Grapes: v0.16.3 What is the expected behavior?Highlight should update its position when...
artf
Yeah really weird, my first guess was that canvas toolbars weren't updating on the window scroll, so I've tried to create a non-fullscreen example with a long page but I've realized that there is no scroll listener (on the main window) bec...
tomaskallup
Hi, thanks for the reply! Firefox doesn't seem to be the issue here (same behaviour in Chrome) Also the replication repo works in both browsers without the bug. I'm not loading anything in iframe (this is inspector layout from the actual p...
tomaskallup
@artf I think I found the cause, our root element <div id="β€"> has this style: Adding that to the reproduction repo caused the issue to appear! (Removing the flex seems to fix the issue, I'll investigate if we really need it in our case, b...
First off thanks for all your hard work on the project! This is a very great project that a lot of people depend upon, so thanks for your effort. This is a weird one, but the basic gist of it is that moving your mouse quickly as you click on an element can cause the builder to freeze. This isn't always a huge problem...
artf
Hi @mazuschlag and thanks for your kind words. About the issue, can you elaborate better on the click and move behavior? Should I just select one component and only move around the mouse? There was an issue with moving around components th...
mazuschlag
Hmm that does sort of sound like the problem I was experiencing. This involves holding down the left click on the mouse as you quickly drag a component before releasing it. This happens when working quickly - you click on a component and a...
artf
@mazuschlag so, are you using an old version or the latest of grapesjs? I'm not able to reproduce it on the latest
version: latest: v-0.16.3. important: update from v-0.15.9 to v-0.16.3 while keep everything same, the error will show in console: This error show there is a errro in function getFrameOffset, near position: e.ownerDocument.defaultView.frameElement: Refer to This Code Line Checking the error stack will track to This Co...
emilsedgh
I agree that this needs to be reopened and fixed within the destroy function itself.
emilsedgh
Thank you @artf ! π
artf
Thanks for the report @wemod123 Are you able to create a reproducible live demo of the issue?
Is anyone else having this problem? Or resolved it? Editing on a tablet seems reasonable. While using a mobile device I cannot get the keyboard to display when trying to edit a text field. Even using the grapes touch plugin does not help. There is an example here: http://jsfiddle.net/v9kecdpz/
bgrand-ch
Hello, For future questions or technical issues, which aren't bugs, GitHub's Discussions tab is the place to be. Don't forget to close this issue if it is resolved or write a new detailed message in Discussions -> Q&A category (and close t...
darylamonica
Is there something else I can do to get a response? I included a demo jsfiddle. Many answered questions don't have an example. So, what am I doing wrong?
artf
Give more information about the device (OS, browser, etc.)
Hi, you can check this example: https://codepen.io/abozhinov/pen/XWbqjEJ Steps to reproduce the problem:If components existing delete them all.Drag a new carousel block. Select the first children's container.Click on the DUPLICATE icon to create a new component.After that try to select the newest component and then se...
abozhinov
When overwrite these two methods in 'select-comp' command everything works perfectly. The problem was that "el" doesn't exist in the DOM. ` onHovered(em, component) { let result = {}; if (component) { const { view } = component; const { el...
abozhinov
The same result you can get when trigger render instead of reset.
abozhinov
@artf if you try on the demo is the same. Just drag the carousel and click on the slide. <img width="1440" alt="Screenshot 2020-03-16 at 14 58 23" src="https://user-images.githubusercontent.com/1404839/76760669-b8b75780-6796-11ea-8e24-8946...
Hey @artf I have a question around Asset Manager. When uploading an image via computer or URL You can create image blocks with the command from the left panel and edit them with double click everything Seems to work perfectly. But when I try the same in an iPad or a Touch-enabled device it doesn't work I used this Plu...
bgrand-ch
Hello, For future questions or technical issues, which aren't bugs, GitHub's Discussions tab is the place to be. Don't forget to close this issue if it is resolved or write a new detailed message in Discussions -> Q&A category (and close t...
Hello, We are having a major issue - our layouts use copious amounts of display: flex; flex-direction: column;, and this is causing extreme amounts of lag in Chrome and Safari browsers (not Firefox). If the flex-direction style is set to row, there is no slowdown at all. Sample: https://jsfiddle.net/gkeft254/ click on...
artf
Yeah, it's definitely slower, not sure what is really happening but at the first guess, it might be this function which checks if the component is a block (eg. div) or an inline element (eg. span) https://github.com/artf/grapesjs/blob/1214...
Hello, is there a way to set a modal's width, its currently set to 850px by CSS, but I would like to create a dialog with a small amount of text and its too big for this: But it would be great to get this: Without overriding the CSS, because I would still like to use large modals. I checked the source code and the doc...
ronaldaug
For those who don't know how to use modal attributes. You can add option opts.attributes to modal's open method as below. Because I didn't find how to use it in the documentation here.
kaoz70
OK, what I'm thinking is to create a function to be able to set the width like: setWidth('400px'), and also a method to set custom attributes: setAttributes({'data-custom-attribute': 123}). I think 2 functions are needed because the width...
kaoz70
Hello, sorry I'm piled with work now, if @sunnykgupta can give this a shot it would be great.
There is a custom class added to simple grapesjs project: If there is no devices and user adds the class into the selectors field Settings sector is updated its font-size property correctly. <img width="1440" alt="Screen Shot 2020-02-19 at 2 33 50 AM" src="https://user-images.githubusercontent.com/32596493/74790527-7b...
artf
Unfortunately, this is due to how getComputedStyle works, which returns resolved values, so by using rem instead of px "confuses" the value. At the moment I don't have any plan on fixing this issue but I'd really appreciate a PR or at leas...
artf
This should be fixed in the latest release https://github.com/artf/grapesjs/releases/tag/v0.18.1
If I change the state of the visibility btn - gjs will remove display style and then when I click "show layer" - it won't restore display style. I think it's a bug. Gjs should save current display's options on layer visibility button click to restore it.
artf
I agree π
h3llomoto
OK guys I found a hotfix for this problem if you need:
artf
Thanks @h3llomoto the logic is totally correct, I'll make the same change but a bit more idiomatic