GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome Version 105.0.5195.102 (Official Build) (x86_64) Reproducible demo link Describe the bug How to reproduce the bug?Create a new custom code block and add an iframe tag such as `<iframe src="http://localhost:8888/embe...
artf
Thanks for the report @rahul-singh-bv The bug was actually already reported and fixed https://github.com/artf/grapesjs/issues/4480 but unfortunately the fix is not yet released π
GJSBlock
Thanks for reporting this, @rahul-singh-bv. Security and dependency issues are important. The GrapesJS team actively works on keeping dependencies up-to-date. For you right now: Run npm audit fix to see available patches Check for a newer...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Brave Version 1.31.88 Chromium: 95.0.4638.69 (Official Build) (64-bit) on Linux Reproducible demo link https://jsfiddle.net/0a3o7cL6/ Describe the bug Methods which operate on a component's trait collection (e.g. addTrait...
artf
Yeah, I'll fix it in the next release, thanks
GJSBlock
Thanks for reporting this, @rakelley. Security and dependency issues are important. The GrapesJS team actively works on keeping dependencies up-to-date. For you right now: Run npm audit fix to see available patches Check for a newer Grapes...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Crome 95 Reproducible demo link none Describe the bug How to reproduce the bug?Add ts config fileAdd grapes as dependencyImport Grapes via import * as grapesjs from 'grapesjs'; and @import "~grapesjs/src/styles/scss/main.s...
artf
Hi Denny, thanks for the report. I'm closing this in favor of #3902 as it should be related (even if the error is different). Please try the new version and let me know if it fixes the issue.
marcosvnmelo
I'm working on a React + Typescript project and i'm having this same error on .28 version
GJSBlock
Thanks for reporting this, @denny99. Security and dependency issues are important. The GrapesJS team actively works on keeping dependencies up-to-date. For you right now: Run npm audit fix to see available patches Check for a newer GrapesJ...
Version: latest Are you able to reproduce the bug from the demo?[] Yes[ ] No What is the expected behavior? to editor.I18n.setLocale("es") work in runtime. Describe the bug detailed I don't know if it's a bug or it's not supposed to work this way, also, i don't know backbone enough to know if it's possible, but, when...
artf
Yeah, unfortunately, at the moment the UI (once rendered) is not updating on locale changes, so you would need to rerender the editor.
ronaldohoch
Well, i don't know if backbone have template binding, so i'll close for a while..
leonardolima99
Yeah, unfortunately, at the moment the UI (once rendered) is not updating on locale changes, so you would need to rerender the editor. Has this not been solved yet? I tried to use editor.render(), it works, but it duplicates the panels...
Error: (node:206) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'get' of undefined (node:206) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled wi...
artf
Please follow the issue template
GJSBlock
Thanks for reporting this, @Redix0. Security and dependency issues are important. The GrapesJS team actively works on keeping dependencies up-to-date. For you right now: Run npm audit fix to see available patches Check for a newer GrapesJS...
Version: v0.17.3 Are you able to reproduce the bug from the demo?[x] Yes[ ] No What is the expected behavior? See below What is the current behavior? There is a known security vulnerability in one of the versions of underscore used by a nested dependency. The current version of grapejs utilises backbone-undo ^0.2.5 ht...
emyasnikov
I'm also wondering if backbone-undo is needed or can be replaced by something similar. The package hasn't been updated for 6 years
artf
The package hasn't been updated for 6 years Well, except updating its dependencies (like in this case, for security reason) it's a feature-complete library, there is no need to add/update anything else. Anyway, this PR seems to fix the sec...
chilled-capybara
Thanks for your replyAnyway, this PR seems to fix the security vulnerability at the .lock level but I'm not sure if are kept on a fresh install. I think that might fix the version in the main grapejs repo, but I'm not sure it restricts the...
After npm i we can see that the level of vulnerabilities is unacceptable. added 646 packages from 383 contributors and audited 762 packages in 7.892s found 724 vulnerabilities (353 low, 23 moderate, 348 high) run npm audit fix to fix them, or npm audit for details I'm trying to fix the problem, at least locally. It wi...
AmtechInnovarch
This is why veteran coders with decades of experience disapprove of JS as a back-end language. Javascript is not intended to be a server side language, and these node packages create vulnerabilities that get servers hacked. This is a serio...
KernelDeimos
GrapesJS has a server-side layer?
KernelDeimos
Javascript is not intended to be a server side language, and these node packages create vulnerabilities that get servers hacked. Are you implying that Javascript is the only language where dependancies can introduce security vulnerabilitie...
Is there a way of adding shortcut keys and add-ons for the built in Codemirror editor? I especially want a commenting hot key. There are various plugins that use the Grapesjs editor, incl. https://github.com/artf/grapesjs/issues/324#issuecomment-330571539 and the custom html code plugins https://github.com/Ju99ernaut/...
abulka
I finally got the Grapesjs bundled commentRange to work - it must be invoked directly cm.commentRange not via cm.execCommand. Furthermore, it takes parameters. Thus I was able to get some commenting working, as long as you select the area...
artf
Yeah, I think it's not a problem exposing it in CodeMirrorEditor.js
GJSBlock
Thanks for reporting this, @abulka. Security and dependency issues are important. The GrapesJS team actively works on keeping dependencies up-to-date. For you right now: Run npm audit fix to see available patches Check for a newer GrapesJS...
I was fiddling with ways that you could change the style of elements inside the canvas and i noticed that by using the color-picker trait to set the inline style color property of the element (not the inline style tag that you get through the getCS() ), that style property was completely gone when getHtml() was used.I...
artf
Hi @DodoTrip the reason is that with inline CSS you can't define styles with states (eg. :hover) and media queries, so I've always seen it as a useless limitation instead of a feature. Despite that, you can still use that option if you don...
ThetripGr
Hi @artf and thank you, for your reply. Mind giving me an example on how it is done right now or should avoidInlineStyle make it work easily?
artf
Honestly, I've stopped using avoidInlineStyle a long time ago, but I guess it should work π