GrapesJS Issues

3,464 parsed GitHub issues β€” 370 solved Β· 90 open. Search, filter and explore battle-tested answers.

203 issues found

πŸ” enhancement
#1578Nov 14, 2018by mathiasbc3 answers
3 reactions

Custom request on "src" attributes

I implemented a small GrapesJS editor that allows to edit Django/Jinja2 templates. GrapesJS by default is trying to GET the image preview of my element: <a href="{{producturl}}" target="blank"><img src="{{imageurl}}" width="130"/></a> The request happens everytime I load the template into the GrapesJS editor: http://l...

artf

Hi @mathiasbc by using the latest https://github.com/artf/grapesjs/releases/tag/v0.14.43 It should work with something like this

artf

Hi Mathias, currently the only possibility I see now is to extend the image component and its render() method. Probably I'll add some new component event to make such a case easier to manage

lock[bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

#1577Nov 14, 2018by emilsedgh3 answers
1 reactions

Inline CSS Comments break Code Manager

Apparently this is valid piece of html and css: <div style="color: red; / height 200px; /; font-weight: bold;"> (Hence the commented out height property) Grapesjs has trouble dealing with such attribute as the style attribute on the model is stored as this: The big problem is that CssGenerator's buildFromObject consid...

emilsedgh

Alright I finally managed to reproduce this again. Reopening with better fiddle. The code inside gjs is The CSS retrieved by editor.getCss() is: The bug is that the /* color:#ffffff; doesn't have the closing comment tag. Therefore, it'd re...

artf

Hi Emil, I tried this https://jsfiddle.net/37n5691f/ but can't see the issue

no-response[bot]

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take ac...

#1567Nov 8, 2018by alimajed933 answers
1 reactions

Rte toolbar bug

Hello all, I am using the latest grapesjs stable version (40) and I noticed the following bug in the rich text editor: If the user drags and drop a rich text editor into the canvas, clicks on it and tries to clone it per example (or any action in the toolbar like delete, ...), no action will happen. The user has to se...

arthuralmeidap

PR: https://github.com/artf/grapesjs/pull/1800

artf

Yeah, that happens because of this check, being in editing mode we need to prevent some actions (eg. clicking canc/backspace triggers the same command). Probably we need to put some kind of force option

alimajed93

Hi @artf , Oh I see. Can you please give me some examples of why we added this check? I mean what problems were we having and were solved by this check? Thanks.

#1530Oct 19, 2018by Deepak8131 answer
0 reactions

Click events in undo/redo manager

Hi @artf, I have a issue regarding undo manager and I have checked it's also on your demo page. Problem is that undo manger also count the event when we click on outside the editor section like on the layer button, style button, Block button or any other button which are on top. So if we add a text and then click on l...

artf

Closing as fixed

#1526Oct 18, 2018by gasserol3 answers
2 reactions

How to make fullscreen command

Hi, unfortunately I do not find documentation and can't manage to get it understand from code: I know there is a built-in command 'fullscreen', but with my configuration (from tutorial) it does load only canvas in fullscreen, no panels. Here is my html code: and here my panel code: Can somebody put me on the right way...

electrotype

@nativeer I had the same problem. My workaround is to call stopCommand before runCommand: Seems to work for me.

artf

Good point, the default Fullscreen command enables the fullscreen on the container (#gjs) but with external panels this obviosly doesn't work, and this is why you see only the canvas. I'd really appreciate a PR for a new option which would...

gabjdev

Hi @artf , Above code worked for full screen, but after I exit full screen manually, it doesn't work anymore. Could you post code to exit full screen with same button?

#1516Oct 15, 2018by FrciSmrci3 answers
2 reactions

Ckeditor 5 [enhancement]

Hey @artf , as described in the following task I made a build of the ckeditor 5 which works with GrapesJS, however some of the functionalities don't behave as expected. The bullet points and number points are created without a problem, but the Bold, Italic and Link option aren't. Is there any possibility you could tak...

FrciSmrci

Hi @artf, thanks for the reply. The custom build is not necessary anymore, because the fix was inside the latest release. I'm using the @ckeditor/ckeditor5-editor-inline build version. I'll check out the BountySource and give it a try. :)

FrciSmrci

@Unsigno The code should be a new plugin that can be provided in the GrapesJS like grapesjs-plugin-ckeditor, just that this plugin should support ckeditor5 (grapesjs-plugin-ckeditor5). @gabrigcl developed a great part of the mentioned plug...

artf

Hi @FrciSmrci I can't say it's one of my priorities but you can actually evaluate opening a bounty on https://www.bountysource.com/teams/grapesjs and see if someone else can check it out. BTW I'd prefer an integration with the original CKE...

#1494Oct 10, 2018by DigicreateJens2 answers
0 reactions

Tailwind classes

I'm looking to use Tailwind with GrapesJS, but this framework uses Utility-First CSS Classes to build quick layouts. The problem is that it also uses 'special' classes to define style variants, eg: hover:bg-blue or md:w-full etc. The problem is that the GrapesJS Selector escape function replaces the colons(:) with das...

artf

I'd appreciate a PR :)

lock[bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

#1486Oct 8, 2018by Deepak8132 answers
0 reactions

How to add/remove class undo manager

Hi @artf, Can you please provide the way to add/remove class in undo manager. Also,on live demo when we drag countdown and click on undo button then countdown element does not have any effect on it. Thanks in advance

takecore

I have same problem. Anyone resolved?

artf

I'm closing this one in favor of the general improvement of UndoManager API https://github.com/artf/grapesjs/issues/3639

#1456Sep 25, 2018by Gyanxie3 answers
0 reactions

Npm start not work at version 0.14.33

I downloaded source by zip, and run 'npm i', but I can't run 'npm start'. Here is how I fixed the problem.It works when I change package.json before: after:

artf

Ok but -- -w is intended for the watch on SCSS files, with your change, I think it will not work. (I guess you're using Windows) Probably we should do something like this to make it run cross-platform: Please @Gyanxie try it and let me kno...

Gyanxie

@artf Yes, I use window.I have just try it with your change, but not works.here is an example that it works.npm version

Gyanxie

@artf I has run 'npm list', if it is necessary. npmList.txt

#1448Sep 21, 2018by prestonkscott3 answers
1 reactions

Child component not selectable when using custom view

I'm trying to create a custom component that creates it's own view with nested HTML. I do not want this HTML to be rendered as a component so I use (using jQuery) view: defaultType.view.extend({ init: function () { $(this.el).html('<div class="container"></div>'); }, getChildrenSelector: function () { return '.contain...

artf

If you add elements via View you can't select them, only Models can be selectable Read this page https://grapesjs.com/docs/modules/Components.html you also create new types without isComponent

prestonkscott

@artf I understand how to use isComponent. I will be using fromElement: false so it's not required for how I intend to use grapes. I do not want the elements added to the view to be selected, I do however want nested components to be selec...

artf

Ok, now I got it. The getChildrenContainer should work as you expect, I'll just try to remove those pointer-events stuff and make the hover work more like the select. BTW you don't need jquery, grapesjs under the hood uses cash (which has...

Browse all topics