GrapesJS Issues

Search parsed GitHub issues, see highlighted answers, and open the original discussion when needed.

3464 issues found

#2342October 18, 2019by senchden3 answers
0 reactions

[Feature request] Localisable component text based on page language

It would be great to create pages that would share the component layout, but allow to edit text for each component based on language value set externally (one page per language). Not sharing layout per language is not optimal since if a user edits not only the component text, but also the page layout, all pages in oth...

artf

I18n module is already in the roadmap

senchden

Does this module have any tentative date of implementation?

varadero

Looking at the branch named i18n and i18n module code here: https://github.com/artf/grapesjs/tree/i18n/src/i18n it looks like this module is not for localizing page content that the users are creating but just the GapesJS interface itself,...

#2341October 18, 2019by tom-shermanNo answers
0 reactions

Should use jest runner to run tests

Right now we are using a single main.test.js file to run all of the tests. This stops Jest from running the tests in parallel, so we don't get nice progress bars and it takes ages! We also cannot run only tests relating to changed files. We should switch to using the recommended approach of allowing jest to pickup all...

#2340October 18, 2019by senchdenNo answers
0 reactions

[Bug]: Radio properties view crashes in IE11

Function getCheckedEl() in PropertyRadioView.js causes Syntax error in IE11. Observable in web page demo v0.15.8 as Steps to reproduce:Make an action that will call this method, like selecting any nested element in layers manager in a web page demo

#2338October 18, 2019by senchdenNo answers
0 reactions

[Bug]: Cannot upload an image in IE11

Steps to reproduce:Drop an image block onto the canvas.In the opened modal, click on the drop zone or drop an image Expected results: New image is added to the list and user is able to select it Actual results: Editor crashes with Reproducible in a web page demo v0.15.8

#2337October 17, 2019by navewi3 answers
0 reactions

[BUG / QUESTION] Deleting default styles does not work

Hello, i'm trying to delete some of the default styles of the blocks. I wrote everything I changed in a plugin. I used this function to update for example the Text Components style-defaults: editor.DomComponents.addType(.....) seen here: https://grapesjs.com/docs/modules/Components.html#update-component-type Am I gett...

pouyamiralayi

Hi there! have you tried using setStyle ? cheers.

artf

I'd expect something like this to work (update style-default) Be sure to load your plugin after the mjml one

navewi

Hello @artf, thanks for your reply. this is the exact same code, that i tried out. This one works if I use "style" instead of "style-default".

#2336October 17, 2019by adriangroch1 answer
1 reactions

[QUESTION] `RichTextEditor` update

Hi @artf , I'm thinking of opening a PR for an update on the RichTextEditor. I thought I'd run the idea past you first before getting to work on it. It proposes a change to the actions to have a state, which is an optional function that returns an integer to depict the state of each action; 1 for active, 0 for inactiv...

artf

It proposes a change to the actions to have a state, which is an optional function that returns an integer to depict the state of each action; 1 for active, 0 for inactive, -1 for disabled. Thanks for the suggestion, I think it might be a...

#2335October 16, 2019by logeshkrishna03 answers
2 reactions

Delete icon functionality in the toolbar for the link is not working

WARNING READ and FOLLOW next 5 steps, then REMOVE them before posting the issueFollow CONTRIBUTING Guidelines https://github.com/artf/grapesjs/blob/master/CONTRIBUTING.mdUse the GitHub Issues EXCLUSIVELY for BUGS, FEATURE REQUESTS or QUESTIONS. Prefix the title of the issue with its context, eg. [Bug]: ....Do a quick...

hellocaio

It is working for me... 🤔

hellocaio

The delete icon shows up but when you click the link is not removed, correct? Are you using the latest version of GrapesJS? What browser are you using? Are you changing any properties in the model of the default component link? Post how yo...

logeshkrishna0

here is the exact picture of the delete icon which is not working The above delete icon is not working for the anchor tag but when i add span (by inspect) to the tag it will be deleted. so i want the thing to be shorted out. could you plea...

#2334October 16, 2019by suchiitsme1 answer
1 reactions

Need to add social element to editor

Hi I'm using GrapesJS Newsletter preset. I want a feature like "social element in grapesjs mjml". But instead of font icons i have to use images and a option to upload images and show them.

hellocaio

You need to create a 'block' for that and set its properties according to your specifications. Read the documentation, it explains with examples how to do such things.

#2333October 16, 2019by Ramkumar-Murugesan2 answers
1 reactions

can't able to remove the added traits properties[QUESTION]

Hi, I can able to add the traits properties dynamically by using the following code. but the following code to remove the type name is not working this.get('traits').remove('type'); my complete traits are can anyone please help me

pouyamiralayi

Hi there! provide an id for your trait and try again based on this: `this.removeTrait('trait-id');` cheers!

artf

Use addTrait and removeTrait methods