GrapesJS Issues

Search parsed GitHub issues, see highlighted answers, and open the original discussion when needed.

1180 issues found

#5775March 26, 2024by ctrhub1 answer
0 reactions

BUG: component.get('traits').clone() is no longer available.

GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Arc Version 1.35.0 / Chromium Engine 123.0 Reproducible demo link https://grapesjs.com/demo.html Describe the bug How to reproduce the bug?Open dev toolsSelect a componentRun in console: What is the expected behavior? Shou...

artf

If you need to make a copy of traits I'd suggest simply doing this JSON.parse(JSON.stringify(editor.getSelected().getTraits())). I don't remember ever mentioning cloning traits in docs, so I'd avoid using non-public APIs.

#5768March 19, 2024by rhoenerSBSNo answers
0 reactions

BUG: Wrong Type for "content" property in BlockProperties

GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome v122 Reproducible demo link not applicable Describe the bug The GrapeJs Docs indicate that it is possible to add mixed content to the "content" property of a block (see https://grapesjs.com/docs/modules/Blocks.html#...

#5757March 15, 2024by kuntal8112 answers
1 reactions

BUG: The link titles are not editable

GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome v122, Safari 17 Reproducible demo link https://grapesjs.com/demo.html Describe the bug How to reproduce the bug?Add link component, try editing the link text What is the expected behavior? The link text should be ed...

artf

Thanks for the report, will be fixed in the next release.

Mauzer93

I have the same issue recently.

#5746March 12, 2024by rhoenerSBS3 answers
1 reactions

BUG: ColorPicker Offset incorrect when Panels are outside of Editor Container

GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome v122 Reproducible demo link https://grapesjs.com/docs/getting-started.html#style-manager Describe the bug How to reproduce the bug?Go to the "StyleManager" section of the "Getting Started" doc from GrapeJSTry to use...

bernesto

Hi @artf, The root issue is that we are trying to place a popover palette absolutely positioned over another element at an arbitrary location on the page. And we need to do this even when the origin element is outside of the editor contain...

artf

@bernesto can you check this one as it seems to be related to your changes

bernesto

Yes, I see the issue. The logic needs to account for when the parent is outside of the container. Let me see what I can do there.

#5743March 11, 2024by davidgabrichidze3 answers
5 reactions

BUG: XSS vulnerability in iframe attribute src

GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Edge v122 Reproducible demo link https://jsfiddle.net/bwreyq29/1/ Describe the bug How to reproduce the bug? open this link https://jsfiddle.net/bwreyq29/1/ and javascript code attached to src attribute will be executed au...

bernesto

I think the pre-parser option is a really good idea. It sticks to the 'plug-in' per feature concept. How about updating fromElement to accept a string element ID or boolean. If bool == true, works as it does now, parsing the container HTML...

artf

Totally agree with @bernesto indeed no matter how hard we try to make it safe, it will never be enough and I don't want to give the impression that the library is "so safe" to justify a missing server-side validation. The current options (...

bernesto

This is unavoidable when using fromElement to load from an active DOM element. The element of the page loads and executes synchronously. GrapesJS would never have a chance to process and disarm the XSS html. This would need to be addressed...

#5742March 11, 2024by bernesto3 answers
2 reactions

BUG: Building on Windows 10+

GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome v122 Reproducible demo link N/A Describe the bug How to reproduce the bug?Checkout git onto a Windows 10+ machineBuild using provided procedure. What is the expected behavior? It should build the same as in a *inx s...

bernesto

Yeah, I did all the usual stuff. Lock files, updates, various ways of imports ({}, require, *, full path, etc.) Not sure why, but when I break stuff, I break it good. Always tier 2 or 3 support LMAO. I do believe the issue resides in CLI,...

bernesto

Good points. I have not tried the other versions of Node. I will give that a shot.

artf

Yeah build/serve are managed by the CLI (let's move the issue there) but I'm not sure what might be the problem (no Windows to test 🥲)

#5739March 11, 2024by rhoenerSBSNo answers
0 reactions

BUG: Wrong Type in ColorPickerOptions Interface

GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome v122 Reproducible demo link not applicable Describe the bug The ColorPicker Interface that came with the latest release, defines the "preferredFormat" option to expect a 'boolean' value but the docs of the Spectrum...

#5729March 8, 2024by Sphenox3 answers
1 reactions

BUG: editing/replacing the text inside of a link

GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome v122 Reproducible demo link https://grapesjs.com/demo.html Describe the bug How to reproduce the bug?Open demoCreate a text, with a link in it edit text with the default RTEselect the whole linktype anything, to rep...

bernesto

@artf, you're right again. Whitespace in the node matters. If the text butts right up to the closing node, the first keystroke replaces the text, the next keystroke exits the node, if not, it works as one would expect. There is an old thre...

bernesto

Just to clarify, you are referring to the selection of and editing of the text within the link behaving abnormally like this?

Sphenox

Yeah, excactly as shown in the video you provided.

#5724March 8, 2024by bernesto1 answer
0 reactions

BUG: Whitespace handling in inline elements

GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? Chrome v122Reproducible demo link https://jsfiddle.net/zwo0mdqf/5/Describe the bug How to reproduce the bug?Create valid inline block elements such as span, b, i, em, etc. that use multiple space, tab(s), or line breaks as w...

danstarns

Closing in favor of merged commit. https://github.com/GrapesJS/grapesjs/pull/5719