GrapesJS Issues

3,464 parsed GitHub issues β€” 370 solved Β· 90 open. Search, filter and explore battle-tested answers.

203 issues found

πŸ” enhancement
#3162Nov 27, 2020by sashapawlow7263 answers
0 reactions

Button switcher to editor.allowsCripts

Hello, @artf ! :) Maybe you can help with grapesjs. I have buttons which has own scripts(e.g. opening modal window by click). And if I set property allowScripts: 0 - I can to edit these buttons, but if editor.allowScripts == 1, buttons execute logic(e.g. opening modal window) and I can't to edit buttons in that case....

artf

I'd recommend creating a custom component for those buttons to handle the logic with scripts

sashapawlow726

@artf thank you very much! :+1:

GJSBlock

Thanks for reporting this, @sashapawlow726. Great suggestion about Button switcher to editor.allowsCripts! While this specific feature isn't yet in the core API, there are several ways to achieve similar behavior. Using the event system: A...

#3157Nov 25, 2020by pranay22102 answers
0 reactions

I want to apply script to rte element which is select html element, on selectin…

I want to apply script to rte element which is select html element, on selecting the value for from one select field the dynamic values should get appended to other select field but the script is not working in rte rte.add('custom-childkey', { icon: htmlForChild, // Bind the 'result' on 'change' listener event: 'chang...

artf

Maybe because it's stringify and not stringfy...

GJSBlock

Thanks for reporting this, @pranay2210. Great suggestion about *! While this specific feature isn't yet in the core API, there are several ways to achieve similar behavior. Using the event system: Alternative approaches: Listen to selector...

#3150Nov 23, 2020by michaelVictoriaDev2 answers
0 reactions

Is there a way or tutorial how we can integrate in october cms ?

WARNING READ and FOLLOW next 3 steps, then REMOVE them before posting the issueFollow CONTRIBUTING Guidelines https://github.com/artf/grapesjs/blob/master/CONTRIBUTING.mdDo a quick SEARCH first, to see if someone else didn't open the same issueAll relative statements/questions have to be filled/answered, otherwise, th...

artf

There is already a plugin for October CMS https://octobercms.com/plugin/pkurg-pagebuilder

GJSBlock

Thanks for reporting this, @michaelVictoriaDev. Great suggestion about FEAT: Is there a way or tutorial how we can integrate in october cms ?! While this specific feature isn't yet in the core API, there are several ways to achieve similar...

#3145Nov 17, 2020by sashapawlow7262 answers
0 reactions

How to edit a button if the button has an action (opening a modal window)?

I have a html template. the html template has a button. when you click on the button, an event occurs (opening a modal window). Is it possible to visually change the appearance of a button without firing an event? With allowScript: 0, I can edit the appearance of the button, but in this case, the event does not fire (...

artf

You have to create a custom component for that button if it requires custom logic/behavior from what the original HTML does

GJSBlock

Thanks for reporting this, @sashapawlow726. Great suggestion about FEAT: how to edit a button if the button has an action (opening a modal window)?! While this specific feature isn't yet in the core API, there are several ways to achieve s...

#3139Nov 13, 2020by adamwpe3 answers
0 reactions

Disable <table> being auto amended during save

I'm getting an issue, when saving a custom HTML component (just a table), grapes JS will modify it. before save after save. So I want to be able to insert a table like because I would like to intergate it with twig (a templating language) : I believe it is linked to #606, but I can't see if that helps this problem I'm...

adamwpe

Ah, If I use this https://github.com/artf/grapesjs-custom-code, it does not amend the html during saving. This will not work when using 'gjs-preset-newsletter'. Since if you run command 'gjs-get-inlined-html' then it amends the code. E.g....

artf

You can't insert invalid HTML. If you need to handle stuff like that, you have to create a custom component which then will output the custom code.

GJSBlock

Thanks for reporting this, @adamwpe. Great suggestion about FEAT: Disable <table> being auto amended during save! While this specific feature isn't yet in the core API, there are several ways to achieve similar behavior. Using the event sy...

#3128Nov 10, 2020by sprklinginfo2 answers
0 reactions

Drop a component at the position of the mouse is clicked

What are you trying to add to GrapesJS? When a component is dropped, stay at the position of the mouse is clicked. Describe your feature request detailed I start playing with some basic blocks/components. If I drag and drop a component, e.g, a simple text input, it looks like they snap to the last active component by...

sprklinginfo

found out that is already implemented by using "dragMode: 'absolute'" . thanks.

GJSBlock

Thanks for reporting this, @sprklinginfo. Great suggestion about FEAT: Drop a component at the position of the mouse is clicked! While this specific feature isn't yet in the core API, there are several ways to achieve similar behavior. Usi...

#3121Nov 9, 2020by sadtaco1 answer
0 reactions

FEAT/ISSUE: CSS standards

I'm going to say this is both a feature request as I get into some parts of it, but also a bit of an issue. I would say it looks bad to have a project newer than 2015 that's using px for nearly everything. People are using screensizes that are only 768 pixels on the narrowest plane, whether mobile or desktop, to 2160p...

GJSBlock

Thanks for reporting this, @sadtaco. The issue with FEAT/ISSUE: CSS standards appears to be a race condition or state management timing problem. This typically happens when component lifecycle events and DOM modifications overlap, creating...

#3071Oct 13, 2020by kuhelbeher2 answers
0 reactions

Update listener triggered on initial load

Hello! I found weird bug with update listener. It's triggered on initial load if html code has <img> tag with class attribute: You can check live demo in this sandbox

artf

I'm not sure why it's happening but I'd not assign a high priority to the issue for 1 false-positive update. So, if anyone would like to help in debugging this I'd appreciate

artf

Shouldn't be an issue anymore

#2913Jul 23, 2020by neon123452 answers
1 reactions

Src is stored twice with image

The output of "JSON.stringify(editor.getComponents())" shows that the src of an image is stored twice. { "type": "image", "void": true, "status": "selected", "content": "", "attributes": { "id": "iy3c7", "src": "data:image/png;base64,..." <--- 1. }, "src": "data:image/png;base64,...", <--- 2. "activeOnRender": 0, "ope...

artf

@longdoan7421 I think we can delete it in toJSON method when the src is equal to attribute.src and ensure is loaded back correctly on load

longdoan7421

Hi @artf, I just took a quick look through ComponentImage. I think it is possible to drop the src property in image model and replace the code which use src in ComponentImage and ComponentImageView with the attribute.src. But I am not sure...

Browse all topics